Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 2012858

Summary: sos report --dry-run raises uncaught exception
Product: Red Hat Enterprise Linux 9 Reporter: Pavel Moravec <pmoravec>
Component: sosAssignee: Pavel Moravec <pmoravec>
Status: CLOSED ERRATA QA Contact: Miroslav Hradílek <mhradile>
Severity: medium Docs Contact:
Priority: high    
Version: 9.0CC: agk, bmr, fkrska, mhradile, plambri, rduda, sbradley, theute, upgrades-and-supportability
Target Milestone: rcKeywords: OtherQA, Triaged
Target Release: ---Flags: pm-rhel: mirror+
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: sos-4.2-2.el9 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 2012856 Environment:
Last Closed: 2022-05-17 15:51:43 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2012856    
Bug Blocks:    

Description Pavel Moravec 2021-10-11 13:26:03 UTC 
+++ This bug was initially created as a clone of Bug #2012856 +++

Description of problem:
TL;DR: backport https://github.com/sosreport/sos/pull/2711 .


Version-Release number of selected component (if applicable):
sos-4.2-1


How reproducible:
100%


Steps to Reproduce:
sos report --dry-run --batch --build -o logs


Actual results:
caught exception in plugin method "logs.setup()"
writing traceback to sos_logs/logs-plugin-errors.txt

Traceback:
Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/sos/report/__init__.py", line 977, in setup
    plug.setup()
  File "/usr/lib/python3.6/site-packages/sos/report/plugins/logs.py", line 66, in setup
    self.add_journal(since=since, tags='journal_full', priority=100)
  File "/usr/lib/python3.6/site-packages/sos/report/plugins/__init__.py", line 2512, in add_journal
    priority=priority)
  File "/usr/lib/python3.6/site-packages/sos/report/plugins/__init__.py", line 1660, in _add_cmd_output
    self.log_skipped_cmd(pred, soscmd.cmd, kmods=bool(pred.kmods),
AttributeError: 'NoneType' object has no attribute 'kmods'


Expected results:
No uncaught exception


Additional info:
(also covscan report reveals this, to put some weight to have it in 8.6/9.0)
Comment 1 Pavel Moravec 2021-11-04 09:02:22 UTC 
Self-checking it is fixed:

Previously:

# rpm -q sos
sos-4.2-1.el9.noarch
# sos report --dry-run --batch --build -o logs

sosreport (version 4.2)
..

 Setting up archive ...
 Setting up plugins ...
[plugin:logs] skipped command 'journalctl --disk-usage': (dry run)
[plugin:logs] skipped command 'ls -alRh /var/log/': (dry run)
caught exception in plugin method "logs.setup()"
writing traceback to sos_logs/logs-plugin-errors.txt
 Running plugins. Please wait ...

  Starting 1/1   logs            [Running: logs]

  Finished running plugins


Your sosreport build tree has been generated in:
	/var/tmp/sosreport-pmoravec-rhel9-2021-11-04-lygnwxm


# cat /var/tmp/sosreport-pmoravec-rhel9-2021-11-04-lygnwxm/sos_logs/logs-plugin-errors.txt 
Traceback (most recent call last):
  File "/usr/lib/python3.9/site-packages/sos/report/__init__.py", line 977, in setup
    plug.setup()
  File "/usr/lib/python3.9/site-packages/sos/report/plugins/logs.py", line 66, in setup
    self.add_journal(since=since, tags='journal_full', priority=100)
  File "/usr/lib/python3.9/site-packages/sos/report/plugins/__init__.py", line 2510, in add_journal
    self._add_cmd_output(cmd=journal_cmd, timeout=timeout,
  File "/usr/lib/python3.9/site-packages/sos/report/plugins/__init__.py", line 1660, in _add_cmd_output
    self.log_skipped_cmd(pred, soscmd.cmd, kmods=bool(pred.kmods),
AttributeError: 'NoneType' object has no attribute 'kmods'

#



Now:

# rpm -q sos
sos-4.2-2.el9.noarch
# sos report --dry-run --batch --build -o logs

sosreport (version 4.2)

..

 Setting up archive ...
 Setting up plugins ...
[plugin:logs] skipped command 'journalctl --disk-usage': (dry run)
[plugin:logs] skipped command 'ls -alRh /var/log/': (dry run)
[plugin:logs] skipped command 'journalctl --no-pager ': (dry run)
[plugin:logs] skipped command 'journalctl --no-pager  --catalog --boot ': (dry run)
[plugin:logs] skipped command 'journalctl --no-pager  --catalog --boot -1': (dry run)
 Running plugins. Please wait ...

  Starting 1/1   logs            [Running: logs]

  Finished running plugins


Your sosreport build tree has been generated in:
	/var/tmp/sosreport-pmoravec-rhel9-2021-11-04-azscjrp


# ls /var/tmp/sosreport-pmoravec-rhel9-2021-11-04-azscjrp/sos_logs/
sos.log  ui.log
#
Comment 7 errata-xmlrpc 2022-05-17 15:51:43 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (new packages: sos), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:3932