Bug 20135 - Patch to fix warnings in gcc 2.96
Summary: Patch to fix warnings in gcc 2.96
Alias: None
Product: Red Hat Linux
Classification: Retired
Component: xmms   
(Show other bugs)
Version: 7.0
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Bill Nottingham
QA Contact:
Depends On:
TreeView+ depends on / blocked
Reported: 2000-11-01 06:50 UTC by Stan Bubrouski
Modified: 2014-03-17 02:17 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2000-11-01 06:52:24 UTC
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)
Patch to fix compiler warnings (1.46 KB, patch)
2000-11-01 06:52 UTC, Stan Bubrouski
no flags Details | Diff

Description Stan Bubrouski 2000-11-01 06:50:57 UTC
Attached is a patch to fix the following warnings compiling under gcc 2.96:

xmms-1.2.3/libxmms/formatter.c: string.h needed for strlen and strcpy
xmms-1.2.3/Input/mpg123/id3_frame_text.c: string.h needed for strlen and
memcpy functions
xmms-1.2.3/libxmms/xmmsctrl.c: stdlib.h needed for abs function
xmms-1.2.3/Visualization/blur_scope/blur_scope.c: string.h needed for
memset function

There is also this:

/bin/sh ../../libtool --mode=link gcc  -O2 -march=i386 -mcpu=i686 -Wall
-fomit-frame-pointer -funroll-all-loops -finline-functions -ffast-math
-m486  -o libmikmod.la -rpath /usr/lib/xmms/Input -module -avoid-version
drv_xmms.lo plugin.lo -L/usr/lib -L/usr/X11R6/lib -lgtk -lgdk -rdynamic
-lgmodule -lgthread -lglib -lpthread -ldl -lXi -lXext -lX11 -lm -lpthread
-L/usr/lib -lmikmod -lpthread -ldl -L%prefix/lib -L/usr/lib -lm 
../../libtool: cd: %prefix/lib: No such file or directory
libtool: link: warning: cannot determine absolute directory name of
libtool: link: passing it literally to the linker, although it might fail

notice %prefix is not expanded, this is a problem in mikmod in the
script which is of course part of the mikmod package.  It needs to be
${prefix} rather than %prefix in the script to be interpreted correctly.  I
think the effect of this on xmms compilation is limited although I'm really
not sure.  Any idea on that one?  I submitted it as a bug in mikmod FYI.

Besides some other compiler-related warnings (in unrelated headers) this
patch and a fixed mikmod should make for a clean xmms rebuild.

-Stan Bubrouski

Comment 1 Stan Bubrouski 2000-11-01 06:52:22 UTC
Created attachment 4855 [details]
Patch to fix compiler warnings

Comment 2 Bill Nottingham 2000-11-13 20:09:36 UTC
Should be added in xmms-1.2.3-4. Thanks!

Note You need to log in before you can comment on or make changes to this bug.