Bug 2013759 - Password to git is visible in export summary
Summary: Password to git is visible in export summary
Keywords:
Status: VERIFIED
Alias: None
Product: Red Hat Satellite
Classification: Red Hat
Component: Templates Plugin
Version: 6.10.0
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: 6.14.0
Assignee: Adam Ruzicka
QA Contact: Peter Ondrejka
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-10-13 16:35 UTC by Peter Dragun
Modified: 2023-08-10 08:26 UTC (History)
3 users (show)

Fixed In Version: rubygem-foreman_templates-9.4.0-1
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
screenshot (127.01 KB, image/png)
2021-10-13 16:35 UTC, Peter Dragun
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Foreman Issue Tracker 35824 0 Normal Ready For Testing Redact passwords in URIs before showing them to the user 2022-12-06 09:36:31 UTC
Github theforeman foreman_templates pull 165 0 None open Fixes #35824 - Redact passwords in URIs 2022-12-06 09:36:31 UTC
Red Hat Issue Tracker SAT-14231 0 None None None 2023-06-28 05:49:39 UTC
Red Hat Issue Tracker SAT-14275 0 None None None 2022-12-07 13:07:33 UTC

Description Peter Dragun 2021-10-13 16:35:52 UTC
Created attachment 1832647 [details]
screenshot

Description of problem:
Password(token) to git is visible in export summary if using http authentication.

Version-Release number of selected component (if applicable):


How reproducible:
always

Steps to Reproduce:
1. Navigate to Hosts -> Sync Templates
2. Set Action type to export
3. Export templates to git using http with authentication
4. Submit

Actual results:
Password is visible in url

Expected results:
Password should be redacted

Additional info:

Comment 2 Brad Buckingham 2022-11-03 21:47:07 UTC
Upon review of our valid but aging backlog the Satellite Team has concluded that this Bugzilla does not meet the criteria for a resolution in the near term, and are planning to close in a month. This message may be a repeat of a previous update and the bug is again being considered to be closed. If you have any concerns about this, please contact your Red Hat Account team.  Thank you.

Comment 5 Adam Ruzicka 2023-01-13 14:48:42 UTC
The upstream PR was merged, moving to POST.

Comment 6 Peter Ondrejka 2023-08-09 14:30:04 UTC
Verified on Sat 6.14 snap 10, the password is now redacted in the template export result summary


Note You need to log in before you can comment on or make changes to this bug.