Bug 2013920 - "--collector.filesystem.ignored-mount-points is DEPRECATED and will be removed in 2.0.0, use --collector.filesystem.mount-points-exclude"
Summary: "--collector.filesystem.ignored-mount-points is DEPRECATED and will be remove...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Monitoring
Version: 4.10
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ---
: 4.10.0
Assignee: Arunprasad Rajkumar
QA Contact: Junqi Zhao
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-10-14 06:19 UTC by Junqi Zhao
Modified: 2022-03-10 16:19 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-03-10 16:19:35 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift cluster-monitoring-operator pull 1455 0 None open Bug 2013920: Bump jsonnet dependencies to latest 2021-10-27 12:13:16 UTC
Red Hat Product Errata RHSA-2022:0056 0 None None None 2022-03-10 16:19:54 UTC

Description Junqi Zhao 2021-10-14 06:19:52 UTC
Description of problem:
# oc -n openshift-monitoring logs -c node-exporter node-exporter-xmff9
level=info ts=2021-10-14T04:42:14.123Z caller=node_exporter.go:182 msg="Starting node_exporter" version="(version=1.2.2, branch=rhaos-4.10-rhel-8, revision=3ac98dbf2a13d9ce1884a498d58e39dfd1fee365)"
level=info ts=2021-10-14T04:42:14.123Z caller=node_exporter.go:183 msg="Build context" build_context="(go=go1.16.6, user=root@09d1837c456b, date=20210928-09:10:01)"
level=info ts=2021-10-14T04:42:14.123Z caller=netdev_common.go:74 collector=netdev msg="Parsed flag --collector.netdev.device-exclude" flag=^(veth.*|[a-f0-9]{15})$
level=warn ts=2021-10-14T04:42:14.124Z caller=filesystem_common.go:93 collector=filesystem msg="--collector.filesystem.ignored-mount-points is DEPRECATED and will be removed in 2.0.0, use --collector.filesystem.mount-points-exclude"
...

# oc -n openshift-monitoring get ds node-exporter -oyaml | grep "\--collector.filesystem.ignored-mount-points"
        - --collector.filesystem.ignored-mount-points=^/(dev|proc|sys|var/lib/docker/.+|var/lib/kubelet/pods/.+)($|/)


sh-4.4$ node_exporter --help
usage: node_exporter [<flags>]

Flags:
...
      --collector.filesystem.mount-points-exclude="^/(dev|proc|sys|var/lib/docker/.+)($|/)"  
                                 Regexp of mount points to exclude for filesystem collector.

Version-Release number of selected component (if applicable):
4.10.0-0.nightly-2021-10-09-220031
node-exporter 1.2.2

How reproducible:
for 4.10

Steps to Reproduce:
1. check node-exporter logs
2.
3.

Actual results:
"--collector.filesystem.ignored-mount-points is DEPRECATED and will be removed in 2.0.0, use --collector.filesystem.mount-points-exclude"

Expected results:
no warn info

Additional info:

Comment 1 Jan Fajerski 2021-10-14 11:40:59 UTC
This was fixed upstream in https://github.com/prometheus-operator/kube-prometheus/pull/1407. Seems like it just needs a new release and us updating to that release.

Comment 3 Junqi Zhao 2021-11-03 03:23:37 UTC
checked with 4.10.0-0.nightly-2021-11-02-121455, node-exporter 1.2.2, https://github.com/prometheus-operator/kube-prometheus/pull/1407 is merged, not related to https://github.com/openshift/cluster-monitoring-operator/pull/1455, node-exporter now use "--collector.filesystem.mount-points-exclude"

# oc -n openshift-monitoring get ds node-exporter -oyaml
...
    spec:
      containers:
      - args:
        - --web.listen-address=127.0.0.1:9100
        - --path.sysfs=/host/sys
        - --path.rootfs=/host/root
        - --no-collector.wifi
        - --collector.filesystem.mount-points-exclude=^/(dev|proc|sys|var/lib/docker/.+|var/lib/kubelet/pods/.+)($|/)
        - --collector.netclass.ignored-devices=^(veth.*|[a-f0-9]{15})$
        - --collector.netdev.device-exclude=^(veth.*|[a-f0-9]{15})$
        - --collector.cpu.info
        - --collector.textfile.directory=/var/node_exporter/textfile
        - --no-collector.cpufreq
        image: quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:70e785f4fd4d7df262b7aeb6a74debb0f7b9cc9774a283a5432c47eb0fd79da4
        imagePullPolicy: IfNotPresent
        name: node-exporter

# oc -n openshift-monitoring logs -c node-exporter node-exporter-gv4vx 
level=info ts=2021-11-02T23:45:17.725Z caller=node_exporter.go:182 msg="Starting node_exporter" version="(version=1.2.2, branch=rhaos-4.10-rhel-8, revision=f751538bc6e52af076eac31499a488cb63c1ed81)"
level=info ts=2021-11-02T23:45:17.725Z caller=node_exporter.go:183 msg="Build context" build_context="(go=go1.16.6, user=root@3eaa1f082bd6, date=20211027-15:37:09)"
level=info ts=2021-11-02T23:45:17.725Z caller=filesystem_common.go:110 collector=filesystem msg="Parsed flag --collector.filesystem.mount-points-exclude" flag=^/(dev|proc|sys|var/lib/docker/.+|var/lib/kubelet/pods/.+)($|/)
level=info ts=2021-11-02T23:45:17.725Z caller=filesystem_common.go:112 collector=filesystem msg="Parsed flag --collector.filesystem.fs-types-exclude" flag=^(autofs|binfmt_misc|bpf|cgroup2?|configfs|debugfs|devpts|devtmpfs|fusectl|hugetlbfs|iso9660|mqueue|nsfs|overlay|proc|procfs|pstore|rpc_pipefs|securityfs|selinuxfs|squashfs|sysfs|tracefs)$
level=info ts=2021-11-02T23:45:17.726Z caller=netdev_common.go:74 collector=netdev msg="Parsed flag --collector.netdev.device-exclude" flag=^(veth.*|[a-f0-9]{15})$
level=info ts=2021-11-02T23:45:17.726Z caller=node_exporter.go:108 msg="Enabled collectors"

Comment 6 errata-xmlrpc 2022-03-10 16:19:35 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.10.3 security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:0056


Note You need to log in before you can comment on or make changes to this bug.