Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 2014071

Summary: Payload imagestream new tags not properly updated during cluster upgrade
Product: OpenShift Container Platform Reporter: Kevin Pouget <kpouget>
Component: Cluster Version OperatorAssignee: Jack Ottofaro <jack.ottofaro>
Status: CLOSED ERRATA QA Contact: XiuJuan Wang <xiuwang>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 4.9CC: aos-bugs, jack.ottofaro, lmohanty, yanyang
Target Milestone: ---   
Target Release: 4.10.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-03-10 16:19:35 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2015024    
Attachments:
Description Flags
driver-toolkit tag broken after cluster upgrade none

Description Kevin Pouget 2021-10-14 12:27:22 UTC 
Created attachment 1832928 [details]
driver-toolkit tag broken after cluster upgrade

Description of problem:

When the CVO updates an imagestream which contains *new* tags, the new tags are created without a name.


How reproducible: 100%


Steps to Reproduce:

look at the tags of the driver-toolkit imagestream after a cluster upgrade (upgrade must include an update of RHCOS version):

> oc get is/driver-toolkit -n openshift  -oyaml


Actual results:

the imagesteam tag is populated with the right `from` image, but the `name` field is empty


Expected results:

the imagestream tag must be populated with their name, according to the specification of the new imagestream


Additional info:

in this block: https://github.com/openshift/cluster-version-operator/blob/14d93a158e163f06c2ee936ee29c9c94da7f35fe/lib/resourcemerge/imagestream.go#L22-L27

the value of `required.Name` is lost and not set in `existing.Name`
Comment 3 XiuJuan Wang 2021-10-19 10:03:44 UTC 
Reproduce it when upgrade 4.9 to 4.10.0-0.nightly-2021-10-16-173656

Installed a 4.9.0-0.nightly-2021-10-16-173626 cluster,
$oc get is driver-toolkit  -n openshift -o=jsonpath={.spec.tags[*].name}
49.84.202110142155-0 latest

Upgrade cluster from 4.9 to 4.10.0-0.ci-2021-10-19-025144
$oc get is driver-toolkit  -n openshift -o=jsonpath={.spec.tags[*].name}
410.84.202110151740-0 49.84.202110142155-0 latest

Details http://pastebin.test.redhat.com/1002288
Comment 4 Jack Ottofaro 2021-10-19 12:45:00 UTC 
Moving this back to Assigned in order to change the fix to remove dependency on TagReference struct fields.
Comment 6 XiuJuan Wang 2021-10-20 07:06:14 UTC 
Verified it again upgrade 4.9.0 to 4.10.0-0.ci-2021-10-20-044038
Comment 10 errata-xmlrpc 2022-03-10 16:19:35 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.10.3 security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:0056