Red Hat Bugzilla – Bug 201479
Review Request: perl-Class-Factory-Util
Last modified: 2007-11-30 17:11:39 EST
SRPM URL: http://home.comcast.net/~ckweyl/perl-Class-Factory-Util-1.6-1.fc5.src.rpm
SPEC URL: http://home.comcast.net/~ckweyl/perl-Class-Factory-Util.spec
This module exports utility functions that are useful for factory classes.
One remark: the changelog entry isn't formatted with a leading -
* rpmlint is silent
* package named according to guidelines
* free software licence included
* meets packaging guidelines
* spec legible
* md5sum match upstream
* sane provides
Provides: perl(Class::Factory::Util) = 1.6
* %files right
The combination of GPL and artistic in one file is dubious,
since only verbatim redistribution of the GPL is allowed...
This issue should be taken upstream in my opinion, but is
not a blocker.
+Import to CVS
+Add to owners.list
+Bump release, build for devel
+devel build succeeds
+Request branching (FC-4, FC-5)
Thanks for the review! :)
(In reply to comment #2)
> The combination of GPL and artistic in one file is dubious,
> since only verbatim redistribution of the GPL is allowed...
> This issue should be taken upstream in my opinion, but is
> not a blocker.
I'll send them a note; I've seen a couple modules do this now but it doesn't
appear to be common practice.