We want to remove the "instance_type_id" field from the machine object on 4.10 since it is deprecated in RHV. We need to add a deprecated warning on the following pages: 1. https://docs.openshift.com/container-platform/4.9/machine_management/creating_machinesets/creating-machineset-rhv.html#machineset-yaml-rhv_creating-machineset-rhv We should write that: The "instance_type_id" field is deprecated and will be removed on openshift 4.10. On the "instance_type_id" field number 8. 2. https://docs.openshift.com/container-platform/4.9/installing/installing_rhv/installing-rhv-customizations.html#installation-configuration-parameters-additional-machine_installing-rhv-customizations We should write that: The "instanceTypeID" field is deprecated and will be removed on openshift 4.10. On the "instanceTypeID" field in the table. And a note on the release notes of 4.9. We should write that the "instance_type_id" field of the machine object and the "instanceTypeID" field of the install-config is deprecated and will be removed on openshift 4.10
PR created. Please review: https://github.com/openshift/openshift-docs/pull/37745
Gal, does this only apply to 4.9? Or should I add it in 4.8 and 4.7 as well?
I think you can add it to 4.8 and 4.7
Michael, please review the PR. There is a process for adding a release note, so although comment 0 mentions this as well, please just review the PR right now. We might address the Release Note separately to expedite getting this into the main doc.
Michael, the PR (comment 1) includes links to preview topics where you can see the changes mentioned.
(In reply to Steve Goodman from comment #4) > Michael, please review the PR. > > There is a process for adding a release note, so although comment 0 mentions > this as well, please just review the PR right now. We might address the > Release Note separately to expedite getting this into the main doc. Hi Steve, lgtm! thanks,
As per the OpenShift process for changing the Release Notes for a z-stream release (hopefully we'll hit it before 4.9.1), I need formal Acks on updating the Release Notes from: Eng (Gal) PM (Peter) Product experience...? QE (Michael) DPM (Catherine) Please respond with ACK.
(In reply to Steve Goodman from comment #7) > As per the OpenShift process for changing the Release Notes for a z-stream > release (hopefully we'll hit it before 4.9.1), I need formal Acks on > updating the Release Notes from: > > Eng (Gal) > PM (Peter) > Product experience...? > QE (Michael) Looks good to me > DPM (Catherine) > > Please respond with ACK.
@sgoodman LGTM to please add a release note. Looks like it's deprecated in 4.9. Go ahead and add the release note to 4.9. There is no need to wait until 4.9.1. Thanks
ACK from dev
(In reply to Steve Goodman from comment #7) > As per the OpenShift process for changing the Release Notes for a z-stream > release (hopefully we'll hit it before 4.9.1), I need formal Acks on > updating the Release Notes from: > > Eng (Gal) > PM (Peter) > Product experience...? Ack > QE (Michael) > DPM (Catherine) > > Please respond with ACK.