Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 2015274

Summary:	Yarn dev fails after updates to dynamic plugin JSON schema logic
Product:	OpenShift Container Platform	Reporter:	Jon Jackson <jonjacks>
Component:	Management Console	Assignee:	Vojtech Szocs <vszocs>
Status:	CLOSED ERRATA	QA Contact:	Yadan Pei <yapei>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	4.10	CC:	aos-bugs, yapei
Target Milestone:	---
Target Release:	4.10.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-03-12 04:39:16 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jon Jackson 2021-10-18 18:59:46 UTC

Description of problem:
yarn dev fails after changes introduced in https://github.com/openshift/console/commit/e9b65a16f37a87bb91a2161385e8e5637a5893c2


ERROR in ./packages/console-dynamic-plugin-sdk/generated/schema/plugin-manifest.json
Module build failed (from ./node_modules/thread-loader/dist/cjs.js):
Thread Loader (Worker 1)
/Users/jonjacks/code/openshift/console/frontend/packages/console-dynamic-plugin-sdk/generated/schema/plugin-manifest.json: Unexpected token, expected ";" (2:13)

  1 | {
> 2 |     "$schema": "http://json-schema.org/draft-07/schema#",
    |              ^
  3 |     "type": "object",
  4 |     "additionalProperties": false,
  5 |     "properties": {


Version-Release number of selected component (if applicable):
4.10

How reproducible:
Always

Steps to Reproduce:
1. Run yarn dev on any commit after https://github.com/openshift/console/commit/e9b65a16f37a87bb91a2161385e8e5637a5893c2


Actual results:
yarn dev fails with the above error



Expected results:
yarn dev should complete without errors

Comment 3 Yadan Pei 2021-10-29 05:54:10 UTC

1. clone latest code of console 
2. run `yarn dev` command
yapei-mac:frontend yapei$ yarn dev
yarn run v1.22.15
$ yarn clean && yarn generate && REACT_REFRESH=true NODE_OPTIONS=--max-old-space-size=4096 yarn ts-node ./node_modules/.bin/webpack serve --mode=development --progress
$ rm -rf ./public/dist
$ yarn generate-graphql && yarn build-plugin-sdk
$ graphql-codegen --config graphql-codegen.yml
  ✔ Parse configuration
  ✔ Generate outputs
$ yarn --cwd packages/console-dynamic-plugin-sdk build
$ yarn clean && yarn validate && yarn compile && yarn generate
$ rm -rf dist generated
$ yarn ts-node scripts/validate-extensions.ts
$ ts-node -O '{"module":"commonjs"}' scripts/validate-extensions.ts
Validating Console extension types
Warnings (42)
    Extension type 'PVCCreateProp' has no JSDoc comments
    Extension type 'PVCStatus' has no JSDoc comments
    Extension type 'PVCAlert' has no JSDoc comments
    Extension type 'PVCDelete' has no JSDoc comments
    Extension type 'AddAction' has no JSDoc comments
    Extension type 'AddActionGroup' has no JSDoc comments
    Extension type 'ClusterGlobalConfig' has no JSDoc comments
    Extension type 'HrefNavItem' has no JSDoc comments
    Extension type 'ResourceNSNavItem' has no JSDoc comments
    Extension type 'ResourceClusterNavItem' has no JSDoc comments
    Extension type 'Separator' has no JSDoc comments
    Extension type 'NavSection' has no JSDoc comments
    Extension type 'FileUpload' has no JSDoc comments
    Extension type 'AlertAction' has no JSDoc comments
    Extension type 'AlertAction' property 'alert' has no JSDoc comments
    Extension type 'AlertAction' property 'text' has no JSDoc comments
    Extension type 'AlertAction' property 'action' has no JSDoc comments
    Extension type 'StorageProvider' has no JSDoc comments
    Extension type 'StorageProvider' property 'name' has no JSDoc comments
    Extension type 'StorageProvider' property 'Component' has no JSDoc comments
    Extension type 'TelemetryListener' has no JSDoc comments
    Extension type 'CatalogItemType' has no JSDoc comments
    Extension type 'CatalogItemProvider' has no JSDoc comments
    Extension type 'CatalogItemFilter' has no JSDoc comments
    Extension type 'PodAdapter' property 'adapt' has no JSDoc comments
    Extension type 'BuildAdapter' property 'adapt' has no JSDoc comments
    Extension type 'NetworkAdapter' property 'adapt' has no JSDoc comments
    Extension type 'TopologyDisplayFilters' property 'getTopologyFilters' has no JSDoc comments
    Extension type 'TopologyDisplayFilters' property 'applyDisplayOptions' has no JSDoc comments
    Extension type 'TopologyDecoratorProvider' property 'id' has no JSDoc comments
    Extension type 'TopologyDecoratorProvider' property 'priority' has no JSDoc comments
    Extension type 'TopologyDecoratorProvider' property 'quadrant' has no JSDoc comments
    Extension type 'TopologyDecoratorProvider' property 'decorator' has no JSDoc comments
    Extension type 'TopologyRelationshipProvider' property 'provides' has no JSDoc comments
    Extension type 'TopologyRelationshipProvider' property 'tooltip' has no JSDoc comments
    Extension type 'TopologyRelationshipProvider' property 'create' has no JSDoc comments
    Extension type 'TopologyRelationshipProvider' property 'priority' has no JSDoc comments
    Extension type 'CreateResource' has no JSDoc comments
    Extension type 'UserPreferenceGroup' has no JSDoc comments
    Extension type 'UserPreferenceItem' has no JSDoc comments
    Extension type 'Perspective' has no JSDoc comments
    Extension type 'HorizontalNavTab' has no JSDoc comments
$ for ext in '' '-internal' '-internal-kubevirt' '-webpack' ; do yarn tsc -p tsconfig${ext}.json ; done
$ /Users/yapei/go/src/github.com/openshift/console/frontend/node_modules/.bin/tsc -p tsconfig.json
$ /Users/yapei/go/src/github.com/openshift/console/frontend/node_modules/.bin/tsc -p tsconfig-internal.json
$ /Users/yapei/go/src/github.com/openshift/console/frontend/node_modules/.bin/tsc -p tsconfig-internal-kubevirt.json
$ /Users/yapei/go/src/github.com/openshift/console/frontend/node_modules/.bin/tsc -p tsconfig-webpack.json
$ yarn generate-schema && yarn generate-doc && yarn generate-pkg-assets
$ yarn ts-node scripts/generate-schema.ts
$ ts-node -O '{"module":"commonjs"}' scripts/generate-schema.ts
Generating Console plugin JSON schemas
generated/schema/plugin-package.json
generated/schema/plugin-package.cjs
generated/schema/console-extensions.json
generated/schema/console-extensions.cjs
generated/schema/plugin-manifest.json
generated/schema/plugin-manifest.cjs
$ yarn ts-node scripts/generate-doc.ts
$ ts-node -O '{"module":"commonjs"}' scripts/generate-doc.ts
Generating Console plugin documentation
generated/doc/console-extensions.md
$ yarn ts-node scripts/generate-pkg-assets.ts
$ ts-node -O '{"module":"commonjs"}' scripts/generate-pkg-assets.ts
Generating assets for package @openshift-console/dynamic-plugin-sdk
dist/core/package.json
dist/core/LICENSE
dist/core/README.md
dist/core/doc
Generating assets for package @openshift-console/dynamic-plugin-sdk-internal
dist/internal/package.json
dist/internal/LICENSE
dist/internal/README.md
Generating assets for package @openshift-console/dynamic-plugin-sdk-internal-kubevirt
dist/internal-kubevirt/package.json
dist/internal-kubevirt/LICENSE
dist/internal-kubevirt/README.md
Generating assets for package @openshift-console/dynamic-plugin-sdk-webpack
dist/webpack/package.json
dist/webpack/LICENSE
dist/webpack/README.md
dist/webpack/schema
$ ts-node -O '{"module":"commonjs"}' ./node_modules/.bin/webpack serve --mode=development --progress
Starting type checking service...
<i> [webpack-dev-server] Project is running at:
<i> [webpack-dev-server] Loopback: http://localhost:8080/
<i> [webpack-dev-server] On Your Network (IPv4): http://192.168.31.172:8080/
<i> [webpack-dev-server] On Your Network (IPv6): http://[fe80::1]:8080/
No type errors found
Version: typescript 3.8.3
Time: 267572 ms
   20421 modules

the original errors are gone, moving to VERIFIED

Comment 7 errata-xmlrpc 2022-03-12 04:39:16 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.10.3 security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:0056