Spec URL: https://mhayden.fedorapeople.org/vultr-cli.spec SRPM URL: https://mhayden.fedorapeople.org/vultr-cli-2.8.4-1.fc34.src.rpm Description: Official command line tool for Vultr services. Fedora Account System Username: mhayden
This requires a version bump of golang-github-vultr-govultr-2 to bring in all of the k8s-related items for vultr-cli. I've made a PR there: https://src.fedoraproject.org/rpms/golang-github-vultr-govultr-2/pull-request/1
Spec is correct, but I think shell completion can be improved. - Install completions in _datadir/bash-completion/completions rather than _sysconfdir - zsh and fish completions can be created (optional) - Create completions during %build rather than %install (optional) You can check doctl's spec file for example: https://src.fedoraproject.org/rpms/doctl/blob/rawhide/f/doctl.spec#_82 Once Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "Apache License 2.0", "BSD (3 clause)", "MIT License", "*No copyright* Mozilla Public License 2.0", "BSD (2 clause)", "MIT License Apache License 2.0", "*No copyright* MIT License". 787 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/vultr- cli/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Useful -debuginfo package or justification otherwise. [-]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 61440 bytes in 6 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in golang- github-vultr-cli-devel [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: vultr-cli-2.8.4-1.fc36.x86_64.rpm golang-github-vultr-cli-devel-2.8.4-1.fc36.noarch.rpm vultr-cli-2.8.4-1.fc36.src.rpm vultr-cli.x86_64: W: non-conffile-in-etc /etc/bash_completion.d/vultr-cli vultr-cli.x86_64: W: no-manual-page-for-binary vultr-cli golang-github-vultr-cli-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/vultr/vultr-cli/.goipath vultr-cli.src:65: W: macro-in-%changelog %autochangelog 3 packages and 0 specfiles checked; 0 errors, 4 warnings. Rpmlint (debuginfo) ------------------- Checking: vultr-cli-debuginfo-2.8.4-1.fc36.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://github.com/vultr/vultr-cli/archive/v2.8.4/vultr-cli-2.8.4.tar.gz : CHECKSUM(SHA256) this package : 516be0c9e7915a1c6d631891fdc3327ea8c996f81db78f9676aa676340781f96 CHECKSUM(SHA256) upstream package : 516be0c9e7915a1c6d631891fdc3327ea8c996f81db78f9676aa676340781f96 Requires -------- vultr-cli (rpmlib, GLIBC filtered): libc.so.6()(64bit) golang-github-vultr-cli-devel (rpmlib, GLIBC filtered): go-filesystem golang(github.com/spf13/cobra) golang(github.com/spf13/viper) golang(github.com/vultr/govultr/v2) golang(golang.org/x/oauth2) Provides -------- vultr-cli: vultr-cli vultr-cli(x86-64) golang-github-vultr-cli-devel: golang(github.com/vultr/vultr-cli/cmd) golang(github.com/vultr/vultr-cli/cmd/printer) golang-github-vultr-cli-devel golang-ipath(github.com/vultr/vultr-cli) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name vultr-cli --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Generic, Shell-api Disabled plugins: Java, Python, R, PHP, Haskell, fonts, SugarActivity, Ocaml, Perl Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Thanks, Mikel! I've updated the spec and it seems to be building well in COPR. Spec URL: https://download.copr.fedorainfracloud.org/results/mhayden/vultr-cli/fedora-rawhide-x86_64/02950680-vultr-cli/vultr-cli.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/mhayden/vultr-cli/fedora-rawhide-x86_64/02950680-vultr-cli/vultr-cli-2.10.0-1.fc36.src.rpm Still waiting on an update to the govultr library in BZ 2015280. 🤞🏻
Made a mistake and updated it once more. Spec URL: https://download.copr.fedorainfracloud.org/results/mhayden/vultr-cli/fedora-rawhide-x86_64/02950689-vultr-cli/vultr-cli.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/mhayden/vultr-cli/fedora-rawhide-x86_64/02950689-vultr-cli/vultr-cli-2.10.0-1.fc36.src.rpm
Simplified the bash completions a bit more. Spec URL: https://download.copr.fedorainfracloud.org/results/mhayden/vultr-cli/fedora-rawhide-ppc64le/02951409-vultr-cli/vultr-cli.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/mhayden/vultr-cli/fedora-rawhide-ppc64le/02951409-vultr-cli/vultr-cli-2.10.0-1.fc36.src.rpm
spec looks good now! fedora-review+ thanks!
Thanks a bunch, Mikel! 🤗 Repo requested: https://pagure.io/releng/fedora-scm-requests/issue/37478
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/vultr-cli
🛑 Can't build this one until https://bugzilla.redhat.com/show_bug.cgi?id=2015280 is solved. Emailed Robert-André to see how I can help.
Now in rawhide.