Spec URL: https://download.nohats.ca/golang-github-apparentlymart-cidr/golang-github-apparentlymart-cidr.spec SRPM URL: https://download.nohats.ca/golang-github-apparentlymart-cidr/golang-github-apparentlymart-cidr-1.1.0-1.fc34.src.rpm Description: Go library for CIDR manipulations Fedora Account System Username: pwouters
Hi Paul, I hope that someone reviews and approves your package soon; I am creating another package that requires this one. I am not a package reviewer, but I do have one suggestion: I think you can remove the `%{expand:}` from the `common_description` definition. The value is only one line and it does not contain any macros. Thanks, Maxwell
Upstream lacks documentation, but the PR with README is opened. This package is dated (~1.5 years since the last commit) but is used by hundreds of packages (see https://github.com/apparentlymart/go-cidr/network/dependents). Approved. [NOTE] Lots of other packages own /usr/share/gocode/src/github.com, it's fine. Can't be fixed here anyway. [NOTE] rpmlint errors on golang-github-apparentlymart-cidr-devel.noarch can be ignored. Not something that can be fixed here. [NOTE] rpmlint error on golang-github-apparentlymart-cidr.src is invalid. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. Licenses found: "Unknown or generated", "Expat License". 5 files have unknown license. Detailed output of licensecheck in /home/rominf/dev/fedora-scm/review/2015315-golang- github-apparentlymart-cidr/licensecheck.txt [-]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/gocode/src/github.com [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: golang-github-apparentlymart-cidr-devel-1.1.0-1.fc36.noarch.rpm golang-github-apparentlymart-cidr-1.1.0-1.fc36.src.rpm golang-github-apparentlymart-cidr-devel.noarch: W: no-documentation golang-github-apparentlymart-cidr-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/apparentlymart/go-cidr/.goipath golang-github-apparentlymart-cidr.src: W: no-%build-section 2 packages and 0 specfiles checked; 0 errors, 3 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://github.com/apparentlymart/go-cidr/archive/v1.1.0/go-cidr-1.1.0.tar.gz : CHECKSUM(SHA256) this package : 359897e7e89bf1d8efa69ae5ec490c0a88ba4892fffbf94b17244355e0893503 CHECKSUM(SHA256) upstream package : 359897e7e89bf1d8efa69ae5ec490c0a88ba4892fffbf94b17244355e0893503 Requires -------- golang-github-apparentlymart-cidr-devel (rpmlib, GLIBC filtered): go-filesystem Provides -------- golang-github-apparentlymart-cidr-devel: golang(github.com/apparentlymart/go-cidr/cidr) golang-github-apparentlymart-cidr-devel golang-ipath(github.com/apparentlymart/go-cidr) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 2015315 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: Haskell, C/C++, Python, Ocaml, SugarActivity, R, fonts, Java, PHP, Perl Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-apparentlymart-cidr
Hi Maxwell, I incorporated your fix. Note that reviewers are always great, and I have a few more golang packages waiting on formal review for inclusion :)
FEDORA-2021-aa0e471501 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-aa0e471501
FEDORA-2021-1b128324e2 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-1b128324e2
FEDORA-2021-1b128324e2 has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-1b128324e2 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-1b128324e2 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2021-aa0e471501 has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-aa0e471501 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-aa0e471501 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2021-aa0e471501 has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2021-1b128324e2 has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report.