Created attachment 1834568 [details]
modified backup vm script
Description of problem:
After starting a backup it is possible to manipulate the backed up disk, this happens because the memory lock is released by a child command.
This can be reproduced with the attached modified backup_vm.py script which attempts to detach the VM's disk immediately after backup starts. The operation should be blocked but it possible to detach the disk and even delete it later
Version-Release number of selected component (if applicable):
Steps to Reproduce:
1. Start a VM
2. run the attached modified backup_vm.py script
Disk detachment succeeds
Disk detachment should fail
I Used the flow Benny mentioned with the attached script.
I ran the script like the following:
python3 backup_vm_modified.py -c engine start <vm_id>
The expected output matched the actual output.
I got the following error message when running the script from vdsm:
"fault reason is "Operation Failed". Fault detail is "[Cannot hot unplug Virtual Disk. The VM is during a backup operation.]". HTTP response code is 409" - which indicates that the disk detachment failed (as expected).
This bugzilla is included in oVirt 4.4.10 release, published on January 18th 2022.
Since the problem described in this bug report should be resolved in oVirt 4.4.10 release, it has been closed with a resolution of CURRENT RELEASE.
If the solution does not work for you, please open a new bug report.
We would not check this flow in our automation since it will be hard to reproduce and will require running a script that our customers do not have.