Bug 2015527 - Review Request: golang-github-cheggaaa-pb-3 - Console progress bar for Golang
Summary: Review Request: golang-github-cheggaaa-pb-3 - Console progress bar for Golang
Keywords:
Status: CLOSED CANTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2015296
TreeView+ depends on / blocked
 
Reported: 2021-10-19 12:42 UTC by Major Hayden 🤠
Modified: 2022-01-17 19:11 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-01-17 19:11:21 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Major Hayden 🤠 2021-10-19 12:42:56 UTC
Spec URL: https://mhayden.fedorapeople.org/golang-github-cheggaaa-pb-3.spec
SRPM URL: https://mhayden.fedorapeople.org/golang-github-cheggaaa-pb-3-3.0.8-1.fc34.src.rpm

Description:

Console progress bar for Golang.

Fedora Account System Username: mhayden

Comment 1 Major Hayden 🤠 2021-10-19 12:46:45 UTC
The v1 for this source seems to be packaged here: https://src.fedoraproject.org/rpms/golang-gopkg-cheggaaa-pb-1

However, I can't find v1 in the upstream repo any longer and hcloud (BZ 2015296) requires pb >= 3.0.

Comment 2 Mikel Olasagasti Uranga 2021-11-10 21:29:58 UTC
Can't build this:

Testing    in: /builddir/build/BUILD/pb-3.0.8/_build/src
         PATH: /builddir/build/BUILD/pb-3.0.8/_build/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/sbin
       GOPATH: /builddir/build/BUILD/pb-3.0.8/_build:/usr/share/gocode
  GO111MODULE: off
      command: go test -buildmode pie -compiler gc -ldflags " -X github.com/cheggaaa/pb/v3/version=3.0.8 -extldflags '-Wl,-z,relro -Wl,--as-needed  -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  '"
      testing: github.com/cheggaaa/pb/v3
github.com/cheggaaa/pb/v3
FAIL    github.com/cheggaaa/pb/v3 [setup failed]
# github.com/cheggaaa/pb/v3
package github.com/cheggaaa/pb/v3_test
        imports github.com/cheggaaa/pb: no Go files in /builddir/build/BUILD/pb-3.0.8/_build/src/github.com/cheggaaa/pb
RPM build errors:
error: Bad exit status from /var/tmp/rpm-tmp.9UU5PZ (%check)
    Bad exit status from /var/tmp/rpm-tmp.9UU5PZ (%check)

Comment 3 Mikel Olasagasti Uranga 2021-11-11 11:04:20 UTC
The failure was using fedora-review directly against the BZ. I've been able to build it with mock, but I've been also able to reproduce with mock by setting:

%global goipath         github.com/cheggaaa/pb/v3

Then, rpmbuild against the spec creates golang-github-cheggaaa-pb-3.0.8-1.fc35.src.rpm not golang-github-cheggaaa-pb-3-3.0.8-1.fc35.src.rpm, so I'm confused how you generated that srpm file.

Checking the generated srpm using the spec fedora-review complains about:

- Package does not use a name that already exists.
  Note: A package with this name already exists. Please check
  https://src.fedoraproject.org/rpms/golang-github-cheggaaa-pb
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/Naming/#_conflicting_package_names
- Spec file name must match the spec package %{name}, in the format
  %{name}.spec.
  Note: golang-github-cheggaaa-pb-3.spec should be golang-github-cheggaaa-
  pb.spec
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/#_spec_file_naming

Comment 4 Major Hayden 🤠 2021-11-11 14:05:20 UTC
Yeah, the challenge here is that this software is difficult to package. For example, if I set:

%global goipath         github.com/cheggaaa/pb/v3

Then the tests fail (since the tests are in github.com/cheggaaa/pb and not github.com/cheggaaa/pb/v3.

But If I set:

%global goipath         github.com/cheggaaa/pb

then rpmlint complains that the spec file is incorrectly named.

I'd gladly take guidance here if someone knows this better. I've tried "%global goaltipaths" as well and it didn't change anything.

Comment 5 Zbigniew Jędrzejewski-Szmek 2021-11-21 13:36:50 UTC
We need some Go expert.


Note You need to log in before you can comment on or make changes to this bug.