+++ This bug was initially created as a clone of Bug #1986060 +++

Package openstack-network-scripts is build of the network-scripts sub package of initscripts that is no longer shipped in EL9 but we still require it for tripleo/puppet-vswitch.

Git source repository: https://github.com/fedora-sysv/initscripts

Initial spec: https://github.com/mwhahaha/openstack-network-scripts-distgit/blob/main/openstack-network-scripts.spec


--- Additional comment from Alex Schultz on 2021-07-28 13:41:56 UTC ---

Per Bug 1986439, the openvswitch network-scripts will continue to exist unless the upstream removes it.

--- Additional comment from Alan Pevec (Fedora) on 2021-09-19 06:23:09 UTC ---

CS9 is now at 10.11.1 https://gitlab.com/redhat/centos-stream/rpms/initscripts/-/blob/c9s/initscripts.spec

/me figuring out how to closely track it in RDO Trunk with CS9 distgit as upstream source

--- Additional comment from Alan Pevec (Fedora) on 2021-09-19 22:39:56 UTC ---

Spec URL: https://apevec.fedorapeople.org/rdo/openstack-network-scripts.spec
SRPM URL: https://apevec.fedorapeople.org/rdo/openstack-network-scripts-10.11.1-1.el9.src.rpm

Decription: Legacy scripts for manipulating of network devices

--- Additional comment from Alan Pevec (Fedora) on 2021-09-19 23:04:08 UTC ---

$ licensecheck initscripts-10.11.1
initscripts-10.11.1/.packit.yml: *No copyright* UNKNOWN
initscripts-10.11.1/COPYING: GNU General Public License, Version 2
initscripts-10.11.1/Makefile: *No copyright* UNKNOWN
initscripts-10.11.1/README.md: *No copyright* UNKNOWN
initscripts-10.11.1/debugfiles.list: *No copyright* UNKNOWN
initscripts-10.11.1/debugsourcefiles.list: *No copyright* UNKNOWN
initscripts-10.11.1/debugsources.list: *No copyright* UNKNOWN
initscripts-10.11.1/elfbins.list: *No copyright* UNKNOWN
initscripts-10.11.1/initscripts.lang: *No copyright* UNKNOWN
initscripts-10.11.1/initscripts.spec: *No copyright* UNKNOWN

fedora-review tl;dr report
Issues:
=======
- Package does not contain duplicates in %files.
  Note: warning: File listed twice: /etc/sysconfig/network-scripts/ifcfg-lo
=> the same as in original network-scripts:
%{_sysconfdir}/sysconfig/network-scripts/*

%config(noreplace)    %{_sysconfdir}/sysconfig/network-scripts/ifcfg-lo


- Permissions on files are set properly.
  Note: See rpmlint output
=> the same as in original network-scripts:
network-scripts.x86_64: E: missing-call-to-setgroups-before-setuid /usr/sbin/usernetctl
network-scripts.x86_64: E: setuid-binary /usr/sbin/usernetctl root 4755
network-scripts.x86_64: E: non-standard-executable-perm /usr/sbin/usernetctl 4755

--- Additional comment from Alan Pevec (Fedora) on 2021-09-21 00:10:42 UTC ---

> /me figuring out how to closely track it in RDO Trunk with CS9 distgit as upstream source

I came up with nothing useful yet, but at the moment we could actually grab network-scripts subpackage from CS9 Koji, it is built but then filtered out by the CS9 compose config:

https://kojihub.stream.centos.org/kojifiles/packages/initscripts/10.11.1/1.el9/x86_64/network-scripts-10.11.1-1.el9.x86_64.rpm

--- Additional comment from Alan Pevec (Fedora) on 2021-09-21 01:20:32 UTC ---

> I came up with nothing useful yet

one approach would be to came up with a smaller diff against CS9 initscripts.spec which we would attempt to apply when CS9 is updated.
https://apevec.fedorapeople.org/rdo/openstack-network-scripts.spec takes %install from https://github.com/mwhahaha/openstack-network-scripts-distgit/blob/main/openstack-network-scripts.spec
the rest are mostly removals from the CS9 spec

diff -u https://gitlab.com/redhat/centos-stream/rpms/initscripts/-/blob/c9s/initscripts.spec https://apevec.fedorapeople.org/rdo/openstack-network-scripts.spec

=> https://apevec.fedorapeople.org/rdo/openstack-network-scripts.diff

--- Additional comment from Alan Pevec (Fedora) on 2021-09-21 12:00:54 UTC ---

Reviewing openstack-network-scripts.diff compared to Initial spec:

-Requires:         %{name}%{?_isa} = %{version}-%{release}
+Requires:         %{upstream_name}%{?_isa} = %{version}-%{release}

vs

Requires:         initscripts >= %{version}-%{release}

[?] >= is more flexible since initscripts updates in CS9 will not immediately block installation of openstack-network-scripts,
but might miss incompatible CS9 changes. Not sure which is better, not blocking CI or getting signal that

[x] Binary RPM https://apevec.fedorapeople.org/rdo/openstack-network-scripts-10.11.1-1.el9.x86_64.rpm
installs cleanly on current CS9 production compose

[?] Removed Obsoletes: upgrades of network-scripts cannot happen since it is not in CS9 and if it was grabbed from CS9 Koji, installation is prevented by file conflicts

[?] Provides network-scripts for existing Requires: TODO get rid of that later once RDO packages change to explicit Requires: openstack-network-scripts ?
+Provides:         network-scripts = %{version}-%{release}
-Provides:         deprecated()


[x] %install section could break on initscripts upstream changes, considering this a feature to get FTBFS signal
[x] Removed all docs in the RPM, this should be only for deployment tools and not for general usage

@Alfredo wdyt about [?] points?

--- Additional comment from Alfredo Moralejo on 2021-09-21 13:53:34 UTC ---

My feedback:

(In reply to Alan Pevec (Fedora) from comment #11)
> 
> [?] >= is more flexible since initscripts updates in CS9 will not
> immediately block installation of openstack-network-scripts,
> but might miss incompatible CS9 changes. Not sure which is better, not
> blocking CI or getting signal that
> 

+1 to use >=

> 
> [?] Removed Obsoletes: upgrades of network-scripts cannot happen since it is
> not in CS9 and if it was grabbed from CS9 Koji, installation is prevented by
> file conflicts

Yes, i think we can remove the obsoletes.

> 
> [?] Provides network-scripts for existing Requires: TODO get rid of that
> later once RDO packages change to explicit Requires:
> openstack-network-scripts ?
> +Provides:         network-scripts = %{version}-%{release}
> -Provides:         deprecated()
> 


+1 to provide network-scripts for backwards compatibility.

> 
> 
> @Alfredo wdyt about [?] points?

--- Additional comment from Alan Pevec (Fedora) on 2021-09-22 11:20:01 UTC ---

>= added and pushed final spec to:
https://github.com/rdo-common/openstack-network-scripts

We will import this to git.centos.org and build as RDO dep in CBS Koji.

--- Additional comment from Alan Pevec (Fedora) on 2021-09-22 11:27:51 UTC ---

> > [?] Removed Obsoletes: upgrades of network-scripts cannot happen since it is
> > not in CS9 and if it was grabbed from CS9 Koji, installation is prevented by
> > file conflicts
> 
> Yes, i think we can remove the obsoletes.

I had a look at LEAP and afaict for upgrades 8->9 LEAP removes rhel8 network-scripts

--- Additional comment from Alan Pevec on 2021-10-20 21:46:24 UTC ---

This is now in RDO >=Xena deps for CS9:
https://cbs.centos.org/koji/buildinfo?buildID=35210