Description of problem: The adoption controller failed to adopt an already existing (and appears to already have been adopted) Subscription when generating the adoption metadata.Labels: ``` {"level":"error","ts":1634738113.834287,"logger":"controllers.adoption","msg":"Error adopting Subscription","request":"openshift-special-resource-operator/sro-operator-subscription","error":"Subscription.operators.coreos.com \"sro-operator-subscription\" is invalid: metadata.labels: Invalid value: \"operators.coreos.com/openshift-special-resource-operator.openshift-special-resource-\": name part must consist of alphanumeric characters, '-', '_' or '.', and must start and end with an alphanumeric character (e.g. 'MyName', or 'my.name', or '123-abc', regex used for validation is '([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9]')","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile\n\t/build/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:114\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/build/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:311\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/build/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:266\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/build/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:227"} ``` Link to a CI job that contains more context: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift-kni_cnf-features-deploy/750/pull-ci-openshift-kni-cnf-features-deploy-master-e2e-gcp-ran-profile/1450809562331353088 Version-Release number of selected component (if applicable): 4.9 How reproducible: Unknown Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info:
Upstream pr https://github.com/operator-framework/operator-lifecycle-manager/pull/2430
Seems the upstream PR is stale and open since October. We should just close it and take over.
https://github.com/operator-framework/operator-lifecycle-manager/pull/2731 the new PR
This has merged downstream! It's ready for QA.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (Important: OpenShift Container Platform 4.11.0 bug fix and security update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2022:5069