Bug 2017025 - Review Request: php-psr-container2 - Common Container Interface version 2
Summary: Review Request: php-psr-container2 - Common Container Interface version 2
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: François Kooman
QA Contact: Fedora Extras Quality Assurance
Depends On:
Blocks: 2017032
TreeView+ depends on / blocked
Reported: 2021-10-25 13:07 UTC by Remi Collet
Modified: 2021-12-24 01:23 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2021-12-24 01:23:43 UTC
Type: ---
fkooman: fedora-review+

Attachments (Terms of Use)

Description Remi Collet 2021-10-25 13:07:02 UTC
Spec URL: https://git.remirepo.net/cgit/rpms/php/psr/php-psr-container2.git/plain/php-psr-container2.spec?id=90fb96b9947b8f4446979786881c0a83c3491350
SRPM URL: https://rpms.remirepo.net/SRPMS/php-psr-container2-2.0.1-1.remi.src.rpm
This package holds all interfaces/classes/traits related to PSR-11.

Note that this is not a container implementation of its own.

Autoloader: /usr/share/php/Psr/Container2/autoload.php

Fedora Account System Username: remi


Previous version reviewed as bug #1427017

Comment 3 François Kooman 2021-12-13 20:27:03 UTC
Package: APPROVED.

Package Review

[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

===== MUST items =====

[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "MIT License", "Unknown or generated", "*No copyright* MIT
     License". 5 files have unknown license. Detailed output of
     licensecheck in /home/fedora/2017025-php-psr-
[x]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/share/php/Psr(php-psr-
     cache, php-psr-event-dispatcher, php-psr-container, php-psr-http-
     message, php-psr-link, php-psr-simple-cache, php-PsrLog)
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[-]: Package should compile and build into binary rpms on all supported
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.

[x]: Run phpci static analyze on all php files.
     Note:  Data Source Analysed Directories 1 Files 4 Errors 0 Extensions
     Analysis Extension REF EXT min/Max PHP min/Max core core 5.3.0 7.0.2
     Total [1] 7.0.2 Namespaces Analysis Namespace REF EXT min/Max PHP
     min/Max core 5.3.0 5.3.0 Psr\Container user 7.0.2 Total [2] 7.0.2
     Interfaces Analysis Interface REF EXT min/Max PHP min/Max
     Psr\Container\ContainerExceptionInterface core 7.0.2 7.0.2
     Psr\Container\ContainerInterface user 7.0.0
     Psr\Container\NotFoundExceptionInterface user 5.3.0 Total [3] 7.0.2 No
     trait found Classes Analysis Class REF EXT min/Max PHP min/Max U
     string user 4.0.0 Total [1] 4.0.0 No generator found No function found
     Constants Analysis Constant REF EXT min/Max PHP min/Max __DIR__ core
     5.3.0 5.3.0 Total [1] 5.3.0 No condition found Requires PHP 7.0.2
     (min) Profile results are being logged as JSON format to
     /home/fedora/2017025-php-psr-container2/phpci.log phpCompatInfo
     version 5.5.3 DB version 3.14.0 static analyze results in

Checking: php-psr-container2-2.0.2-1.fc36.noarch.rpm
php-psr-container2.noarch: W: spelling-error %description -l en_US Autoloader -> Auto loader, Auto-loader, Freeloader
php-psr-container2.noarch: W: spelling-error %description -l en_US autoload -> auto load, auto-load, tautology
php-psr-container2.src: W: spelling-error %description -l en_US Autoloader -> Auto loader, Auto-loader, Freeloader
php-psr-container2.src: W: spelling-error %description -l en_US usr -> use, us, user
php-psr-container2.src: W: spelling-error %description -l en_US autoload -> auto load, auto-load, tautology
2 packages and 0 specfiles checked; 0 errors, 5 warnings.

Rpmlint (installed packages)
Cannot parse rpmlint output:

Source checksums
https://github.com/php-fig/container/archive/c71ecc56dfe541dbd90c5360474fbc405f8d5963/php-psr-container2-2.0.2-c71ecc56dfe541dbd90c5360474fbc405f8d5963.tar.gz :
  CHECKSUM(SHA256) this package     : b48165434a391963bd622c20e6c34e3211235ac19818c3908d5f5876432f8bb8
  CHECKSUM(SHA256) upstream package : b48165434a391963bd622c20e6c34e3211235ac19818c3908d5f5876432f8bb8

php-psr-container2 (rpmlib, GLIBC filtered):


Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10
Command line :/usr/bin/fedora-review -b 2017025
Buildroot used: fedora-rawhide-x86_64
Active plugins: PHP, Shell-api, Generic
Disabled plugins: SugarActivity, Java, fonts, Perl, R, Python, Haskell, Ocaml, C/C++

Comment 5 Gwyn Ciesla 2021-12-15 02:05:45 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/php-psr-container2

Comment 6 Fedora Update System 2021-12-15 09:42:25 UTC
FEDORA-2021-83c71af3f4 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-83c71af3f4

Comment 7 Fedora Update System 2021-12-16 02:08:07 UTC
FEDORA-2021-83c71af3f4 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-83c71af3f4 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-83c71af3f4

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2021-12-24 01:23:43 UTC
FEDORA-2021-83c71af3f4 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.

Note You need to log in before you can comment on or make changes to this bug.