Bug 2017171 - Reconsider value of _dwz_max_die_limit
Summary: Reconsider value of _dwz_max_die_limit
Keywords:
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: redhat-rpm-config
Version: 38
Hardware: All
OS: Linux
unspecified
low
Target Milestone: ---
Assignee: Florian Festi
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-10-25 21:27 UTC by Michael Catanzaro
Modified: 2023-02-07 14:52 UTC (History)
16 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Michael Catanzaro 2021-10-25 21:27:21 UTC
Hi, I stumbled across this old blog post from Mark Wielaard: https://gnu.wildebeest.org/blog/mjw/2017/06/30/fedora-rpm-debuginfo-improvements-for-rawhidef27/

It says: "please let us know about packages that need to set debuginfo rpm macros to non-default values because they would crash and burn with the default settings (best to file a bug against rpmbuild)."

So OK, hi. This bug is just a heads-up because the blog post says a bug report would be the best way to get in touch. Feel free to close. Anyway, the webkit2gtk3 package overrides this value because it reportedly results in massive decreases in the size of the generated debuginfo package:

# Increase the DIE limit so our debuginfo packages could be size optimized.
# Decreases the size for x86_64 from ~5G to ~1.1G.
# https://bugzilla.redhat.com/show_bug.cgi?id=1456261
%global _dwz_max_die_limit 250000000
# The _dwz_max_die_limit is being overridden by the arch specific ones from the
# redhat-rpm-config so we need to set the arch specific ones as well - now it
# is only needed for x86_64.
%global _dwz_max_die_limit_x86_64 250000000

Or at least, that was true back in 2017, when bug #1456261 was resolved. So maybe the defaults should be raised? From that bug, I see this warning:

dwz: ./usr/lib64/libwebkit2gtk-4.0.so.37.22.0-2.17.3-2.fc27.x86_64.debug:
Too many DIEs, not optimizing

I have a suspicion that any debuginfo that hits this limit is going to be huge, so we probably don't want the limit to ever be hit for any package? (Does it really make sense to have any limit at all?)

BTW I notice redhat-rpm-config has a separate _dwz_max_die_limit_armv7hl as well, that webkit2gtk3 does not override. I wonder what's happening on that architecture.

Comment 1 Ben Cotton 2022-11-29 17:11:22 UTC
This message is a reminder that Fedora Linux 35 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora Linux 35 on 2022-12-13.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
'version' of '35'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, change the 'version' 
to a later Fedora Linux version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora Linux 35 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora Linux, you are encouraged to change the 'version' to a later version
prior to this bug being closed.

Comment 2 Michael Catanzaro 2022-11-29 18:08:32 UTC
Coincidentally, I discovered earlier today that the compression is no longer as important as it used to be, because the uncompressed debuginfo is waaay smaller than before. See: https://pagure.io/fedora-infrastructure/issue/11000#comment-829833

Comment 3 Ben Cotton 2023-02-07 14:52:30 UTC
This bug appears to have been reported against 'rawhide' during the Fedora Linux 38 development cycle.
Changing version to 38.


Note You need to log in before you can comment on or make changes to this bug.