Bug 2017262 - Datavolume backed by storage not supporting O_DIRECT is not usable
Summary: Datavolume backed by storage not supporting O_DIRECT is not usable
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Container Native Virtualization (CNV)
Classification: Red Hat
Component: Storage
Version: 4.9.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: 4.9.1
Assignee: Alex Kalenyuk
QA Contact: Kevin Alon Goldblatt
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-10-26 07:33 UTC by lpivarc
Modified: 2024-06-30 11:15 UTC (History)
5 users (show)

Fixed In Version: virt-cdi-importer v4.9.1-4, CNV v4.9.1-7
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-12-13 19:59:01 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github kubevirt containerized-data-importer pull 1919 0 None Merged Stop qemu-img writing with cache=none 2021-11-10 14:48:37 UTC
Github kubevirt containerized-data-importer pull 2000 0 None Merged [release-v1.38] Stop qemu-img writing with cache=none 2021-11-10 14:48:38 UTC
Github kubevirt containerized-data-importer pull 2006 0 None Merged [release-v1.38] Stop qemu-img writing with cache=none 2021-11-10 14:48:39 UTC
Red Hat Issue Tracker CNV-14635 0 None None None 2024-05-16 12:58:41 UTC
Red Hat Product Errata RHBA-2021:5091 0 None None None 2021-12-13 19:59:15 UTC

Description lpivarc 2021-10-26 07:33:55 UTC
Description of problem:
Using storage without O_DIRECT is not possible.

E1015 02:30:34.448077       1 prlimit.go:176] qemu-img: Could not open '/data/disk.img': Could not open '/data/disk.img': filesystem does not support O_DIRECT

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Maya Rashish 2021-10-26 14:05:28 UTC
I suspect that the change in https://github.com/kubevirt/containerized-data-importer/pull/1919 avoids this problem.

Comment 2 Alex Kalenyuk 2021-10-27 12:30:37 UTC
(In reply to Maya Rashish from comment #1)
> I suspect that the change in
> https://github.com/kubevirt/containerized-data-importer/pull/1919 avoids
> this problem.

I would also expect that it does,
We switched to writeback which "causes qemu-kvm to interact with the disk image file or block device with neither O_DSYNC nor O_DIRECT semantics":
https://documentation.suse.com/sles/11-SP4/html/SLES-kvm4zseries/cha-qemu-cachemodes.html#id-1.10.6.6.5

Comment 3 Adam Litke 2021-10-27 17:40:53 UTC
Alex, the bug is targeted to 4.9 (should be 4.9.1) so we can't mark this as ON_QA yet.  I am requesting a cherry-pick which I will attach here.  Until then, moving back to ASSIGNED.

Comment 4 Alex Kalenyuk 2021-10-28 09:15:52 UTC
(In reply to Adam Litke from comment #3)
> Alex, the bug is targeted to 4.9 (should be 4.9.1) so we can't mark this as
> ON_QA yet.  I am requesting a cherry-pick which I will attach here.  Until
> then, moving back to ASSIGNED.

My bad didn't notice the target is 4.9.
Are we sure we want this backported to 4.9? I opened a discussion on the PR:
https://github.com/kubevirt/containerized-data-importer/pull/2000#issuecomment-953659957

It's already merged btw, so could be making its way to 4.9.0 builds, are we ok with that?
(don't want 4.9.0 release candidates containing this by accident)

Comment 6 Maya Rashish 2021-11-03 11:36:59 UTC
Change was reverted since it was accidentally merged in 4.9.0.

Comment 9 Kevin Alon Goldblatt 2021-11-15 17:01:31 UTC
@lpivarc Can you provide us with a scenario to verify this bug?

Comment 11 Kevin Alon Goldblatt 2021-11-17 11:18:57 UTC
Verified with the following code:
---------------------------------------
oc version
Client Version: 4.10.0-202110050529.p0.git.8857282.assembly.stream-8857282
Server Version: 4.9.7
Kubernetes Version: v1.22.2+5e38c72
[cnv-qe-jenkins@dalia491-kgwgb-executor kev]$ oc get csv -n openshift-cnv
NAME                                      DISPLAY                    VERSION   REPLACES                                  PHASE
kubevirt-hyperconverged-operator.v4.9.1   OpenShift Virtualization   4.9.1     kubevirt-hyperconverged-operator.v4.9.0   Succeeded


Verified with the following scenario:
--------------------------------------
. Ran the test below successfully:
[Serial][rfe_id:393][crit:high][vendor:cnv-qe][level:system][sig-compute] VM Live Migration Starting a VirtualMachineInstance  with an Alpine DataVolume 
  [test_id:3239]should reject a migration of a vmi with a non-shared data volume


Moving to VERIFIED!

Comment 17 errata-xmlrpc 2021-12-13 19:59:01 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Virtualization 4.9.1 Images), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:5091


Note You need to log in before you can comment on or make changes to this bug.