Bug 2017719 - Review Request: perl-Syntax-Keyword-Match - Match/case syntax for Perl
Summary: Review Request: perl-Syntax-Keyword-Match - Match/case syntax for Perl
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2017689 2017700
Blocks: 2017498
TreeView+ depends on / blocked
 
Reported: 2021-10-27 10:49 UTC by Petr Pisar
Modified: 2022-03-02 12:18 UTC (History)
2 users (show)

Fixed In Version: perl-Syntax-Keyword-Match-0.08-1.fc36
Clone Of:
Environment:
Last Closed: 2022-03-02 12:18:40 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2021-10-27 10:49:17 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-Syntax-Keyword-Match/perl-Syntax-Keyword-Match.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Syntax-Keyword-Match/perl-Syntax-Keyword-Match-0.08-1.fc36.src.rpm
Description:
This module provides a syntax plugin that implements a control-flow block
called match/case, which executes at most one of a choice of different
blocks depending on the value of its controlling expression.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2021-11-12 11:26:30 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Syntax-Keyword-Match-0.08-1.fc36.x86_64.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(Carp)
      1 perl(:MODULE_COMPAT_5.34.0)
      1 perl(:VERSION) >= 5.14.0
      1 perl(warnings)
      1 perl(XSLoader) 
      1 perl(XS::Parse::Infix) >= 0
      1 perl(:XS_Parse_Infix_ABI_1)
      1 perl(XS::Parse::Keyword) >= 0.14
      1 perl(:XS_Parse_Keyword_ABI_2)
      1 rtld(GNU_HASH)
Binary requires are Ok.

$ rpm -qp --provides perl-Syntax-Keyword-Match-0.08-1.fc36.x86_64.rpm | sort | uniq -c
      1 perl(Syntax::Keyword::Match) = 0.08
      1 perl-Syntax-Keyword-Match = 0.08-1.fc36
      1 perl-Syntax-Keyword-Match(x86-64) = 0.08-1.fc36
Binary provides are Ok.

$ rpmlint ./perl-Syntax-Keyword-Match*
perl-Syntax-Keyword-Match.x86_64: E: shared-lib-without-dependency-information /usr/lib64/perl5/vendor_perl/auto/Syntax/Keyword/Match/Match.so
perl-Syntax-Keyword-Match-tests.noarch: W: no-documentation
3 packages and 1 specfiles checked; 1 errors, 1 warnings.
Rpmlint is ok

The package is in line with Fedora and Perl packaging guide lines.

Resolution:
Approved

Comment 3 Gwyn Ciesla 2021-11-12 14:22:07 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Syntax-Keyword-Match

Comment 4 Petr Pisar 2021-11-12 15:17:23 UTC
Thank you for the review and the repository.

Comment 5 Fedora Update System 2021-11-12 16:00:23 UTC
FEDORA-2021-0b700e2eed has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 6 Fedora Update System 2021-11-15 10:00:31 UTC
FEDORA-2021-74eca266f4 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-74eca266f4

Comment 7 Fedora Update System 2021-11-16 15:52:00 UTC
FEDORA-2021-74eca266f4 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-74eca266f4`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-74eca266f4

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2021-11-26 01:21:33 UTC
FEDORA-2021-74eca266f4 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.