Bug 2018159 - [4.10.z] must-gather fails to collect performance-specific data when more than --image argument is supplied
Summary: [4.10.z] must-gather fails to collect performance-specific data when more tha...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Performance Addon Operator
Version: 4.10
Hardware: Unspecified
OS: Unspecified
high
medium
Target Milestone: ---
: 4.10.z
Assignee: Martin Sivák
QA Contact: Gowrishankar Rajaiyan
Tony Mulqueen
URL:
Whiteboard:
: 2107492 (view as bug list)
Depends On:
Blocks: 2018185
TreeView+ depends on / blocked
 
Reported: 2021-10-28 11:46 UTC by Francesco Romani
Modified: 2022-08-22 09:42 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Cause: More than one --image argument is supplied to must-gather Consequence: must-gather does not collect node related logs Fix: Use HOSTNAME environment variable to get the must-gather pod name instead of getting it from a client Result: must-gather succeeds to collect performance-addon-operator related data also when called with additional --image arguments
Clone Of:
Environment:
Last Closed: 2022-03-10 19:34:25 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift-kni performance-addon-operators pull 768 0 None open must-gather: fix run when using two images 2021-10-28 11:47:06 UTC
Red Hat Product Errata RHEA-2022:0640 0 None None None 2022-03-10 19:34:50 UTC

Description Francesco Romani 2021-10-28 11:46:40 UTC
Description of problem:
When running `must-gather` with the performance-operator addon, the tool fails to collect some data. The performance-operator addon needs to introspect the must-gather pod, and the detection logic fails if more than image is used.


Version-Release number of selected component (if applicable):
4.10 - 4.8 at least, possibly also 4.7 and 4.6

How reproducible:
100%


Steps to Reproduce:
1. run  oc adm must-gather --image-stream=openshift/must-gather --image=registry.redhat.io/openshift4/performance-addon-operator-must-gather-rhel8:$VERSION
2. wait for the tool to complete
3. inspect the collected output

Actual results:
Some files, at least `lspci` `lscpu`, but possibly all of the performance-related files, are missing


Expected results:
Performance-relared data is collected, or at least a clear error is reported. The tool does neither because of the bug.

Additional info:

Master PR: https://github.com/openshift-kni/performance-addon-operators/pull/768

4.9 PR: https://github.com/openshift-kni/performance-addon-operators/pull/769

oc 4.9              Bug reproducible, Fix working
oc 4.8 PAO  4.8.2-6 Bug reproducible, Fix working
oc 4.7 PAO  4.7.6-3 Bug reproducible, Fix working
oc 4.6 PAO  4.6.5-3 Bug reproducible, Fix working

Comment 3 Shereen Haj Makhoul 2021-12-01 15:32:50 UTC
Verification
++++++++++++

Image used:
registry-proxy.engineering.redhat.com/rh-osbs/openshift4-performance-addon-operator-must-gather-rhel8:v4.10.0-16

 oc adm must-gather --image-stream=openshift/must-gather --image=registry-proxy.engineering.redhat.com/rh-osbs/openshift4-performance-addon-operator-must-gather-rhel8:v4.10.0-16

Inside the must gather generated directory check if all performance-related files are there:
on worker-0:
cpu_affinities.json  irq_affinities.json  lscpu  lspci  ocp49-worker-0.demo.lab.mniranja_logs_kubelet.gz  podresources.json  proc_cmdline  sysinfo.log  sysinfo.tgz

On worker-1:
cpu_affinities.json  irq_affinities.json  lscpu  lspci  ocp49-worker-1.demo.lab.mniranja_logs_kubelet.gz  podresources.json  proc_cmdline  sysinfo.log  sysinfo.tgz

From the above output, all expected files were found. Moving the BZ to verified.

Comment 6 errata-xmlrpc 2022-03-10 19:34:25 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.10 low-latency extras update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2022:0640

Comment 7 Jose Luis 2022-08-16 09:23:37 UTC
*** Bug 2107492 has been marked as a duplicate of this bug. ***


Note You need to log in before you can comment on or make changes to this bug.