Bug 2018443

Oh, it seems the test is not smart enough to distinguish the pre-rewrite and post-rewrite resources.

@dgonyier @artyom Folks, can you please check this bug? I believe PAO is configured properly and it is the workload partitioning logic who creates the limits here. It seems our tests are not ready for that.

It is not about the PAO, it is about the workload logic, for custom resources you should set both limits and requests, it is the reason why the management logic is doing it. You can check others OpenShift pods under the environment and you will see the same picture.

The important things it does not change the QoS class of the pod.

I saw this behavior in https://bugzilla.redhat.com/show_bug.cgi?id=2019924 as well, but there was no mention there of whether the PAO limits and requests shown with WP enabled are correct.

@alukiano is the output from the BZ description here always the case for PAO on SNO with WP?

> oc -n openshift-performance-addon-operator get pods performance-operator-8699594d45-2rmkc -o json | jq .spec.containers[0].resources
> {
>   "limits": {
>     "management.workload.openshift.io/cores": "10"
>   },
>   "requests": {
>     "management.workload.openshift.io/cores": "10",
>     "memory": "25Mi"
>   }
> }

Yes, it always will be true for every burstable pod with the workload annotation(the same true also for non SNO environments)

Fixed in PR https://github.com/openshift-kni/performance-addon-operators/pull/793

@mcornea can you verify?

Btw, it might be necessary to update cnf-feature-deploy repository and vendor in the new content.

(In reply to Dwaine Gonyier from comment #7)
> Fixed in PR
> https://github.com/openshift-kni/performance-addon-operators/pull/793
> 
> @mcornea can you verify?

I re-tested on the latest downstream cnf-tests image: registry-proxy.engineering.redhat.com/rh-osbs/openshift4-cnf-tests:v4.10.0-60 and the same error showed up:

[rfe_id:27368][performance]
/remote-source/app/vendor/github.com/openshift-kni/performance-addon-operators/functests/1_performance/performance.go:56
  Performance Operator
  /remote-source/app/vendor/github.com/openshift-kni/performance-addon-operators/functests/1_performance/performance.go:83
    [test_id:44885] Should have CPU and Memory requests but not limits - BZ 1957291 [It]
    /remote-source/app/vendor/github.com/openshift-kni/performance-addon-operators/functests/1_performance/performance.go:101

    Container has CPU Request <= 0
    Expected
        <bool>: false
    to be true

    /remote-source/app/vendor/github.com/openshift-kni/performance-addon-operators/functests/1_performance/performance.go:112


Could you please check if the fix ended in the image?

verification:

version:
ocp: 4.10.0-rc.3
pao: performance-addon-operator-container-v4.10.0-32

Random Seed: 1645613544
Will run 1 of 195 specs

SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS
------------------------------
[rfe_id:27368][performance] Performance Operator 
  [test_id:44885] Should have CPU and Memory requests but not limits - BZ 1957291
  /remote-source/app/vendor/github.com/openshift-kni/performance-addon-operators/functests/1_performance/performance.go:101
STEP: Checking Resource.Limits.Memory()
STEP: Workload Partitioning enabled, checking custom resource Resources.Requests["management.workload.openshift.io/cores"]
STEP: Checking Resources.Requests.Memory()
•SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS
JUnit report was created: /junit.xml/cnftests-junit.xml

Ran 1 of 195 Specs in 131.576 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 194 Skipped

Verified.

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.10 low-latency extras update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2022:0640