Bug 2018615 - %py3_check_import does nothing and succeeds when %py3_shebang_flags is %nil
Summary: %py3_check_import does nothing and succeeds when %py3_shebang_flags is %nil
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: python-rpm-macros
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Karolina Surma
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-10-29 23:22 UTC by Miro Hrončok
Modified: 2021-11-03 11:11 UTC (History)
7 users (show)

Fixed In Version: python-rpm-macros-3.10-13.fc36
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-11-03 11:11:48 UTC
Type: Bug


Attachments (Terms of Use)

Description Miro Hrončok 2021-10-29 23:22:36 UTC
Description of problem:
When %py3_shebang_flags is %nil, %py3_check_import evals to:

...
/usr/bin/python3 - /usr/lib/rpm/redhat/import_all_modules.py
...

And hence it executes no code.

When %py3_shebang_flags is undefined, %py3_check_import evals to:

...
/usr/bin/python3 -%{py3_shebang_flags} /usr/lib/rpm/redhat/import_all_modules.py
...

And hence fails.

The -%{py3_shebang_flags} flag should be conditionalized on %{?py3_shebang_flags} non-emptines. %py3_shebang_fix already does something like that.

Version-Release number of selected component (if applicable): 
python-rpm-macros-3.9-19.fc33
python-rpm-macros-3.9-40.fc34
python-rpm-macros-3.10-9.fc35
python-rpm-macros-3.10-12.fc36

Comment 2 Fedora Update System 2021-11-03 11:10:06 UTC
FEDORA-2021-70e7a5dae0 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2021-70e7a5dae0

Comment 3 Fedora Update System 2021-11-03 11:11:48 UTC
FEDORA-2021-70e7a5dae0 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.