Bug 2018796 - I/O operations/sec reporting wrong values
Summary: I/O operations/sec reporting wrong values
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: RestAPI
Version: 4.5.0.8
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ovirt-4.5.2
: ---
Assignee: Artiom Divak
QA Contact: Avihai
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-10-31 10:06 UTC by Aviv Litman
Modified: 2022-08-30 08:49 UTC (History)
8 users (show)

Fixed In Version: ovirt-engine-4.5.2.1
Clone Of: 2010903
Environment:
Last Closed: 2022-08-08 08:17:16 UTC
oVirt Team: Storage
Embargoed:
pm-rhel: ovirt-4.5?
pm-rhel: devel_ack+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker RHV-43888 0 None None None 2021-10-31 10:07:32 UTC

Description Aviv Litman 2021-10-31 10:06:51 UTC
+++ This bug was initially created as a clone of Bug #2010903 +++

read_ops and write_ops defined incorrectly when added to db in this patch: https://gerrit.ovirt.org/#/c/ovirt-engine/+/111377/|, and changed type in this patch: https://gerrit.ovirt.org/#/c/ovirt-engine/+/113494/
the right definition is Read/Write operations since VM start and not per second.

Here are probably changes which should be done:

1. Change StatisticKind to COUNTER and StatisticUnit to NONE
https://github.com/oVirt/ovirt-engine/blob/master/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/DiskStatisticalQuery.java#L17
https://github.com/oVirt/ovirt-engine/blob/master/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/DiskStatisticalQuery.java#L19

2. read_ops and write_ops values in database should be probably changed to DECIMAL(21) to be able to store unsigned int 64 values, which can come from VDSM

3. read_ops and write_ops properties in Java should be changed to BigInteger to accommodate above db changes

4. DWH db needs to be update according to engine db changes: this fix will be documented in dwh bug 2010903.

Is it all or we missing something?

Comment 5 Michal Skrivanek 2022-04-11 08:52:42 UTC
still relevant?

Comment 8 Arik 2022-05-24 13:02:43 UTC
(In reply to Aviv Litman from comment #0)
> +++ This bug was initially created as a clone of Bug #2010903 +++
> 
> read_ops and write_ops defined incorrectly when added to db in this patch:
> https://gerrit.ovirt.org/#/c/ovirt-engine/+/111377/|, and changed type in
> this patch: https://gerrit.ovirt.org/#/c/ovirt-engine/+/113494/
> the right definition is Read/Write operations since VM start and not per
> second.
> 
> Here are probably changes which should be done:
> 
> 1. Change StatisticKind to COUNTER and StatisticUnit to NONE
> https://github.com/oVirt/ovirt-engine/blob/master/backend/manager/modules/
> restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/
> DiskStatisticalQuery.java#L17
> https://github.com/oVirt/ovirt-engine/blob/master/backend/manager/modules/
> restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/
> DiskStatisticalQuery.java#L19

This is the only part that remained after the fix for bz 1928188

Comment 10 Sandro Bonazzola 2022-08-30 08:49:07 UTC
This bugzilla is included in oVirt 4.5.2 release, published on August 10th 2022.
Since the problem described in this bug report should be resolved in oVirt 4.5.2 release, it has been closed with a resolution of CURRENT RELEASE.
If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.