Bug 2020307 - Review Request: tokodon - Kirigami-based mastodon client
Summary: Review Request: tokodon - Kirigami-based mastodon client
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Justin Zobel
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-11-04 14:51 UTC by Onuralp SEZER
Modified: 2023-02-06 07:40 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-02-06 07:40:32 UTC
Type: ---
Embargoed:
justin.zobel: fedora-review+


Attachments (Terms of Use)

Description Onuralp SEZER 2021-11-04 14:51:49 UTC
https://pagure.io/Tokodon_rpm/blob/main/f/tokodon.spec
https://pagure.io/Tokodon_rpm/blob/main/f/tokodon-21.08-1.fc35.src.rpm
Description: Tokodon is a Mastodon client for Plasma and Plasma Mobile.

Pagure URL : https://pagure.io/Tokodon_rpm/tree/main

Fedora Account System Username: thunderbirdtr

Comment 1 Ankur Sinha (FranciscoD) 2021-11-04 15:31:18 UTC
Updating URLs to use the raw URL from pagure for fedora-review:

Spec: https://pagure.io/Tokodon_rpm/raw/main/f/Tokodon.spec
SRPM: https://pagure.io/Tokodon_rpm/raw/main/f/tokodon-21.08-1.fc35.src.rpm

Comment 2 Onuralp SEZER 2021-11-04 15:38:51 UTC
Updated URL 

Spec: https://pagure.io/Tokodon_rpm/raw/main/f/tokodon.spec

Comment 3 Arthur Bols 2022-01-14 21:46:11 UTC
- Please update to 21.12
Don't forget to also update the srpm.

Comment 4 Justin Zobel 2022-01-15 00:13:16 UTC
Have created a PR on Onuralp's repo for 21.12, rebuild srpm and add app icon that is installed.

Comment 5 Onuralp Sezer 2022-01-15 09:24:48 UTC
(In reply to Arthur Bols from comment #3)
> - Please update to 21.12
> Don't forget to also update the srpm.

New Spec : https://pagure.io/Tokodon_rpm/blob/main/f/tokodon.spec
New SRPM : https://pagure.io/Tokodon_rpm/blob/main/f/tokodon-21.12-1.fc35.src.rpm

Comment 6 Arthur Bols 2022-01-17 16:25:15 UTC
- The spec file url should point to the raw file, can you fix that please?
- Mock build failed:

> CMake Error at CMakeLists.txt:52 (find_package):
>   By not providing "FindKF5QQC2DesktopStyle.cmake" in CMAKE_MODULE_PATH this
>   project has asked CMake to find a package configuration file provided by
>   "KF5QQC2DesktopStyle", but CMake did not find one.
>   Could not find a package configuration file provided by
>   "KF5QQC2DesktopStyle" with any of the following names:
>     KF5QQC2DesktopStyleConfig.cmake
>     kf5qqc2desktopstyle-config.cmake
>   Add the installation prefix of "KF5QQC2DesktopStyle" to CMAKE_PREFIX_PATH
>   or set "KF5QQC2DesktopStyle_DIR" to a directory containing one of the above
>   files.  If "KF5QQC2DesktopStyle" provides a separate development package or
>   SDK, be sure it has been installed.

Comment 7 Onuralp SEZER 2022-01-17 19:28:45 UTC
BR : KF5QQC2DesktopStyle added.

SPEC File : https://pagure.io/Tokodon_rpm/raw/main/f/tokodon.spec
SRPM File : https://pagure.io/Tokodon_rpm/raw/main/f/tokodon-21.12-1.fc35.src.rpm

Comment 8 Arthur Bols 2022-01-22 09:40:44 UTC
Again a licensing issue. :/

I'm in a hurry so here's a quick rundown of issues, but overall it looks quite good.
- Add a license breakdown
- Report the missing licenses upstream
- Add the README.md with %doc

> sed -i 's/SocialMedia/X-SocialMedia/g' %{buildroot}%{_kf5_datadir}/applications/org.kde.%{name}.desktop

You have a commit upstream to fix it. Please add it as a comment so you won't forget to remove it in the future.
A patch would be better. I'm fine with it in this case, since it should be gone in the next release.

> %license LICENSES/*.txt

You can remove the .txt to match all files. This would be useful if they add a license file without extension.

Comment 9 Onuralp SEZER 2022-01-22 14:23:30 UTC
(In reply to Arthur Bols from comment #8)
> Again a licensing issue. :/
> 
> I'm in a hurry so here's a quick rundown of issues, but overall it looks
> quite good.
> - Add a license breakdown
> - Report the missing licenses upstream
> - Add the README.md with %doc
> 
> > sed -i 's/SocialMedia/X-SocialMedia/g' %{buildroot}%{_kf5_datadir}/applications/org.kde.%{name}.desktop
> 
> You have a commit upstream to fix it. Please add it as a comment so you
> won't forget to remove it in the future.
> A patch would be better. I'm fine with it in this case, since it should be
> gone in the next release.
> 
> > %license LICENSES/*.txt
> 
> You can remove the .txt to match all files. This would be useful if they add
> a license file without extension.

All done and that "sed" fix already merged as well (https://invent.kde.org/network/tokodon/-/merge_requests/21)  we just gonna wait next version and gonna remove that as well.

Comment 10 Onuralp SEZER 2022-01-22 14:25:48 UTC
I should check licenses more carefully but we would like to push all the plasma-mobile related packages a bit quickly and then "polish" it afterwards (License sections and be fix easily as well yet again it I should be more careful and check a bit more details about it)

Also thank you for reviews

Comment 11 Justin Zobel 2022-04-15 13:05:56 UTC
- Update to the latest version (fixes the desktop file issue so that sed can be removed)

- Add licenses:
https://invent.kde.org/network/tokodon/-/blob/master/src/content/ui/Settings/AccountsPage.qml is licensed under GPLv2+
https://invent.kde.org/network/tokodon/-/blob/master/src/content/ui/Settings/SonnetConfigPage.qml is licensed under LGPL-2.1-or-later
https://invent.kde.org/network/tokodon/-/blob/master/src/content/ui/Settings/SettingsPage.qml is licensed under LGPL-2.0-or-later

Comment 13 Justin Zobel 2022-04-16 01:26:00 UTC
- Licenses have been included in the package but not mentioned in the spec License field.

- See https://invent.kde.org/network/tokodon/-/tree/master/LICENSES for the ones you might be missing or below for full licensecheck.txt

- Fix up that and we should be good to go!


*No copyright* Creative Commons Attribution 4.0
-----------------------------------------------
tokodon-22.02/README.md

*No copyright* Creative Commons CC0 1.0
---------------------------------------
tokodon-22.02/.gitlab-ci.yml
tokodon-22.02/.kde-ci.yml
tokodon-22.02/LICENSES/CC0-1.0.txt
tokodon-22.02/android/AndroidManifest.xml
tokodon-22.02/org.kde.tokodon.appdata.xml
tokodon-22.02/org.kde.tokodon.desktop
tokodon-22.02/src/Messages.sh

*No copyright* GNU General Public License, Version 2
----------------------------------------------------
tokodon-22.02/src/content/ui/Settings/AccountsPage.qml

*No copyright* GNU General Public License, Version 3
----------------------------------------------------
tokodon-22.02/src/account.cpp
tokodon-22.02/src/account.h
tokodon-22.02/src/accountmanager.cpp
tokodon-22.02/src/accountmanager.h
tokodon-22.02/src/accountmodel.cpp
tokodon-22.02/src/accountmodel.h
tokodon-22.02/src/attachmenteditormodel.cpp
tokodon-22.02/src/attachmenteditormodel.h
tokodon-22.02/src/clipboard.cpp
tokodon-22.02/src/clipboard.h
tokodon-22.02/src/content/ui/AccountInfo.qml
tokodon-22.02/src/content/ui/AuthorizationPage.qml
tokodon-22.02/src/content/ui/FullScreenImage.qml
tokodon-22.02/src/content/ui/LoginPage.qml
tokodon-22.02/src/content/ui/MastoPage.qml
tokodon-22.02/src/content/ui/TimelinePage.qml
tokodon-22.02/src/content/ui/TootComposer.qml
tokodon-22.02/src/content/ui/main.qml
tokodon-22.02/src/main.cpp
tokodon-22.02/src/notificationmodel.cpp
tokodon-22.02/src/notificationmodel.h
tokodon-22.02/src/post.cpp
tokodon-22.02/src/post.h
tokodon-22.02/src/threadmodel.cpp
tokodon-22.02/src/threadmodel.h
tokodon-22.02/src/timelinemodel.cpp
tokodon-22.02/src/timelinemodel.h

*No copyright* GNU Lesser General Public License, Version 2.1
-------------------------------------------------------------
tokodon-22.02/src/config.kcfgc
tokodon-22.02/src/content/ui/Settings/GeneralPage.qml
tokodon-22.02/src/content/ui/Settings/SonnetConfigPage.qml

*No copyright* GNU Library General Public License, Version 2.0
--------------------------------------------------------------
tokodon-22.02/src/content/ui/Settings/SettingsPage.qml

Unknown or generated
--------------------
tokodon-22.02/CMakeLists.txt
tokodon-22.02/LICENSES/GPL-3.0-only.txt
tokodon-22.02/org.kde.tokodon.svg
tokodon-22.02/po/ca/tokodon.po
tokodon-22.02/po/ca@valencia/tokodon.po
tokodon-22.02/po/cs/tokodon.po
tokodon-22.02/po/de/tokodon.po
tokodon-22.02/po/en_GB/tokodon.po
tokodon-22.02/po/es/tokodon.po
tokodon-22.02/po/fi/tokodon.po
tokodon-22.02/po/fr/tokodon.po
tokodon-22.02/po/hu/tokodon.po
tokodon-22.02/po/it/tokodon.po
tokodon-22.02/po/ko/tokodon.po
tokodon-22.02/po/nl/tokodon.po
tokodon-22.02/po/pl/tokodon.po
tokodon-22.02/po/pt/tokodon.po
tokodon-22.02/po/pt_BR/tokodon.po
tokodon-22.02/po/sk/tokodon.po
tokodon-22.02/po/sl/tokodon.po
tokodon-22.02/po/sv/tokodon.po
tokodon-22.02/po/uk/tokodon.po
tokodon-22.02/po/zh_CN/tokodon.po
tokodon-22.02/src/CMakeLists.txt
tokodon-22.02/src/config.kcfg
tokodon-22.02/src/content/elephant.svg
tokodon-22.02/src/content/icon/boost-post-done.svg
tokodon-22.02/src/content/icon/boost-post.svg
tokodon-22.02/src/content/icon/like-post-done.svg
tokodon-22.02/src/content/icon/like-post.svg
tokodon-22.02/src/resources.qrc

Comment 14 Justin Zobel 2022-04-16 02:14:19 UTC
Approved.

Comment 16 Gwyn Ciesla 2022-04-18 15:19:49 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/tokodon


Note You need to log in before you can comment on or make changes to this bug.