Spec URL: https://pagure.io/plasma-dialer/raw/main/f/plasma-dialer.spec SRPM URL: https://pagure.io/plasma-dialer/raw/main/f/plasma-dialer-21.08-1.fc35.src.rpm Description: Convergent Plasma Mobile dialer application Fedora Account System Username: thunderbirdtr Pagure URL : https://pagure.io/plasma-dialer/
Onuralp, you should really update this to new gear 21.12 version before review, as the change from ofono to ModemManager would most likely require a new review again.
(In reply to Allan from comment #1) > Onuralp, you should really update this to new gear 21.12 version before > review, as the change from ofono to ModemManager would most likely require a > new review again. I'll update it. thank you.
(In reply to Allan from comment #1) > Onuralp, you should really update this to new gear 21.12 version before > review, as the change from ofono to ModemManager would most likely require a > new review again. All done and new SRPM https://pagure.io/plasma-dialer/blob/main/f/plasma-dialer-21.12-2.fc35.src.rpm
Reviewing this.
Update to latest version and remember to rebuild SRPM as the spec in and out differ. Find out from upstream if this should be in main or devel package as it's currently in main and unversioned: /usr/lib64/qt5/qml/org/kde/telephony/libKTelephonyPluginDeclarative.so Devel package contains static libraries, find out from upstream if they are needed and if so, place in a -static subpackage.
I am not sure about .so file status but I updated the version and rest of them should be fine. Spec URL: https://pagure.io/plasma-dialer/raw/main/f/plasma-dialer.spec SRPM URL: https://pagure.io/plasma-dialer/raw/main/f/plasma-dialer-22.06-1.fc36.src.rpm
There are three things that need fixing and I'll pass it. 1 - License - You don't have the license files, and there are more licenses than just 1 2 - Static binary - It's ok where it is, but you need to put a Provides: in the devel section. 3 - Missing dir's - There are two directories that this package should own. %{_kf5_qmldir}/org/kde/telephony %{_includedir}/KF5/kTelephonyMetaTypes Here is a spec file diff that shows what would be a great fix for all three. --- plasma-dialer.spec 2022-08-30 23:08:56.000000000 -0700 +++ plasma-dialer.fixed.spec 2022-09-01 11:04:20.415899256 -0700 @@ -3,7 +3,7 @@ Name: plasma-dialer Version: 22.06 Release: 1%{?dist} -License: GPLv3 +License: BSD and CC0 and GPLv2 and GPLv2+ and GPLv3 and GPLv3+ and LGPLv2+ and LGPLv2.1 and LGPLv2.1+ and LGPLv3 and LGPLv3 Summary: Convergent Plasma Mobile dialer application Url: https://invent.kde.org/plasma-mobile/plasma-dialer Source0: https://download.kde.org/stable/plasma-mobile/%{version}/%{name}-%{version}.tar.xz @@ -68,6 +68,7 @@ %description devel The %{name}-devel package contains libraries and header files for developing applications that use %{name}. +Provides: %{name}-static = %{version}-%{release} %prep %autosetup -n plasma-dialer-%{version} @@ -86,6 +87,7 @@ %files -f %{name}.lang +%license LICENSES/* %{_kf5_bindir}/plasmaphonedialer %{_kf5_metainfodir}/%{kde_name}.appdata.xml @@ -98,13 +100,12 @@ %{_kf5_datadir}/dbus-1/interfaces/org.kde.telephony.* %{_kf5_datadir}/dbus-1/services/org.kde.telephony.service %{_kf5_datadir}/dbus-1/services/org.kde.modemdaemon.service -%{_kf5_qmldir}/org/kde/telephony/libKTelephonyPluginDeclarative.so -%{_kf5_qmldir}/org/kde/telephony/qmldir +%{_kf5_qmldir}/org/kde/telephony %{_libexecdir}/kde-telephony-daemon %{_libexecdir}/modem-daemon %files devel -%{_includedir}/KF5/kTelephonyMetaTypes/dialer-types.h +%{_includedir}/KF5/kTelephonyMetaTypes %{_kf5_libdir}/libktelephonymetatypes.a
All done Spec URL: https://pagure.io/plasma-dialer/raw/main/f/plasma-dialer.spec SRPM URL: https://pagure.io/plasma-dialer/raw/main/f/plasma-dialer-22.06-1.fc36.src.rpm SRPM URL: https://pagure.io/plasma-dialer/raw/main/f/plasma-dialer-22.06-1.fc37.src.rpm
Looks great. Thank you for the changes. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. MANUAL: Static executables are in -devel [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. MANUAL: Verified .so files are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* BSD 3-Clause License", "*No copyright* Creative Commons CC0 1.0", "GNU General Public License, Version 2", "GNU Library General Public License, Version 2.0", "GNU Lesser General Public License, Version 2.1", "GNU Lesser General Public License, Version 3", "*No copyright* GNU General Public License, Version 3", "*No copyright* GNU Lesser General Public License, Version 3", "*No copyright* GNU Lesser General Public License, Version 2.1", "*No copyright* GNU General Public License, Version 2", "*No copyright* GNU General Public License GNU Library General Public License, Version 2.0", "*No copyright* GNU Library General Public License, Version 2.0". 152 files have unknown license. Detailed output of licensecheck in /home/quake/review/2021032-plasma- dialer/licensecheck.txt MANUALLY CHECKED: PASSED [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
Thank you. https://pagure.io/releng/fedora-scm-requests/issue/47773 https://pagure.io/releng/fedora-scm-requests/issue/47774 https://pagure.io/releng/fedora-scm-requests/issue/47775 https://pagure.io/releng/fedora-scm-requests/issue/47776 Requests are made.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/plasma-dialer
https://bodhi.fedoraproject.org/updates/FEDORA-2022-e067e176c0 https://bodhi.fedoraproject.org/updates/FEDORA-2022-1ea72e9c8a https://bodhi.fedoraproject.org/updates/FEDORA-2022-586a3ee676 Packages are built.
Package is now in repositories, closing review.