Bug 2021693 - Modals assigned modal-lg class are no longer the correct width
Summary: Modals assigned modal-lg class are no longer the correct width
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Management Console
Version: 4.10
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
: 4.10.0
Assignee: Steve Goodwin
QA Contact: Yanping Zhang
URL:
Whiteboard:
Depends On:
Blocks: 2022462
TreeView+ depends on / blocked
 
Reported: 2021-11-09 23:34 UTC by Steve Goodwin
Modified: 2022-03-10 16:26 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-03-10 16:26:15 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
Edit tolerations modal should be 1120px width (239.45 KB, image/png)
2021-11-09 23:46 UTC, Steve Goodwin
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Github openshift console pull 10422 0 None open Bug 2021693: Set large width for modals with modal-lg class 2021-11-09 23:55:44 UTC
Red Hat Product Errata RHSA-2022:0056 0 None None None 2022-03-10 16:26:37 UTC

Description Steve Goodwin 2021-11-09 23:34:54 UTC
Modals assigned 'modal-lg' class should be given a wider max-width than default modals.

Effected modals
Edit Taints, Edit Tolerances, Pipeline start, Pipeline trigger, Kubevirt VM resource


Actual results:
Modals with 'modal-lg' class get the default max-width of 600px.

Expected results:
Modals with 'modal-lg' class get a max-width of 70rem (1120px) when browser is greater than 1200px.

Additional info:
This bug was introduced with the removal of the Bootstrap dependency.

Comment 1 Steve Goodwin 2021-11-09 23:46:24 UTC
Created attachment 1840970 [details]
Edit tolerations modal should be 1120px width

Comment 4 Yanping Zhang 2021-11-16 03:41:04 UTC
Checked on ocp 4.10 cluster with payload 4.10.0-0.nightly-2021-11-15-034648. Checked tolerations/taints Modals with 'modal-lg' class get a max-width of 70rem (1120px) when browser is greater than 1200px.

Comment 8 errata-xmlrpc 2022-03-10 16:26:15 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.10.3 security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:0056


Note You need to log in before you can comment on or make changes to this bug.