Red Hat Bugzilla – Bug 202236
Review Request: perl-POE-Component-SSLify
Last modified: 2013-05-10 06:56:10 EDT
SRPM URL: http://home.comcast.net/~ckweyl/perl-POE-Component-SSLify-0.04-1.fc5.src.rpm SPEC URL: http://home.comcast.net/~ckweyl/perl-POE-Component-SSLify.spec Description: This component represents the standard way to do SSL in POE.
Not much to say; builds fine and rpmlint is quiet. * source files match upstream: 8c3a9c5d538453105e20b2a3a0fce183 POE-Component-SSLify-0.04.tar.gz * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64). * rpmlint is silent. * final provides and requires are sane: perl(POE::Component::SSLify) = 0.04 perl(POE::Component::SSLify::ClientHandle) = 0.02 perl(POE::Component::SSLify::ServerHandle) = 0.02 perl-POE-Component-SSLify = 0.04-1.fc6 = perl(:MODULE_COMPAT_5.8.8) perl(Exporter) perl(Net::SSLeay) perl(POE) perl(POSIX) perl(Symbol) perl(strict) perl(vars) perl(warnings) * %check is present and all tests (test?) pass: All tests successful. Files=1, Tests=1, 0 wallclock secs ( 0.03 cusr + 0.02 csys = 0.05 CPU) * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. APPROVED
I like it when there's not much to say :) +Import to CVS +Add to owners.list +Bump release, build for devel +devel build succeeds +Request branching (FC-5) +Close bug Thanks for the review! :)
Package Change Request ====================== Package Name: perl-POE-Component-SSLify New Branches: el6 Owners: averi psabata InitialCC: perl-sig
Git done (by process-git-requests).