Bug 2022909 - pass has an explicit requirement on wl-clipboard even on non-Wayland desktops
Summary: pass has an explicit requirement on wl-clipboard even on non-Wayland desktops
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: pass
Version: 37
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Christophe Fergeau
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2053015
TreeView+ depends on / blocked
 
Reported: 2021-11-12 23:21 UTC by Dominik 'Rathann' Mierzejewski
Modified: 2023-01-26 01:43 UTC (History)
3 users (show)

Fixed In Version: pass-1.7.4-6.fc38 pass-1.7.4-6.fc37 pass-1.7.4-6.fc36
Clone Of:
Environment:
Last Closed: 2023-01-17 15:21:52 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Dominik 'Rathann' Mierzejewski 2021-11-12 23:21:47 UTC
Description of problem:
As a result of incorrect fix for bug 1996323, pass is now depending on wl-clipboard even when running a Wayland session is not supported (e.g. in MATE Desktop).

Version-Release number of selected component (if applicable):
1.7.4-3.fc35

How reproducible:
Always.

Steps to Reproduce:
1. Install Fedora MATE spin
2. dnf --enablerepo=updates-testing install pass

Actual results:
wl-clipboard gets installed.

Expected results:
wl-clipboard is a weak dependency and can be omitted using `-x wl-clipboard`.

Additional info:
I put a comment (https://bugzilla.redhat.com/show_bug.cgi?id=1996323#c18) in bug 1996323 on how to solve it better, but it was ignored. Hence I'm opening a separate bug for this.

Comment 1 Christophe Fergeau 2021-11-15 11:49:49 UTC
This was only ignored because of lack of time to take care of it, this was not ignored as "invalid" concern ;)
In your example, do you get both xclip and wl-clipboard installed, or only wl-clipboard? wl-clipboard seems 'standalone' from a dependency standpoint (yum install wl-clipboard does not look like it will drag more dependencies?

Comment 2 Dominik 'Rathann' Mierzejewski 2021-11-15 12:52:37 UTC
(In reply to Christophe Fergeau from comment #1)
> This was only ignored because of lack of time to take care of it, this was
> not ignored as "invalid" concern ;)

That is reassuring, thank you.

> In your example, do you get both xclip and wl-clipboard installed, or only
> wl-clipboard?

Both.

> wl-clipboard seems 'standalone' from a dependency standpoint
> (yum install wl-clipboard does not look like it will drag more dependencies?

Indeed, it doesn't depend on anything apart from libwayland-client.

Comment 3 Peter Georg 2022-08-22 11:37:05 UTC
I am currently working on the epel9 branch for which this bug is even more severe as nothing provides wl-clipboard there, but libwayland-client might be installed even though the user is not even running Wayland. In this case one can not install pass. This is the case on my own system.

I created a PR to fix this issue. Please have a look: https://src.fedoraproject.org/rpms/pass/pull-request/4

Comment 4 Ben Cotton 2022-11-29 17:18:34 UTC
This message is a reminder that Fedora Linux 35 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora Linux 35 on 2022-12-13.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
'version' of '35'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, change the 'version' 
to a later Fedora Linux version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora Linux 35 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora Linux, you are encouraged to change the 'version' to a later version
prior to this bug being closed.

Comment 5 Ben Cotton 2022-12-13 15:51:46 UTC
Fedora Linux 35 entered end-of-life (EOL) status on 2022-12-13.

Fedora Linux 35 is no longer maintained, which means that it
will not receive any further security or bug fix updates. As a result we
are closing this bug.

If you can reproduce this bug against a currently maintained version of Fedora Linux
please feel free to reopen this bug against that version. Note that the version
field may be hidden. Click the "Show advanced fields" button if you do not see
the version field.

If you are unable to reopen this bug, please file a new report against an
active release.

Thank you for reporting this bug and we are sorry it could not be fixed.

Comment 6 Christophe Fergeau 2022-12-13 16:08:21 UTC
Reopening as there's a PR I need to look at!

Comment 7 Fedora Update System 2023-01-17 15:11:57 UTC
FEDORA-2023-2bab6adc14 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-2bab6adc14

Comment 8 Fedora Update System 2023-01-17 15:21:52 UTC
FEDORA-2023-2bab6adc14 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 9 Fedora Update System 2023-01-17 15:44:28 UTC
FEDORA-2023-1b32b2593e has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2023-1b32b2593e

Comment 10 Fedora Update System 2023-01-17 15:44:53 UTC
FEDORA-2023-74d5bf3ed0 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-74d5bf3ed0

Comment 11 Fedora Update System 2023-01-18 02:36:53 UTC
FEDORA-2023-74d5bf3ed0 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-74d5bf3ed0`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-74d5bf3ed0

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2023-01-18 03:39:36 UTC
FEDORA-2023-1b32b2593e has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-1b32b2593e`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-1b32b2593e

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2023-01-26 01:21:22 UTC
FEDORA-2023-74d5bf3ed0 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 14 Fedora Update System 2023-01-26 01:43:20 UTC
FEDORA-2023-1b32b2593e has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.