Red Hat Bugzilla – Bug 202319
Review Request: perl-Data-Compare - Compare perl data structures
Last modified: 2007-11-30 17:11:40 EST
This module compares arbitrary data structures to see if they are copies
of each other.
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ dist tag is present.
+ build root is correct.
+ license field matches the actual license.
+ license is open source-compatible. License text not included upstream.
+ source files match upstream:
+ latest version is being packaged.
+ BuildRequires are proper.
package builds in mock ( ).
+ rpmlint is silent.
+ final provides and requires are sane:
perl(Data::Compare) = 0.13
perl(Data::Compare::Plugins::Scalar::Properties) = 1.0
perl-Data-Compare = 0.13-1.fc5
+ no shared libraries are present.
+ package is not relocatable.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ %clean is present.
+ All tests successful.
Files=7, Tests=76, 1 wallclock secs ( 0.55 cusr + 0.20 csys = 0.75 CPU)
%check is present and all tests pass:
+ no scriptlets present.
+ code, not content.
+ documentation is small, so no -docs subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.
+ no headers.
+ no pkgconfig files.
+ no libtool .la droppings.
+ not a GUI app.
+ not a web app.
Thanks for the review.
Imported and built for FC-5 and devel.