Spec URL: http://gsd.di.uminho.pt/jpo/software/fedora/nagios-plugins-snmp-disk-proc.spec SRPM URL: http://gsd.di.uminho.pt/jpo/software/fedora/nagios-plugins-snmp-disk-proc-1.0-1.src.rpm Description: These plugins allow you to monitor disk space and running processes on a remote machine via SNMP.
New location: ftp://perl.di.uminho.pt/pub/fedora/nagios-plugins-snmp-disk-proc.spec ftp://perl.di.uminho.pt/pub/fedora/nagios-plugins-snmp-disk-proc-1.0-1.src.rpm
OK - Package name OK - Spec file matches base package name. OK - Meets Packaging Guidelines. OK - License (GPL) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: cf70e405718d016debe206d01f54262c nagios-snmp-plugins-1.0.tar.gz cf70e405718d016debe206d01f54262c nagios-snmp-plugins-1.0.tar.gz.1 OK - Package compiles and builds on at least one arch. OK - BuildRequires correct OK - Package owns all the directories it creates. OK - Package has no duplicate files in %files. OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Spec has consistant macro usage. OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package doesn't own any directories other packages own. See below - No rpmlint output. SHOULD Items: OK - Should include License or ask upstream to include it. OK - Should build in mock. Issues: 1. rpmlint says: E: nagios-plugins-snmp-disk-proc-debuginfo description-line-too-long This package provides debug information for package nagios-plugins-snmp-disk-proc. I think this is just due to the very long name of this package, and can be ignored. Everything looks good to me, so this package is APPROVED. Don't forget to close this package NEXTRELEASE once it's been imported and built. Please consider doing a review of another package thats waiting to help spread the reviewing load.
Kevin, Thanks for the review. The package has been imported and built for FC-5 and devel. jpo