Created attachment 1841839 [details] [PATCH wev] Change wl_seat interface version to 5 Currently wev does not work with GNOME due to it requiring wl_seat interface version 6. I've talked to the upstream Wayland devs and version 6 really does not offer anything important over 5; and what it does offer is currently not actually supported by wev. For debugging various input-stack issues having a tool like wev is quite useful, so I've written the attach (trivial) patch which makes wev work with GNOME. Can you please add this patch as a downstream patch so that Fedora's wev packages will work with Fedora Workstation's default desktop? Note I've also submitted the patch upstream, but upstream is not particularly helpful when it comes to non wl_roots based compositors: https://lists.sr.ht/~sircmpwn/public-inbox/patches/25786
Hi Hans, My first concern is the effect on sway users. What guarantees are there that this change is harmless to them? Has it been well tested on sway? Versions? Other wlroots WM's? There is no testing code in the repo so it has to be manual testing. To be blunt, although I'd really like to just merge this and provide wev for GNOME users, I'm fearful of harming wl_seat-6 users - I have no idea what problems it could cause. I'm with Drew on this ("it's mutter's problem, not wev's") - is there a corresponding issue raised on mutter? It is a retrograde step for wev but GNOME will eventually catch up. In the meantime, it looks like Drew's been triggered to update wev to take advantage of wl_seat-6, so any change is likely to be temporary. GNOME developers can always patch & compile - as you know, it's a very simple build once you have the patch. It took me no more than 5m start to finish - and yes, it appears to work on f34/sway-1.6-1 in very limited testing. I haven't tried it on GNOME. Other alternatives: o you might provide a patch to automatically fallback to version 5 on error o you might provide an option to wev to use wl_seat-5 instead of -6 o we could provide an alternative build on COPR Auto-fallback (if possible) _should_ expose sway users to no harm and will be transparent when mutter moves to wl_seat-6. I think I would be happy to accept such a patch.
Created attachment 1843991 [details] [PATCH wev] Use wl_seat version 5 under GNOME Unfortunately wl_registry_bind() errors are fatal and abort the program so auto-fallback is not easily implemented. So instead I've now come up with an approach where wev detects that it is running under GNOME based on the XDG_CURRENT_DESKTOP environment variable and then lower the requested wl_seat version based on that.
Hans, Sounds good, but how can I know when to remove the patch? - when will Gnome upgrade to wl_seat-6 ??? I guess we can leave KDE out of the question ... :-) I'll put a note in the spec file to keep an eye on META_WL_SEAT_VERSION in mutter/wayland/meta-wayland-versions.h and I see if I can get this built today if I have time. Cheers Bob
FEDORA-2021-d4ace9042a has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-d4ace9042a
FEDORA-2021-e3c043a9ee has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-e3c043a9ee
Hans, Please test in your environment and bump karma as appropriate: rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=79420004 f34: https://koji.fedoraproject.org/koji/taskinfo?taskID=79420332 f35: https://koji.fedoraproject.org/koji/taskinfo?taskID=79420580 Note to self: https://gitlab.gnome.org/GNOME/mutter/-/blob/main/src/wayland/meta-wayland-versions.h
> Sounds good, but how can I know when to remove the patch? - when will Gnome upgrade to wl_seat-6 ??? Before writing the original patch I talked to the mutter devs and atm they have no intention to move to wl_seat-6 since it has only 1 addition ("shaped touch event" IIRC) which according to them don't really bring much (I think they likely requires special hardware). So all I can say is this will not happen soon. Other then that I don't really have a helpful answer I'm afraid. > Please test in your environment and bump karma as appropriate Thank you, I will test the F35 version right away.
The F35 build works well for me, thank you. Unfortunately I cannot leave positive karma in bodhi since bodhi seems to be broken atm.
bodhi search is broken, but the direct link here in the bug works, so I've left positive karma for the update now.
Thanks Hans. I think we can close this off now.
FEDORA-2021-e3c043a9ee has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-e3c043a9ee` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-e3c043a9ee See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2021-d4ace9042a has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-d4ace9042a` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-d4ace9042a See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2021-e3c043a9ee has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2021-d4ace9042a has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report.