Bug 202414 - Implement plugins
Summary: Implement plugins
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: vsftpd
Version: rawhide
Hardware: All
OS: Linux
medium
low
Target Milestone: ---
Assignee: Jiri Skala
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2006-08-14 10:11 UTC by Patrick Monnerat
Modified: 2014-11-09 22:30 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2010-03-16 09:45:54 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Patch to imlement plugins (28.17 KB, patch)
2006-08-14 10:11 UTC, Patrick Monnerat
no flags Details | Diff
Patch to implement plugins (against vsftpd-2.0.7-1.fc10.src.rpm) (28.27 KB, patch)
2008-11-24 14:43 UTC, Patrick Monnerat
no flags Details | Diff
Patch to implement plugins (against vsftpd-2.2.0-5) (28.57 KB, patch)
2009-11-20 19:52 UTC, Patrick Monnerat
no flags Details | Diff

Description Patrick Monnerat 2006-08-14 10:11:18 UTC
Description of problem: Need of various extra operations upon file
send/receive/rename. This is an extension path proposal, not a bug report.
Submitted here, because upstream does not answer.


Version-Release number of selected component (if applicable): 2.0.4-1.2


Additional info:
The attached patch implements a plugin feature. A plugin .so library is called
before and after a file is sent/received/deleted/renamed or a directory is
created/deleted/renamed.
It is particularly useful to perform some extra permission checking, statistics,
 active file processing, etc.
See file PLUGINS after apply patch for a usage description.

Comment 1 Patrick Monnerat 2006-08-14 10:11:18 UTC
Created attachment 134123 [details]
Patch to imlement plugins

Comment 2 Maros Barabas 2006-08-15 09:58:08 UTC
Thanks for patch, I'll append it, but it could be earliest in fedora core 7.

Comment 3 Patrick Monnerat 2006-08-15 11:29:28 UTC
Many thanks. If you do so, I will suggest to create a package vsftpd-devel with 
the following files:

/usr/include/vsftpd/plugins.h
/usr/share/doc/vstpd-devel-x.y.z/COPYING
/usr/share/doc/vstpd-devel-x.y.z/PLUGINS

to allow easy plugin development.

Comment 4 Patrick Monnerat 2007-05-30 10:26:46 UTC
... by looking at the development packages, it seems it will NOT be included in
Fedora 7 ...
Are there some plans to really include it ?

Comment 5 Maros Barabas 2007-08-27 13:57:23 UTC
Hi, sorry but this plugins could be implemented in Fedora 9 and later after
testing version. Upstream doesn't answer a long time so we have to make review,
test package and a lot of tests. Sorry for this long process.

Comment 6 Patrick Monnerat 2007-08-27 17:11:37 UTC
Yes, upstream site seems abandoned. This is a pity because the product is good.
I hope I'm wrong, ot that someone else will make it live again.
Anyway, I'm running FC6 for now and ported this patch to the FC6 version (2.0.5-
10): I'm using it daily (in a prod server) and it did not need real update 
since FC6 early days.
When you need the patch for 2.0.5-10, just ask here !
Thanks for your interest

Comment 7 ofir_144 2008-09-05 21:21:38 UTC
Will functions that are called using this plugin be able to access files out of the chroot? (e.g. /bin/sh )

Comment 8 Patrick Monnerat 2008-09-29 12:42:10 UTC
No. They are called directly. Plugin library is loaded dynamically (dlopen), plugin function addresses are latched, then called when needed, thus being executed in the same context as the server process. No fork/exec is performed.

Comment 9 Patrick Monnerat 2008-11-24 14:43:05 UTC
Created attachment 324485 [details]
Patch to implement plugins (against vsftpd-2.0.7-1.fc10.src.rpm)

Applicable as is to vsftpd-2.0.7-1.fc10.src.rpm after all other patches.

Comment 10 Patrick Monnerat 2009-11-20 19:52:27 UTC
Created attachment 372593 [details]
Patch to implement plugins (against vsftpd-2.2.0-5)

This version of the patch fixes compilation problems on 64-bit architectures

Comment 11 Jiri Skala 2010-01-19 08:56:12 UTC
Upstream communicates over one year again. I've sent the patch to Chris Evans aprox. half a year ago. I don't plan to add this patch independently of upstream.

Jiri

Comment 12 Jiri Skala 2010-03-16 09:45:54 UTC
Upstream has obtained this patch therefore I don't see any reason to keep the bug opened in accordance to comment 11.


Note You need to log in before you can comment on or make changes to this bug.