Spec URL: http://people.atrpms.net/~hdegoede/trackballs.spec SRPM URL: http://people.atrpms.net/~hdegoede/trackballs-1.1.2-1.src.rpm Description: Trackballs is a game in which you steer a marble ball through tracks of varying difficulty. The game features 3D graphics, an integerated level editor and high quality soundeffects and background music.
This is a fairly easy package: GOOD ==== * rpmlint output clean * Package/spec name matches upstream * GPL license ok, license file included * Source matches upstream: 9ea9ca93d87bb0f9ad8abca1b34af594 trackballs-1.1.2.tar.gz * Builds in mock on FC5-i386, FC5-x86_64, FC6-i386, FC6-x86_64 * No need for a -devel subpackage * No need for a -doc subpackage * locale files installed correctly * .desktop file installed correctly * icon files installed and updated in %post/%postun correctly * No duplicate %files * Owns all directories that it creates; does not own directories that it should not. * Runs on FC5-x86_64. MUSTFIX ======= * BR: libGL-devel is redundant. This is already required by libGLU-devel. * BR: gcc-c++ is already part of the minimal buildroot, so it can be removed.
(In reply to comment #1) > > MUSTFIX > ======= > * BR: libGL-devel is redundant. This is already required by libGLU-devel. > * BR: gcc-c++ is already part of the minimal buildroot, so it can be removed. New version with this fixed here: Spec URL: http://people.atrpms.net/~hdegoede/trackballs.spec SRPM URL: http://people.atrpms.net/~hdegoede/trackballs-1.1.2-2.src.rpm
All MUSTFIX items fixed. APPROVED.
Thanks! Imported and build, closing.