Spec URL: https://smani.fedorapeople.org/review/mingw-osgearth.spec SRPM URL: https://smani.fedorapeople.org/review/mingw-osgearth-3.2-1.fc36.src.rpm Description: MinGW Windows osgearth library Fedora Account System Username: smani
The built packages don't install. They depend on libgdal-30.dll and libprotobuf-30.dll which don't exist. I don't know why that is. I see libgdal-29.dll and libprotobuf-25.dll. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_use_rpmlint [x]: Spec file according to URL is the same as in SRPM. Installation errors ------------------- INFO: mock.py version 2.14 starting (python version = 3.10.0, NVR = mock-2.14-1.fc35)... Start: init plugins INFO: selinux enabled Finish: init plugins INFO: Signal handler active Start: run Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled package manager cache Start: cleaning package manager metadata Finish: cleaning package manager metadata INFO: enabled HW Info plugin Mock Version: 2.14 INFO: Mock Version: 2.14 Finish: chroot init INFO: installing package(s): /home/dulsi/2024295-mingw-osgearth/results/mingw32-osgearth-tools-3.2-1.fc36.noarch.rpm /home/dulsi/2024295-mingw-osgearth/results/mingw32-osgearth-3.2-1.fc36.noarch.rpm /home/dulsi/2024295-mingw-osgearth/results/mingw64-osgearth-tools-3.2-1.fc36.noarch.rpm /home/dulsi/2024295-mingw-osgearth/results/mingw32-osgearth-debuginfo-3.2-1.fc36.noarch.rpm /home/dulsi/2024295-mingw-osgearth/results/mingw64-osgearth-debuginfo-3.2-1.fc36.noarch.rpm /home/dulsi/2024295-mingw-osgearth/results/mingw64-osgearth-3.2-1.fc36.noarch.rpm ERROR: Command failed: # /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 36 --setopt=deltarpm=False --allowerasing --disableplugin=local --disableplugin=spacewalk --disableplugin=versionlock install /home/dulsi/2024295-mingw-osgearth/results/mingw32-osgearth-tools-3.2-1.fc36.noarch.rpm /home/dulsi/2024295-mingw-osgearth/results/mingw32-osgearth-3.2-1.fc36.noarch.rpm /home/dulsi/2024295-mingw-osgearth/results/mingw64-osgearth-tools-3.2-1.fc36.noarch.rpm /home/dulsi/2024295-mingw-osgearth/results/mingw32-osgearth-debuginfo-3.2-1.fc36.noarch.rpm /home/dulsi/2024295-mingw-osgearth/results/mingw64-osgearth-debuginfo-3.2-1.fc36.noarch.rpm /home/dulsi/2024295-mingw-osgearth/results/mingw64-osgearth-3.2-1.fc36.noarch.rpm --setopt=tsflags=nocontexts Rpmlint ------- Cannot parse rpmlint output: Source checksums ---------------- https://github.com/gwaldron/osgearth/archive/osgearth-3.2/osgearth-3.2.tar.gz : CHECKSUM(SHA256) this package : 7e1dd643b1f3b8d1ba9561b899c18176af988342b86c42d89a70be924cb747f6 CHECKSUM(SHA256) upstream package : 7e1dd643b1f3b8d1ba9561b899c18176af988342b86c42d89a70be924cb747f6 Requires -------- mingw32-osgearth (rpmlib, GLIBC filtered): mingw32(kernel32.dll) mingw32(libcurl-4.dll) mingw32(libgcc_s_dw2-1.dll) mingw32(libgdal-30.dll) mingw32(libgeos_c-1.dll) mingw32(libopenthreads.dll) mingw32(libosg.dll) mingw32(libosgdb.dll) mingw32(libosgearth.dll) mingw32(libosgga.dll) mingw32(libosgmanipulator.dll) mingw32(libosgshadow.dll) mingw32(libosgsim.dll) mingw32(libosgtext.dll) mingw32(libosgutil.dll) mingw32(libosgviewer.dll) mingw32(libprotobuf-30.dll) mingw32(libsqlite3-0.dll) mingw32(libssp-0.dll) mingw32(libstdc++-6.dll) mingw32(libwebp-7.dll) mingw32(libwinpthread-1.dll) mingw32(msvcrt.dll) mingw32(opengl32.dll) mingw32-crt mingw32-filesystem mingw32-osgearth-tools (rpmlib, GLIBC filtered): mingw32(kernel32.dll) mingw32(libgcc_s_dw2-1.dll) mingw32(libopenthreads.dll) mingw32(libosg.dll) mingw32(libosgdb.dll) mingw32(libosgearth.dll) mingw32(libosgga.dll) mingw32(libosgtext.dll) mingw32(libosgutil.dll) mingw32(libosgviewer.dll) mingw32(libstdc++-6.dll) mingw32(libwinpthread-1.dll) mingw32(msvcrt.dll) mingw32-crt mingw32-filesystem mingw64-osgearth (rpmlib, GLIBC filtered): mingw64(kernel32.dll) mingw64(libcurl-4.dll) mingw64(libgcc_s_seh-1.dll) mingw64(libgdal-30.dll) mingw64(libgeos_c-1.dll) mingw64(libopenthreads.dll) mingw64(libosg.dll) mingw64(libosgdb.dll) mingw64(libosgearth.dll) mingw64(libosgga.dll) mingw64(libosgmanipulator.dll) mingw64(libosgshadow.dll) mingw64(libosgsim.dll) mingw64(libosgtext.dll) mingw64(libosgutil.dll) mingw64(libosgviewer.dll) mingw64(libprotobuf-30.dll) mingw64(libsqlite3-0.dll) mingw64(libssp-0.dll) mingw64(libstdc++-6.dll) mingw64(libwebp-7.dll) mingw64(libwinpthread-1.dll) mingw64(msvcrt.dll) mingw64(opengl32.dll) mingw64-crt mingw64-filesystem mingw64-osgearth-tools (rpmlib, GLIBC filtered): mingw64(kernel32.dll) mingw64(libgcc_s_seh-1.dll) mingw64(libosg.dll) mingw64(libosgdb.dll) mingw64(libosgearth.dll) mingw64(libosgga.dll) mingw64(libosgtext.dll) mingw64(libosgutil.dll) mingw64(libosgviewer.dll) mingw64(libstdc++-6.dll) mingw64(libwinpthread-1.dll) mingw64(msvcrt.dll) mingw64-crt mingw64-filesystem mingw32-osgearth-debuginfo (rpmlib, GLIBC filtered): mingw64-osgearth-debuginfo (rpmlib, GLIBC filtered): Provides -------- mingw32-osgearth: mingw32(libosgearth.dll) mingw32(mingw_osgdb_earth.dll) mingw32(mingw_osgdb_fastdxt.dll) mingw32(mingw_osgdb_gltf.dll) mingw32(mingw_osgdb_kml.dll) mingw32(mingw_osgdb_lerc.dll) mingw32(mingw_osgdb_osgearth_bumpmap.dll) mingw32(mingw_osgdb_osgearth_cache_filesystem.dll) mingw32(mingw_osgdb_osgearth_colorramp.dll) mingw32(mingw_osgdb_osgearth_detail.dll) mingw32(mingw_osgdb_osgearth_engine_rex.dll) mingw32(mingw_osgdb_osgearth_featurefilter_intersect.dll) mingw32(mingw_osgdb_osgearth_featurefilter_join.dll) mingw32(mingw_osgdb_osgearth_mapinspector.dll) mingw32(mingw_osgdb_osgearth_monitor.dll) mingw32(mingw_osgdb_osgearth_scriptengine_javascript.dll) mingw32(mingw_osgdb_osgearth_sky_gl.dll) mingw32(mingw_osgdb_osgearth_sky_simple.dll) mingw32(mingw_osgdb_osgearth_terrainshader.dll) mingw32(mingw_osgdb_osgearth_vdatum_egm2008.dll) mingw32(mingw_osgdb_osgearth_vdatum_egm84.dll) mingw32(mingw_osgdb_osgearth_vdatum_egm96.dll) mingw32(mingw_osgdb_osgearth_viewpoints.dll) mingw32(mingw_osgdb_template.dll) mingw32(mingw_osgdb_webp.dll) mingw32-osgearth mingw32-osgearth-tools: mingw32-osgearth-tools mingw64-osgearth: mingw64(libosgearth.dll) mingw64(mingw_osgdb_earth.dll) mingw64(mingw_osgdb_fastdxt.dll) mingw64(mingw_osgdb_gltf.dll) mingw64(mingw_osgdb_kml.dll) mingw64(mingw_osgdb_lerc.dll) mingw64(mingw_osgdb_osgearth_bumpmap.dll) mingw64(mingw_osgdb_osgearth_cache_filesystem.dll) mingw64(mingw_osgdb_osgearth_colorramp.dll) mingw64(mingw_osgdb_osgearth_detail.dll) mingw64(mingw_osgdb_osgearth_engine_rex.dll) mingw64(mingw_osgdb_osgearth_featurefilter_intersect.dll) mingw64(mingw_osgdb_osgearth_featurefilter_join.dll) mingw64(mingw_osgdb_osgearth_mapinspector.dll) mingw64(mingw_osgdb_osgearth_monitor.dll) mingw64(mingw_osgdb_osgearth_scriptengine_javascript.dll) mingw64(mingw_osgdb_osgearth_sky_gl.dll) mingw64(mingw_osgdb_osgearth_sky_simple.dll) mingw64(mingw_osgdb_osgearth_terrainshader.dll) mingw64(mingw_osgdb_osgearth_vdatum_egm2008.dll) mingw64(mingw_osgdb_osgearth_vdatum_egm84.dll) mingw64(mingw_osgdb_osgearth_vdatum_egm96.dll) mingw64(mingw_osgdb_osgearth_viewpoints.dll) mingw64(mingw_osgdb_template.dll) mingw64(mingw_osgdb_webp.dll) mingw64-osgearth mingw64-osgearth-tools: mingw64-osgearth-tools mingw32-osgearth-debuginfo: mingw32-osgearth-debuginfo mingw64-osgearth-debuginfo: mingw64-osgearth-debuginfo
These are in mingw-protobuf-3.19.0-1.fc36 and mingw-gdal-3.4.0-1.fc36, which are available in the regular rawhide repos: dnf repoquery --whatprovides 'mingw64(libprotobuf-30.dll)' mingw64-protobuf-0:3.19.0-1.fc36.noarch dnf repoquery --whatprovides 'mingw64(libgdal-30.dll)' mingw64-gdal-0:3.4.0-1.fc36.noarch Perhaps your repodata is out of date?
I'm just not good at doing reviews. :) I was using Fedora 35 not rawhide. Looks good.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/mingw-osgearth
Thanks for the review!