Bug 2024814 - Review Request: rust-rustls-pemfile - Basic .pem file parser for keys and certificates
Summary: Review Request: rust-rustls-pemfile - Basic .pem file parser for keys and cer...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2011969
TreeView+ depends on / blocked
 
Reported: 2021-11-19 06:25 UTC by Davide Cavalca
Modified: 2022-04-02 01:56 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2022-03-24 21:47:46 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Davide Cavalca 2021-11-19 06:25:28 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-rustls-pemfile/rust-rustls-pemfile.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-rustls-pemfile/rust-rustls-pemfile-0.2.1-1.fc36.src.rpm

Description:
Basic .pem file parser for keys and certificates.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2021-11-19 06:25:30 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=79057785

Comment 2 Fabio Valentini 2022-01-06 18:00:05 UTC
Taking this review (I need this package too, for reqwest 0.11.8).

Two minor issues:

- regenerate the spec with rust2rpm 20
- drop unused "criterion" dev-dependency (only used for benchmarks, so it's unused during RPM builds, but it is still compiled and increases build times by *a lot*)

(regenerating with "rust2rpm -sap rustls-pemfile" and removing "criterion" dev-dependency from Cargo.toml should fix both issues)

Comment 3 Fabio Valentini 2022-03-18 18:54:00 UTC
@dcavalca are you still interested in getting this package reviewed?
Otherwise I will submit a review request for it myself, as I need it for updating reqwest with all features enabled.

Comment 4 Davide Cavalca 2022-03-24 15:16:18 UTC
Yep, I'll try and get this wrapped up today or tomorrow.

Comment 5 Davide Cavalca 2022-03-24 15:22:47 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-rustls-pemfile/rust-rustls-pemfile.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-rustls-pemfile/rust-rustls-pemfile-0.3.0-1.fc37.src.rpm

Changelog
- re-run rust2rpm
- update to 0.3.0
- drop criterion dev-dependency

Comment 6 Fabio Valentini 2022-03-24 17:33:03 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (ASL 2.0 or ISC or MIT) and is acceptable for Fedora
- license files are included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

===

Please build this package for f34+ as I will need it for future builds of request.

Comment 7 Davide Cavalca 2022-03-24 19:07:26 UTC
Thanks!

$ fedpkg request-repo rust-rustls-pemfile 2024814
https://pagure.io/releng/fedora-scm-requests/issue/43159

Comment 8 Fabio Valentini 2022-03-24 20:13:07 UTC
You can already submit requests for the other branches, if you want to reduce round-trip-time for the fedora-scm-requests ticket queue:

$ fedpkg request-branch --repo rust-rustls-pemfile f36
$ fedpkg request-branch --repo rust-rustls-pemfile f35
$ fedpkg request-branch --repo rust-rustls-pemfile f34

Those tickets are processed in the order in which they were submitted, so there's no need to wait until the "request-repo" ticket is processed before submitting the other ones.

Comment 9 Davide Cavalca 2022-03-24 20:23:28 UTC
Oh thanks, I didn't know that. Done:

$ fedpkg request-branch --repo rust-rustls-pemfile f36
https://pagure.io/releng/fedora-scm-requests/issue/43160
$ fedpkg request-branch --repo rust-rustls-pemfile f35
https://pagure.io/releng/fedora-scm-requests/issue/43161
$ fedpkg request-branch --repo rust-rustls-pemfile f34
https://pagure.io/releng/fedora-scm-requests/issue/43162

Comment 10 Gwyn Ciesla 2022-03-24 21:16:49 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-rustls-pemfile

Comment 11 Fedora Update System 2022-03-24 21:45:08 UTC
FEDORA-2022-b640231e6d has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-b640231e6d

Comment 12 Fedora Update System 2022-03-24 21:47:46 UTC
FEDORA-2022-b640231e6d has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2022-03-24 21:54:55 UTC
FEDORA-2022-bc23243a63 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-bc23243a63

Comment 14 Fedora Update System 2022-03-24 22:03:04 UTC
FEDORA-2022-316b915c11 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-316b915c11

Comment 15 Fedora Update System 2022-03-24 22:12:54 UTC
FEDORA-2022-1ecdd99f7d has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2022-1ecdd99f7d

Comment 16 Fedora Update System 2022-03-25 21:55:30 UTC
FEDORA-2022-bc23243a63 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-bc23243a63 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-bc23243a63

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 17 Fedora Update System 2022-03-25 22:55:19 UTC
FEDORA-2022-1ecdd99f7d has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-1ecdd99f7d \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-1ecdd99f7d

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 18 Fedora Update System 2022-03-25 23:25:51 UTC
FEDORA-2022-316b915c11 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-316b915c11 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-316b915c11

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 19 Fedora Update System 2022-03-29 00:17:14 UTC
FEDORA-2022-bc23243a63 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 20 Fedora Update System 2022-04-02 01:54:26 UTC
FEDORA-2022-316b915c11 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 21 Fedora Update System 2022-04-02 01:56:24 UTC
FEDORA-2022-1ecdd99f7d has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.