Bug 2024917 - Review Request: pipewalker - "complete the circuit" puzzle game
Summary: Review Request: pipewalker - "complete the circuit" puzzle game
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Zbigniew Jędrzejewski-Szmek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-11-19 14:02 UTC by Artur Frenszek-Iwicki
Modified: 2021-12-02 02:03 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-12-02 01:15:08 UTC
Type: ---
Embargoed:
zbyszek: fedora-review+


Attachments (Terms of Use)

Description Artur Frenszek-Iwicki 2021-11-19 14:02:45 UTC
spec: https://svgames.pl/fedora/pipewalker-0.9.4-1/pipewalker.spec
srpm: https://svgames.pl/fedora/pipewalker-0.9.4-1/pipewalker-0.9.4-1.fc34.src.rpm
koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=79070840

Description: PipeWalker is a puzzle game in which you need to combine components into a single circuit: connect all computers to a network server, bring water to the taps, etc.

Fedora Account System Username: suve

Comment 1 Zbigniew Jędrzejewski-Szmek 2021-11-21 12:56:06 UTC
> Patch0: %{name}--format-security.patch

Using a macro here is *allowed*, but why would one want to do this? For me it does
nothing except making it impossible to easily open the file from an editor which does
not understand rpm macros.

> %description
It's broken at ~60-70 chars, should be 80 ;)

One thing that is missing is an appdata file [1]. Guidelines say "SHOULD", so this is
not a blocker, but please consider adding one, as it will make graphical installations
much easier, which is probably important for the class of users who use games.

[1] https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/

- package name is OK
- latest version (2012-03-19, yikes!)
- license is acceptable for Fedora (GPLv3+)
- license is specified correctly
- builds and installs correctly
- BR/R/P look OK
- runs OK:
The window shows and reacts to clicks, sounds and templates work.

rpmlint:

pipewalker.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/pipewalker/README
pipewalker.x86_64: W: no-manual-page-for-binary pipewalker
4 packages and 0 specfiles checked; 0 errors, 2 warnings.
Nothing important.

I think it'd be nice to add some README. I couldn't figure out what the point of the game was ;)

Comment 2 Artur Frenszek-Iwicki 2021-11-21 13:18:51 UTC
> One thing that is missing is an appdata file [1]. Guidelines say "SHOULD", so this is
> not a blocker, but please consider adding one, as it will make graphical installations
> much easier, which is probably important for the class of users who use games.
I'll probably add one later, but even then, this won't change anything, since
Gnome Software has a minimum icon size criteria (48x48 or 64x64, if I remember correctly)
and apps which don't provide large enough icons don't show up in search results.
(I guess this could be mentioned in the Guidelines, somewhere? Couldn't find it anywhere.)

Though I guess I could use hq2x or something to just scale up the 32x32 pixmap.

Comment 3 Zbigniew Jędrzejewski-Szmek 2021-11-21 13:25:37 UTC
I haven't done an appdata file in a while… but I remember that generating something that would display
properly in gnome-software wasn't easy ;)

'convert -geometry 64 input.bmp output.bmp' should work, though the result won't be very visually appealing.

Comment 4 Igor Raits 2021-11-21 16:59:34 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/pipewalker

Comment 5 Fedora Update System 2021-11-23 23:24:00 UTC
FEDORA-2021-1036589cf5 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-1036589cf5

Comment 6 Fedora Update System 2021-11-23 23:32:12 UTC
FEDORA-2021-3099b4adb0 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-3099b4adb0

Comment 7 Fedora Update System 2021-11-24 01:56:46 UTC
FEDORA-2021-3099b4adb0 has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-3099b4adb0 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-3099b4adb0

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2021-11-24 01:57:51 UTC
FEDORA-2021-1036589cf5 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-1036589cf5 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-1036589cf5

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2021-12-02 01:15:08 UTC
FEDORA-2021-1036589cf5 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 10 Fedora Update System 2021-12-02 02:03:06 UTC
FEDORA-2021-3099b4adb0 has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.