Description: Implementation of bounded Levenshtein distance (Ukkonen) SPEC: https://fedorapeople.org/~limb/review/python-ukkonen/python-ukkonen.spec SRPM: https://fedorapeople.org/~limb/review/python-ukkonen/python-ukkonen-1.0.1-1.fc35.src.rpm
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/licenses/python3-ukkonen/LICENSE See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files The top-level license file is the current package license file. The one in licenses/ is the one for the original JavaScript implementation, https://github.com/sunesimonsen/ukkonen. Unfortunately, since both files have the same name, they are both installed as /usr/share/licenses/python3-ukkonen/LICENSE, and so in the end, only one is installed. Suggested fix: in %prep: cp -p licenses/LICENSE LICENSE-upstream In %files: %license LICENSE LICENSE-upstream - Omitting the first argument of %pypi_source is deprecated, so Source0: %{pypi_source} is better written: Source0: %{pypi_source ukkonen} or, if you want to keep using the pypi_name macro, Source0: %{pypi_source %{pypi_name}} https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_convenience_macros - The pypi_version macro provides nothing useful compared to: Version: 1.0.1 and using %{version} everywhere %{pypi_version} is currently used. There’s no reason you can’t use it, but it’s an unnecessary layer of indirection. Changing this is not required for approval. - Upstream provides tests in the GitHub release. Consider: Source0: %{url}/archive/v%{version}/ukkonen-%{version}.tar.gz and: BuildRequires: python3dist(pytest) and: %check %pytest - The python_provide macro is obsolete in all Fedora Releases. Please remove: %{?python_provide:%python_provide python3-%{pypi_name}} - This shouldn’t be needed; the dependency should be automatically generated based on install_requires in setup.cfg. Requires: python3dist(cffi) >= 1 - Are you interested in converting this to the “new Python guidelines” (pyproject-rpm-macros)? It would simplify the spec file even more. If so, I’m happy to send a PR after import. ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. The only unversioned .so is a properly-installed compiled Python extension module. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT License", "Unknown or generated", "*No copyright* MIT License". 7 files have unknown license. Detailed output of licensecheck in /home/reviewer/2025024-python-ukkonen/licensecheck.txt [!]: License file installed when any subpackage combination is installed. Only one of the two license files is installed because they have the same basename. See Issues. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-ukkonen [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Unversioned so-files -------------------- python3-ukkonen: /usr/lib64/python3.10/site-packages/_ukkonen.abi3.so Source checksums ---------------- https://files.pythonhosted.org/packages/source/u/ukkonen/ukkonen-1.0.1.tar.gz : CHECKSUM(SHA256) this package : 976ad9a991c9cb99a7c318695a5f6b46236bbd4c33c5b55273fa241dfca8e0fa CHECKSUM(SHA256) upstream package : 976ad9a991c9cb99a7c318695a5f6b46236bbd4c33c5b55273fa241dfca8e0fa Requires -------- python3-ukkonen (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) python(abi) python3.10dist(cffi) python3dist(cffi) rtld(GNU_HASH) python-ukkonen-debugsource (rpmlib, GLIBC filtered): Provides -------- python3-ukkonen: python-ukkonen python3-ukkonen python3-ukkonen(x86-64) python3.10-ukkonen python3.10dist(ukkonen) python3dist(ukkonen) python-ukkonen-debugsource: python-ukkonen-debugsource python-ukkonen-debugsource(x86-64) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 2025024 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, C/C++, Shell-api, Python Disabled plugins: Ocaml, R, Perl, SugarActivity, Haskell, fonts, PHP, Java Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Yes, please! This was a quick-and dirty pypy2rpm, and it shows. :) Updated. SPEC: https://fedorapeople.org/~limb/review/python-ukkonen/python-ukkonen.spec SRPM: https://fedorapeople.org/~limb/review/python-ukkonen/python-ukkonen-1.0.1-2.fc35.src.rpm
Sorry for the delay! This looks good now, and the package is approved. A full-re-review is below. All rpmlint messages appear spurious. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. The only unversioned .so file is a properly-installed compiled Python extension module. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* MIT License". 13 files have unknown license. Detailed output of licensecheck in /home/reviewer/2025024-python- ukkonen/20211205/2025024-python-ukkonen/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-ukkonen [x]: Package functions as described. (based on %check passing) [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Unversioned so-files -------------------- python3-ukkonen: /usr/lib64/python3.10/site-packages/_ukkonen.abi3.so Source checksums ---------------- https://www.github.com/asottile/ukkonen/archive/v1.0.1/ukkonen-1.0.1.tar.gz : CHECKSUM(SHA256) this package : 5f3fd0e9c1b2a7ea669382ec3928370f11882cec991c4d3757955b56d18895f6 CHECKSUM(SHA256) upstream package : 5f3fd0e9c1b2a7ea669382ec3928370f11882cec991c4d3757955b56d18895f6 Requires -------- python3-ukkonen (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) python(abi) python3.10dist(cffi) rtld(GNU_HASH) python-ukkonen-debugsource (rpmlib, GLIBC filtered): Provides -------- python3-ukkonen: python-ukkonen python3-ukkonen python3-ukkonen(x86-64) python3.10-ukkonen python3.10dist(ukkonen) python3dist(ukkonen) python-ukkonen-debugsource: python-ukkonen-debugsource python-ukkonen-debugsource(x86-64) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 2025024 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Generic, Python, Shell-api Disabled plugins: SugarActivity, Java, fonts, Ocaml, Haskell, Perl, PHP, R Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH ============================ rpmlint session starts ============================ rpmlint: 2.1.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 4 python3-ukkonen-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/lib64/python3.10/site-packages/_ukkonen.abi3.so-1.0.1-2.fc36.x86_64.debug python3-ukkonen-debuginfo.x86_64: E: shared-library-without-dependency-information /usr/lib/debug/usr/lib64/python3.10/site-packages/_ukkonen.abi3.so-1.0.1-2.fc36.x86_64.debug python3-ukkonen-debuginfo.x86_64: W: no-documentation python-ukkonen-debugsource.x86_64: W: no-documentation python3-ukkonen-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/30/a55a11ac3809ab967dde76eaeb4e548d92d79b ../../../.build-id/30/a55a11ac3809ab967dde76eaeb4e548d92d79b 4 packages and 0 specfiles checked; 1 errors, 4 warnings, 1 badness; has taken 0.5 s
No worries, thank you so much!
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-ukkonen