Bug 202529 - Review Request: rt2500-(kmod-common)
Summary: Review Request: rt2500-(kmod-common)
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2006-08-14 22:28 UTC by Nicolas Chauvet (kwizart)
Modified: 2007-11-30 22:11 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-10-02 23:53:18 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Nicolas Chauvet (kwizart) 2006-08-14 22:28:16 UTC
Spec URL: http://kwizart.free.fr/fedora/SPECS/rt2500.spec
SRPM URL: http://kwizart.free.fr/fedora/5/SRPMS/rt2500-0.0.0.2006080806-3_FC5.src.rpm
Description: User module and Diagnostic tools for Ralink Wireless devices

Comment 1 Paul F. Johnson 2006-08-14 22:39:29 UTC
BuildRequires:  qt-devel >= 3.2.1

If you're only packing this for FC5/6/rawhide, you won't need this.

You will need to include desktop-file-utils

ExclusiveArch:	i686 x86_64

Needs a note explaining why also needs a note why smp_mflags are not used on the
make line

%install
cd Utilitys

No.

If the file is in Utilitys from the BUILD directory, it should be

install Utilitys/foo $RPM_BUILD_DIR%{_bindir}/foo

You don't need to use cd

mkdir -p $RPM_BUILD_ROOT%{_datadir}/doc/rt2500
install -D -p -m 0644 THANKS CHANGELOG FAQ LICENSE
$RPM_BUILD_ROOT%{_datadir}/doc/rt2500

These should be done in the %files section using %doc
ie.

%doc THANKS CHANGELOG FAQ etc. If the mode is not already correct, %prep is the
correct place to fix it.

cat > %{name}.desktop <<EOF

No Version tag

desktop-file-install --vendor livna 

livna?

gtk-update-icon-cache -qf %{_datadir}/pixmaps/rt2500 &>/dev/null || :
update-desktop-database &>/dev/null || :

Have a look at

http://fedoraproject.org/wiki/ScriptletSnippets#head-fc74f078205565f961f6d836b77c3428619c689d

for advice on this. You can't just assume gtk-update-icon-cache or
update-desktop-database exist, they have to be checked and the package they come
from included in the BRs

%{_datadir}/pixmaps/rt2500/RaConfig2500.xpm
%{_datadir}/pixmaps/rt2500/adapter.xpm

No.

%{_datadir}/pixmaps/%{name}/

is all that is required

%doc %{_datadir}/doc/rt2500/*

See above



Comment 2 Nicolas Chauvet (kwizart) 2006-08-15 00:30:04 UTC
updated version of the spec file:
- drop qt-devel >= 3.2.1
* how to include desktop-file-utils?
- drop exclusive arch, may build on i586, i686, x86_64 - maybe on pcc?(asking team)
* what is a version tag example with applet desktop ?
- dropped gtk-icon-cache (not high res directory - remplaced with ln rt2500/foo.xpm
- doc ok!

What else may


Comment 3 Nicolas Chauvet (kwizart) 2006-08-15 12:51:21 UTC
... be corrected?

ppc (big endian) may be very buggy cf
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202528
dropped for testing? i586 is certainly good also...

Comment 4 Nicolas Chauvet (kwizart) 2006-08-18 01:34:33 UTC
Spec URL: http://kwizart.free.fr/fedora/SPECS/rt2500.spec
SRPM URL:
http://kwizart.free.fr/fedora/5/SRPMS/rt2500-1.1.0.cvs2006081716-4_FC5.src.rpm
Description: Diagnostic tools for Ralink Wireless devices

rpmlint -1 success... (i686, debug, src)

There is still a problem with RaConfig2500 for asking root password with pam...
( Any info about this ? )

Comment 5 David Fraser 2006-09-23 19:47:28 UTC
some of the install -D caused problems for me in the latest spec file - they
seemed to be in the case where there is a file given with a directory
destination (-D expects the full pathname as destination):
mkdir -p $RPM_BUILD_ROOT%{_sysconfdir}/sysconfig/network-scripts
install -D -p -m 0644 Module/ifcfg-ra0
$RPM_BUILD_ROOT%{_sysconfdir}/sysconfig/network-scripts

That -D (and several other similar) should be removed AFAICT

Comment 6 Nicolas Chauvet (kwizart) 2006-10-02 23:53:18 UTC
Review closed because rt2x00 can now be built, i'm using bug :
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202528
to request review of rt2x00-kmod and rt2x00-kmod-common.


Note You need to log in before you can comment on or make changes to this bug.