Bug 2025390 - add xwininfo dependency for x2goserver rpm
Summary: add xwininfo dependency for x2goserver rpm
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: x2goserver
Version: 35
Hardware: All
OS: Linux
unspecified
low
Target Milestone: ---
Assignee: Orion Poplawski
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-11-22 03:54 UTC by Leif Liddy
Modified: 2022-01-28 01:35 UTC (History)
1 user (show)

Fixed In Version: x2goserver-4.1.0.3-15.fc34 x2goserver-4.1.0.3-15.fc35
Clone Of:
Environment:
Last Closed: 2022-01-27 19:38:04 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
proposed patch (647 bytes, patch)
2021-12-27 00:03 UTC, Leif Liddy
no flags Details | Diff

Description Leif Liddy 2021-11-22 03:54:42 UTC
Description of problem:
x2golistdesktops does not display active desktop sessions

Version-Release number of selected component (if applicable):
4.1.0.3

How reproducible:
Always

Steps to Reproduce:
1. Start desktop session
2. Install x2goserver 
3. run x2golistdesktops


Actual results:
null output

Expected results:
output should display active desktop sessions

Additional info:
The issue is that x2golistdesktops contains this line 

my $inf=system_capture_stdout_output("timeout", "1s", "xwininfo", "-root", "-display", "$display");

However, xwininfo is not listed as a dependency of the x2goserver rpm

To resolve, just add the following to to the x2goserver.spec file

Requires:       xwininfo

Comment 1 Leif Liddy 2021-12-27 00:03:14 UTC
Created attachment 1847882 [details]
proposed patch

Comment 2 Leif Liddy 2021-12-27 00:08:03 UTC
I don't understand why this bug report can't be viewed by the general public. How could I make it publicly accessible?

Comment 3 Orion Poplawski 2021-12-29 15:21:19 UTC
Should be public now.

Comment 4 Leif Liddy 2021-12-30 07:04:06 UTC
Orion, could you just apply that patch yourself.I It should be super-easy verify the xwininfo dependency. 

I tried to do it myself, I followed the directions listed here. 
https://docs.fedoraproject.org/en-US/package-maintainers/Package_Maintenance_Guide/#_check_out_a_package

But when I attempt to checkout a package, I get this error:

[leif.liddy@black ~]$ fedpkg co x2goserver
Cloning into 'x2goserver'...
Connection closed by 38.145.60.17 port 22
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
Could not execute clone: Failed to execute command.


So of followed all of the stated directions and have created an account, uploaded my ssh key, successfully requested a kerberos ticket with kinit, created the .fedora.upn file...etc

But these error messages need to be a bit more verbose...
The error message: "Please make sure you have the correct access rights" is not very helpful to say the least. 
How exactly am I meant to ensure I have access rights when I can't access anything in the first place!? And on top of that, there doesn't seems to be any means of support aside from posting messages in the community forum and hoping someone responds with an accurate answer. I'd be much more inclined to regularly contribute to providing minor bug fixes to srpms if this process actually worked.

Comment 5 Leif Liddy 2022-01-17 21:57:50 UTC
@orion Is there any additional information that you need to verify the xwininfo dependency requirement?  


Should be pretty easy to verify:

[root@fedora ~]$ rpm -qf /usr/bin/x2golistdesktops
x2goserver-4.1.0.3-13.fc35.x86_64


[root@fedora ~]$ grep xwininfo /usr/bin/x2golistdesktops
			my $inf=system_capture_stdout_output("timeout", "1s", "xwininfo", "-root", "-display", "$display");


Please let me know if you need any help with anything or if you require any sort of additional info/data.

Thanks!

Comment 6 Orion Poplawski 2022-01-19 04:15:10 UTC
Sorry, just very busy and other things kept jumping to the front.

Comment 7 Fedora Update System 2022-01-19 04:32:23 UTC
FEDORA-2022-5f809e95f9 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2022-5f809e95f9

Comment 8 Fedora Update System 2022-01-19 04:32:24 UTC
FEDORA-2022-d680044979 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-d680044979

Comment 9 Fedora Update System 2022-01-20 11:44:01 UTC
FEDORA-2022-5f809e95f9 has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2022-5f809e95f9`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-5f809e95f9

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2022-01-20 19:59:31 UTC
FEDORA-2022-d680044979 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2022-d680044979`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-d680044979

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2022-01-27 19:38:04 UTC
FEDORA-2022-5f809e95f9 has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 12 Fedora Update System 2022-01-28 01:35:35 UTC
FEDORA-2022-d680044979 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.