Spec URL: https://download.copr.fedorainfracloud.org/results/frostyx/rofi-themes-base16/fedora-rawhide-x86_64/02981821-rofi-themes-base16/rofi-themes-base16.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/frostyx/rofi-themes-base16/fedora-rawhide-x86_64/02981821-rofi-themes-base16/rofi-themes-base16-0.1.0-1.fc36.src.rpm Description: A collection of base16 themes for rofi Fedora Account System Username: frostyx
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== Issues ===== - The installation process does not preserve timestamps. Please add the “-p” option to “cp” in %install. ===== Notes (no change rquired) ===== - I’m noting that /usr/share/rofi/ and /usr/share/rofi/themes/ are owned by rofi-themes, which is a dependency of rofi, which this package depends on. Directory ownership requirements are thus indirectly satisfied. I think you could also make a case that the package that currently owns the directory, rofi-themes, is *not* a natural dependency of this package, and that this package does not *have* to depend on rofi either—while it is not very useful without rofi, it still satisfies its function of “providing themes that rofi could use”—and so it would also be acceptable to remove the dependency on rofi and co-own “%dir %{_datadir}/rofi” and “%dir %{_datadir}/rofi/themes” in the %files section. It seems that people could reasonably disagree on which approach is better, and I don’t think it matters too much in the end. No change is required. - It seems like this is, in some sense, an “add-on for a GUI application,” so consider asking upstream about a .metainfo.xml file[1] following the AppStream add-ons specification[2]. This isn’t a requirement for approval, and to be honest, I’m not sure anything can be done until rofi itself provides AppStream data. [1] https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/ [2] https://www.freedesktop.org/software/appstream/docs/sect-Quickstart-Addons.html ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT License", "Unknown or generated". 552 files have unknown license. Detailed output of licensecheck in /home/reviewer/2025395-rofi-themes-base16/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. Upstream does not provide tests [!]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://github.com/jordiorlando/base16-rofi/archive/v0.1.0/rofi-themes-base16-0.1.0.tar.gz : CHECKSUM(SHA256) this package : def47cf011755f073c3ef8d11bba2a070972adb7de0338def9950719f12f6f51 CHECKSUM(SHA256) upstream package : def47cf011755f073c3ef8d11bba2a070972adb7de0338def9950719f12f6f51 Requires -------- rofi-themes-base16 (rpmlib, GLIBC filtered): rofi Provides -------- rofi-themes-base16: rofi-themes-base16 Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 2025395 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: Perl, Java, SugarActivity, R, PHP, Python, Haskell, Ocaml, fonts, C/C++ Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Thank you for the review Ben, > - The installation process does not preserve timestamps. Please add the “-p” > option to “cp” in %install. Fixed > - I’m noting that /usr/share/rofi/ and /usr/share/rofi/themes/ are owned by > rofi-themes, which is a dependency of rofi, which this package depends on. > Directory ownership requirements are thus indirectly satisfied. To be sure, I added a dependency to rofi-themes, so the directory ownership isn't satisfied transitively now. Adding /usr/share/rofi/ into %files can work as well but I would rather do it once somebody has a use-case for this package without installing rofi and rofi-themes. Spec URL: https://download.copr.fedorainfracloud.org/results/frostyx/rofi-themes-base16/fedora-rawhide-x86_64/03094916-rofi-themes-base16/rofi-themes-base16.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/frostyx/rofi-themes-base16/fedora-rawhide-x86_64/03094916-rofi-themes-base16/rofi-themes-base16-0.1.0-2.fc36.src.rpm
I’ve been away from a suitable computer—I’ll return to this ASAP.
Looks good to me! Your choice on directory ownership is reasonable, and timestamps are now preserved. The package is APPROVED, with full re-review below. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== Notes (no change required) ===== - It seems like this is, in some sense, an “add-on for a GUI application,” so consider asking upstream about a .metainfo.xml file[1] following the AppStream add-ons specification[2]. This isn’t a requirement for approval, and to be honest, I’m not sure anything can be done until rofi itself provides AppStream data. [1] https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/ [2] https://www.freedesktop.org/software/appstream/docs/sect-Quickstart-Addons.html ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT License", "Unknown or generated". 552 files have unknown license. Detailed output of licensecheck in /home/reviewer/2025395-rofi-themes-base16/20220104/2025395-rofi- themes-base16/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. Upstream does not provide tests. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://github.com/jordiorlando/base16-rofi/archive/v0.1.0/rofi-themes-base16-0.1.0.tar.gz : CHECKSUM(SHA256) this package : def47cf011755f073c3ef8d11bba2a070972adb7de0338def9950719f12f6f51 CHECKSUM(SHA256) upstream package : def47cf011755f073c3ef8d11bba2a070972adb7de0338def9950719f12f6f51 Requires -------- rofi-themes-base16 (rpmlib, GLIBC filtered): rofi rofi-themes Provides -------- rofi-themes-base16: rofi-themes-base16 Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 2025395 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: SugarActivity, Java, Ocaml, C/C++, fonts, Haskell, PHP, Python, Perl, R Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH ============================ rpmlint session starts ============================ rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.1 s
Thank you for the review.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rofi-themes-base16
Package is now in repositories, closing review.