Spec URL: https://download.copr.fedorainfracloud.org/results/linkdupont/reviews/fedora-rawhide-x86_64/02981806-linapple/linapple.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/linkdupont/reviews/fedora-rawhide-x86_64/02981806-linapple/linapple-0-1.20211122git535ad7f.fc36.src.rpm Description: A Linux emulator for Apple ][+, IIe and Enhanced //e with Mockingboard support Fedora Account System Username: linkdupont Fedora Review: https://download.copr.fedorainfracloud.org/results/linkdupont/reviews/fedora-rawhide-x86_64/02981806-linapple/fedora-review
Hello Link, thank you for the package. I tried to run it and it worked for me. The spec file is well-written as well. I have only a couple of suggestions. > Patch0: fix-makefile.patch > Patch1: silence-const-char-errors.patch We try to be upstream-first, can you please submit those patches as pull requests, and link them in the spec as comments? Then we can easily check if they are merged and that we can drop the custom patches. If upstream is not interested in such changes and won't merge, at least we tried and have justification for maintaining those patches here. > %global commit 535ad7fc57378025757461dcb582db8b4c944564 > %global forgeurl https://github.com/linappleii/linapple > Version: 0 I am looking at https://github.com/linappleii/linapple/blob/master/CHANGELOG and I think the current version is 2.1 So maybe we should package from this commit https://github.com/linappleii/linapple/commit/c78c192141f5024f7c8618992d71754231cbff71 or maybe some other commit, that marks the 2.1 version? It's from 2017 though, if we need some newer version, can you please ask upstream to create a new release?
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time, but it seems that the review is still being working out by you. If this is right, please respond to this comment clearing the NEEDINFO flag and try to reach out the submitter to proceed with the review. If you're not interested in reviewing this ticket anymore, please clear the fedora-review flag and reset the assignee, so that a new reviewer can take this ticket. Without any reply, this request will shortly be resetted.
> If you're not interested in reviewing this ticket anymore I am interested in reviewing this ticket but there is no response from the contributor.
Hey, I'm not gone... just busy. I looked at the current GitHub repository, and noticed there are no tags at all. That's probably why I set up the version as "0" and used a specific git commit. I believe this is the procedure recommended in the packaging guidelines when upstream has not published a tagged version or tarball. With version 2.1 not existing as a tag or tarball, I'd rather version it as "0" for now. If upstream decides to apply a reproducible tag, we can use that instead. I'll open the patches as pull requests to the project. That's a good point. I haven't pushed this review request forward since I'm not sure if it qualifies for inclusion in Fedora. I think it requires a ROM file in order to run. Isn't that against the packaging guidelines?
> I'm not sure if it qualifies for inclusion in Fedora. I think it requires a ROM file in order to run. Isn't that against the packaging guidelines? Good catch, thank you for pointing that out. The relevant documentation is: - https://docs.fedoraproject.org/en-US/legal/misc/#_emulators - https://docs.fedoraproject.org/en-US/packaging-guidelines/what-can-be-packaged/#_packages_which_are_not_useful_without_external_code but I am not familiar with linapple enough to make the call. I'll drop myself from the review so that somebody else can assign themselves. I'd also recommend asking on a mailing list whether this can be packaged or not: - https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/ - https://lists.fedoraproject.org/archives/list/legal@lists.fedoraproject.org/
I asked for clarification on the legal list. https://lists.fedoraproject.org/archives/list/legal@lists.fedoraproject.org/thread/O2N2FIOTIRGBWZRCOKPL3TF3AZFIC2DV/
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time. We're sorry it is taking so long. If you're still interested in packaging this software into Fedora repositories, please respond to this comment clearing the NEEDINFO flag. You may want to update the specfile and the src.rpm to the latest version available and to propose a review swap on Fedora devel mailing list to increase chances to have your package reviewed. If this is your first package and you need a sponsor, you may want to post some informal reviews. Read more at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. Without any reply, this request will shortly be considered abandoned and will be closed. Thank you for your patience.
This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it.