Bug 2025644

I don't think it is a bug.
From the installation process of libvirt:
  Installing       : libvirt-daemon-driver-storage-7.9.0-1.el9.x86_64                                                                                                                   62/70 
  Running scriptlet: libvirt-daemon-driver-storage-7.9.0-1.el9.x86_64                                                                                                                   62/70 
Created symlink /etc/systemd/system/sockets.target.wants/virtstoraged.socket → /usr/lib/systemd/system/virtstoraged.socket.           

the virtstoraged.socket enabling happens at installing libvirt-daemon-driver-storage. So you should install libvirt-daemon-driver-storage instead.

Quality Engineering Management has reviewed and declined this request. You may appeal this decision by reopening this request.

Hi hhan,

I think this is a bug. Please refer to Please refer to https://bugzilla.redhat.com/show_bug.cgi?id=2024541#c7 for details.
(In reply to Han Han from comment #1)
> I don't think it is a bug.
> From the installation process of libvirt:
>   Installing       : libvirt-daemon-driver-storage-7.9.0-1.el9.x86_64       
> 62/70 
>   Running scriptlet: libvirt-daemon-driver-storage-7.9.0-1.el9.x86_64       
> 62/70 
> Created symlink /etc/systemd/system/sockets.target.wants/virtstoraged.socket
> → /usr/lib/systemd/system/virtstoraged.socket.           
> 
> the virtstoraged.socket enabling happens at installing
> libvirt-daemon-driver-storage. So you should install
> libvirt-daemon-driver-storage instead.

I think this is a bug. Please refer to https://bugzilla.redhat.com/show_bug.cgi?id=2024541#c7 for details. 


> Created symlink /etc/systemd/system/sockets.target.wants/virtstoraged.socket

And this may move to the installing of pkg of libvirt-daemon-driver-storage-core.

Confirmed the bug with Daniel in https://bugzilla.redhat.com/show_bug.cgi?id=2024541#c9, so reopen the bug

The problem is that the spec file mentions the wrong package for the transitions:

%pre daemon-driver-storage
%libvirt_sysconfig_pre virtstoraged

%post daemon-driver-storage
%if %{with_modular_daemons}
%libvirt_daemon_systemd_post virtstoraged
%endif
%libvirt_daemon_schedule_restart virtstoraged

%preun daemon-driver-storage
%libvirt_daemon_systemd_preun virtstoraged

%posttrans daemon-driver-storage
%libvirt_sysconfig_posttrans virtstoraged
%libvirt_daemon_perform_restart virtstoraged

All of the above should be 'daemon-driver-storage-core' for this to work properly.

Fixed upstream:

commit aaec8c91aef5524e33329577d066ab4bb8dcc7dd
Author: Peter Krempa <pkrempa>
Date:   Wed Jan 19 13:41:28 2022 +0100

    spec: Run pre/post-install stuff on 'daemon-driver-storage-core'
    
    'daemon-driver-storage' is just a meta-package, the actual daemon is in
    the 'daemon-driver-storage-core' package, so without installing the meta
    package the storage daemon is not being enabled.
    
    Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2025644
    Fixes: 50eae3f8859, b8ef6255444
    Signed-off-by: Peter Krempa <pkrempa>
    Reviewed-by: Daniel P. Berrangé <berrange>
    Reviewed-by: Andrea Bolognani <abologna>

v8.0.0-111-gaaec8c91ae

Tested. Works on systemd-250.3-1.fc36.x86_64 libvirt-v8.0.0-118-g755b16d10a:
➜  ~ systemctl status virtstoraged.socket
● virtstoraged.socket - Libvirt storage local socket
     Loaded: loaded (/usr/lib/systemd/system/virtstoraged.socket; enabled; vendor preset: enabled)
     Active: active (listening) since Thu 2022-01-20 04:09:49 UTC; 2min 13s ago
      Until: Thu 2022-01-20 04:09:49 UTC; 2min 13s ago
   Triggers: ● virtstoraged.service
     Listen: /run/libvirt/virtstoraged-sock (Stream)
     CGroup: /system.slice/virtstoraged.socket

Works on libvirt-daemon-8.0.0-2.el9.x86_64
➜  ~ dnf install libvirt-daemon-driver-storage -y                                                                                                             
Failed to set locale, defaulting to C.UTF-8                                                                                                                   
Last metadata expiration check: 0:47:00 ago on Fri Jan 28 02:37:50 2022.                                                                                      
Dependencies resolved.                                                                                                                                        
==============================================================================================================================================================
 Package                                                Architecture            Version                                      Repository                  Size 
==============================================================================================================================================================
Installing:                                                                                                                                                   
 libvirt-daemon-driver-storage                          x86_64                  8.0.0-2.el9                                  AppStream                   14 k 

➜  ~ systemctl status virtstoraged.socket
○ virtstoraged.socket - Libvirt storage local socket
     Loaded: loaded (/usr/lib/systemd/system/virtstoraged.socket; enabled; vendor preset: enabled)
     Active: inactive (dead)
   Triggers: ● virtstoraged.service
     Listen: /run/libvirt/virtstoraged-sock (Stream)

virtstoraged.socket is enabled.
Work as expected.

This got fixed in Fedora 36, but Fedora 35 still suffers from this. `rpm -qi --scripts libvirt-daemon-driver-storage` confirms that the unit is enabled from that meta-package only, which isn't necessarily installed. Is this planned to get fixed in F35 already, or shall I clone the bug? Thanks!

(In reply to Martin Pitt from comment #13)
> This got fixed in Fedora 36, but Fedora 35 still suffers from this. `rpm -qi
> --scripts libvirt-daemon-driver-storage` confirms that the unit is enabled
> from that meta-package only, which isn't necessarily installed. Is this
> planned to get fixed in F35 already, or shall I clone the bug? Thanks!

We don't initiatively backport patches to Fedora. If you need it fixed, please open a bug and make sure to point to the patches so that fedora maintainers can backport them.

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (new packages: libvirt), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:2390