Spec URL: https://download.nohats.ca/golang-github-letsencrypt-pebble/golang-github-letsencrypt-pebble.spec SRPM URL: https://download.nohats.ca/golang-github-letsencrypt-pebble/golang-github-letsencrypt-pebble-2.3.1-1.fc34.src.rpm Description: Pebble is a miniature version of Boulder, a small RFC 8555 ACME test server Fedora Account System Username: pwouters
2 changes requested (see WARN and Issues). [WARN] no-manual-page-for-binary can (?) be fixed: upstream had only one commit (abe2768b4c05f15dcde7626b484a7fdf1165a73a) between the release and adding man pages (81e322f7a0e97ae3674fa4332637f2f7d9735c54), which is not documented in there, so I would add man pages separately. [NOTE] hidden-file-or-dir and description-line-too-long There is nothing we can do about these items. [NOTE] Lots of other packages own /usr/share/gocode/src/github.com, it's fine. Can't be fixed here anyway. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/doc/golang-github- letsencrypt-pebble/README.md The root REAME.md is overwritten with cmd/pebble-challtestsrv/README.md. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. Licenses found: "Unknown or generated", "*No copyright* Mozilla Public License 2.0", "*No copyright* [generated file]", "BSD 3-clause "New" or "Revised" License", "*No copyright* Apache License 2.0", "Apache License 2.0". 599 files have unknown license. Detailed output of licensecheck in /home/rominf/dev/fedora- scm/review/2025712-golang-github-letsencrypt-pebble/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [-]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/gocode/src/github.com. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in golang- github-letsencrypt-pebble-devel [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: golang-github-letsencrypt-pebble-2.3.1-1.fc36.x86_64.rpm golang-github-letsencrypt-pebble-devel-2.3.1-1.fc36.noarch.rpm golang-github-letsencrypt-pebble-debuginfo-2.3.1-1.fc36.x86_64.rpm golang-github-letsencrypt-pebble-debugsource-2.3.1-1.fc36.x86_64.rpm golang-github-letsencrypt-pebble-2.3.1-1.fc36.src.rpm golang-github-letsencrypt-pebble.x86_64: W: no-manual-page-for-binary pebble golang-github-letsencrypt-pebble.x86_64: W: no-manual-page-for-binary pebble-challtestsrv golang-github-letsencrypt-pebble-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/letsencrypt/pebble/.goipath golang-github-letsencrypt-pebble-debugsource.x86_64: E: description-line-too-long C This package provides debug sources for package golang-github-letsencrypt-pebble. 5 packages and 0 specfiles checked; 1 errors, 3 warnings. Rpmlint (debuginfo) ------------------- Checking: golang-github-letsencrypt-pebble-debuginfo-2.3.1-1.fc36.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://github.com/letsencrypt/pebble/archive/v2.3.1/pebble-2.3.1.tar.gz : CHECKSUM(SHA256) this package : 02e13046dc1cc1d9b1aab386eaa3c94f5bd6cd9cf51f860d54a806766104e315 CHECKSUM(SHA256) upstream package : 02e13046dc1cc1d9b1aab386eaa3c94f5bd6cd9cf51f860d54a806766104e315 Requires -------- golang-github-letsencrypt-pebble (rpmlib, GLIBC filtered): libc.so.6()(64bit) golang-github-letsencrypt-pebble-devel (rpmlib, GLIBC filtered): go-filesystem golang(github.com/letsencrypt/challtestsrv) golang(github.com/miekg/dns) golang(gopkg.in/square/go-jose.v2) golang-github-letsencrypt-pebble-debuginfo (rpmlib, GLIBC filtered): golang-github-letsencrypt-pebble-debugsource (rpmlib, GLIBC filtered): Provides -------- golang-github-letsencrypt-pebble: golang-github-letsencrypt-pebble golang-github-letsencrypt-pebble(x86-64) golang-github-letsencrypt-pebble-devel: golang(github.com/letsencrypt/pebble/acme) golang(github.com/letsencrypt/pebble/ca) golang(github.com/letsencrypt/pebble/cmd) golang(github.com/letsencrypt/pebble/core) golang(github.com/letsencrypt/pebble/db) golang(github.com/letsencrypt/pebble/va) golang(github.com/letsencrypt/pebble/wfe) golang-github-letsencrypt-pebble-devel golang-ipath(github.com/letsencrypt/pebble) golang-github-letsencrypt-pebble-debuginfo: debuginfo(build-id) golang-github-letsencrypt-pebble-debuginfo golang-github-letsencrypt-pebble-debuginfo(x86-64) golang-github-letsencrypt-pebble-debugsource: golang-github-letsencrypt-pebble-debugsource golang-github-letsencrypt-pebble-debugsource(x86-64) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 2025712 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, C/C++ Disabled plugins: Haskell, Perl, Ocaml, PHP, fonts, SugarActivity, Python, Java, R Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Spec URL: https://download.nohats.ca/golang-github-letsencrypt-pebble/golang-github-letsencrypt-pebble.spec SRPM URL: https://download.nohats.ca/golang-github-letsencrypt-pebble/golang-github-letsencrypt-pebble-2.3.1-2.fc35.src.rpm - pulled in the man pages from upstream commit. - renamed one README.md to avoid clash/overwrite
1 change is requested. This line is duplicated: ``` install -m 0755 -vd %{buildroot}%{_bindir} ``` I think that the first occurrence can be safely removed. Otherwise, looks good, I will approve it after a fix.
oops. yes I did it on one line first, then split the line and forgot to delete it. Spec URL: https://download.nohats.ca/golang-github-letsencrypt-pebble/golang-github-letsencrypt-pebble.spec SRPM URL: https://download.nohats.ca/golang-github-letsencrypt-pebble/golang-github-letsencrypt-pebble-2.3.1-3.fc35.src.rpm
APPROVED!
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-letsencrypt-pebble
FEDORA-2021-5193940620 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-5193940620
FEDORA-2021-878a4f7bf8 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-878a4f7bf8
FEDORA-2021-878a4f7bf8 has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-878a4f7bf8 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-878a4f7bf8 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2021-5193940620 has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-5193940620 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-5193940620 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2021-878a4f7bf8 has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2021-5193940620 has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report.