Bug 2026702 - User-defined validation rule data section deleted from "forklift-validation-config" config map during pod reconciliation
Summary: User-defined validation rule data section deleted from "forklift-validation-c...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Migration Toolkit for Virtualization
Classification: Red Hat
Component: General
Version: 2.2.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: 2.2.0
Assignee: Fabien Dupont
QA Contact: Ilanit Stein
Avital Pinnick
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-11-25 14:21 UTC by Ilanit Stein
Modified: 2021-12-09 19:21 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-12-09 19:21:13 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github konveyor forklift-operator pull 193 0 None open Bug 2026702: Do not override controller and validation service configmaps 2021-11-25 15:19:56 UTC
Github konveyor forklift-operator pull 194 0 None open Bug 2026702: Do not override controller and validation service configmaps 2021-11-25 15:22:59 UTC
Github konveyor forklift-operator pull 197 0 None Merged Bug 2026702: Do not initialize empty data structure on validation config map 2021-11-29 23:05:49 UTC
Red Hat Product Errata RHEA-2021:5066 0 None None None 2021-12-09 19:21:18 UTC

Description Ilanit Stein 2021-11-25 14:21:59 UTC
Description of problem:
A data section with additional user defined rule, added to forklift-validation-config, by this example [1], is removed by pod reconciling.

[1]
https://github.com/pemcg/forklift-validation/tree/update_readme#user-defined-additional-rules

Version-Release number of selected component (if applicable):
MTV-2.2

How reproducible:
Tried twice on the same PSI based cluster

Expected results:
User defined rule data should not be removed.

Comment 1 Fabien Dupont 2021-11-26 15:35:39 UTC
With the change, the configmap should be reconciled if it already exists. If the configmap content is breaking the validation service, deleting the configmap will force the operator to create a new empty configmap, resetting the validation service.

Please verify with mtv-operator-bundle-container-2.2.0-100 / ii:138977, or later.

Comment 2 Ilanit Stein 2021-11-28 14:51:03 UTC
Verified on MTV-2.2.0-100.

A data section with additional user defined rule, added to forklift-validation-config, by this example [1], and it is not removed by pod reconciling.

[1]
https://github.com/pemcg/forklift-validation/tree/update_readme#user-defined-additional-rules

It was tested for VMware to a target namespace openshit-mtv as well as a new created namespace.

This it the validation "information" message displayed in UI, for a VM with 2 disks:

"Multiple disks detected: Example user-supplied extra validation rule - multiple disks have been detected on this VM".

"MultiDisks" Screenshot attached.

Comment 4 Franco Bladilo 2021-11-29 23:06:54 UTC
Please see build 2.2.0-102 for latest revision of the fix for this issue.

Comment 5 Ilanit Stein 2021-12-07 12:46:48 UTC
Tested on MTV-2.2.0-104.

A data section with additional user defined rule, added to forklift-validation-config, by example [1].
[1] https://github.com/pemcg/forklift-validation/tree/update_readme#user-defined-additional-rules

It was tested for VMware to a target namespace other than openshift-mtv.

This is the validation "information" message displayed in UI, for a VM with 2 disks:

"Multiple disks detected: Example user-supplied extra validation rule - multiple disks have been detected on this VM".

Continue to track the config map for the coming hours, to ensure reconcile doesn't reset the configMap to it's initial content.

Comment 6 Ilanit Stein 2021-12-07 14:58:13 UTC
Moving bug to verified as after couple of hours data still remains in the validation configMap.

Comment 9 errata-xmlrpc 2021-12-09 19:21:13 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (MTV 2.2.0 Images), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2021:5066


Note You need to log in before you can comment on or make changes to this bug.