Bug 2027087 - [RFE] Warn the user on too many hosted-engine hosts
Summary: [RFE] Warn the user on too many hosted-engine hosts
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: ovirt-host-deploy-ansible
Version: 4.4.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ovirt-4.5.1
: 4.5.0
Assignee: Dana
QA Contact: Pavel Novotny
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-11-28 07:28 UTC by Yedidyah Bar David
Modified: 2022-06-27 10:12 UTC (History)
4 users (show)

Fixed In Version: ovirt-engine-4.5.0
Clone Of:
Environment:
Last Closed: 2022-06-27 07:10:40 UTC
oVirt Team: Infra
Embargoed:
mperina: ovirt-4.5+
pm-rhel: planning_ack?
mperina: devel_ack+
gdeolive: testing_ack+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github oVirt ovirt-engine pull 497/ 0 None None None 2022-06-27 08:11:09 UTC
Red Hat Bugzilla 1399613 1 None None None 2021-12-09 09:16:43 UTC
Red Hat Issue Tracker RHV-44094 0 None None None 2021-11-28 07:29:08 UTC
oVirt gerrit 118221 0 master MERGED engine: warn the user when deploying more than 7 HE hosts 2022-02-03 16:56:17 UTC

Description Yedidyah Bar David 2021-11-28 07:28:05 UTC
Description of problem:

When adding a host, if the user asks to deploy the host as a hosted-engine host, and we already have many such hosts, perhaps more than 7, warn the user that this isn't recommended.

See also bug 2026625.

Comment 1 Nikolai Sednev 2021-12-06 08:22:04 UTC
How much hosts is OK and after which exact number of hosts will user receive the warning message?

Comment 2 Yedidyah Bar David 2021-12-06 08:41:48 UTC
(In reply to Nikolai Sednev from comment #1)
> How much hosts is OK and after which exact number of hosts will user receive
> the warning message?

The number '7' in comment 0 is already mentioned in our docs:

https://access.redhat.com/documentation/en-us/red_hat_virtualization/4.4/html-single/planning_and_prerequisites_guide/index#self-hosted-engine-recommendations

https://access.redhat.com/articles/906543

I mentioned this in referenced bug 2026625 comment 1. Sorry for not mentioning this in comment 0 here.

Comment 3 Nikolai Sednev 2021-12-06 12:19:56 UTC
So we'll have to try it with at least 8 ha-hosts, to be able to get the warning message. 
7-should be added OK.
8-th should trigger the warning?
Should 8-th ha-host still be added or the warning will also restrict adding additional 8-th ha-host?

Comment 4 Yedidyah Bar David 2021-12-06 12:35:42 UTC
I'd leave this to the bug owner to design/decide/split/consult/whatever.

IMO warning is enough, no need to prevent. If we do prevent, we'll likely want to make this configurable (to allow testing, specific special cases, etc.), so likely more complicated.

The design should probably include at least specifying manual/UI behavior (a popup?) and API (a notification? audit log? something else?).

Comment 5 Yedidyah Bar David 2021-12-06 12:38:29 UTC
BTW: Some time ago someone suggested somewhere also the opposite feature: If you add a host, and this is a hosted-engine setup, and you only have one HA host, you should get a warning suggesting to deploy HE HA on the host you are adding. Not sure if we ever did this. Might make sense to include this in current bug otherwise.

Comment 6 Nikolai Sednev 2021-12-07 10:09:10 UTC
(In reply to Yedidyah Bar David from comment #5)
> BTW: Some time ago someone suggested somewhere also the opposite feature: If
> you add a host, and this is a hosted-engine setup, and you only have one HA
> host, you should get a warning suggesting to deploy HE HA on the host you
> are adding. Not sure if we ever did this. Might make sense to include this
> in current bug otherwise.

Sounds very logical to have at least 2 ha-hosts, although warning message could pretty annoying. 

(In reply to Yedidyah Bar David from comment #4)
> I'd leave this to the bug owner to design/decide/split/consult/whatever.
> 
> IMO warning is enough, no need to prevent. If we do prevent, we'll likely
> want to make this configurable (to allow testing, specific special cases,
> etc.), so likely more complicated.
> 
> The design should probably include at least specifying manual/UI behavior (a
> popup?) and API (a notification? audit log? something else?).

Yes, looks like the whole RFE is about adding only a warning, I didn't follow it from the beginning.
I suppose its for a scale team to verify, as it will require at least 8 ha-hosts, 7 should behave normally, adding of 8-th should trigger the warning, but continue normally and not cause any issues adding it or even more ha-hosts.
IMHO warning should appear after adding 8-th and any additional to it, so warning will appear for 8-th, 9-th, 10-th and so on.

Comment 7 Yedidyah Bar David 2021-12-15 13:57:54 UTC
Technically speaking, we do allow many more hosts, see bug 1916032.

Bug 1399613 was the original suggestion of comment 5 (mentioning also here because the link added with "Link ID" does not show anything when hovering above it, but here it does).

Comment 9 Pavel Novotny 2022-06-23 22:45:51 UTC
Verified in ovirt-engine-4.5.1.2-0.11.el8ev

When adding new HE host, a warning log message is shown if the number of recommended HE hosts is exceeded (by default 7), e.g.:
  "There are 8 HE hosts deployed. Deploying more than 7 HE hosts isn't recommended. Please remove dead hosts, if any, in order to get rid of this warning"

The default value can be changed via `MAX_RECOMMENDED_HE_HOSTS` variable in a config file put in /etc/ovirt-engine/engine.conf.d/ directory.


Note You need to log in before you can comment on or make changes to this bug.