RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 2027683 - python tapset regression
Summary: python tapset regression
Keywords:
Status: CLOSED ERRATA
Alias: None
Deadline: 2021-12-27
Product: Red Hat Enterprise Linux 9
Classification: Red Hat
Component: systemtap
Version: 9.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: Frank Ch. Eigler
QA Contact: Martin Cermak
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-11-30 12:54 UTC by Martin Cermak
Modified: 2022-05-17 13:36 UTC (History)
7 users (show)

Fixed In Version: systemtap-4.6-8.el9
Doc Type: No Doc Update
Doc Text:
If this bug requires documentation, please select an appropriate Doc Type value.
Clone Of:
Environment:
Last Closed: 2022-05-17 13:27:54 UTC
Type: Bug
Target Upstream Version:
Embargoed:
pm-rhel: mirror+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker RHELPLAN-104290 0 None None None 2021-11-30 12:57:27 UTC
Red Hat Product Errata RHBA-2022:2514 0 None None None 2022-05-17 13:28:04 UTC

Description Martin Cermak 2021-11-30 12:54:06 UTC
Python dropped tapset file allowing SystemTap to convenitntly use provided static markers.

On RHEL-7 that is:
# rpm -qf /usr/share/systemtap/tapset/libpython2.7-64.stp
python-libs-2.7.5-90.el7.x86_64

On RHEL-8 that is:
# rpm -qf /usr/share/systemtap/tapset/libpython2.7-64.stp
python2-libs-2.7.17-1.module+el8.2.0+4561+f4e0d66a.x86_64

On RHEL-9 the tapset file is missing.

Please, fix the regression.

Comment 1 Petr Viktorin (pviktori) 2021-12-01 13:20:25 UTC
This file was never provided for python3.
We can add it downstream, but we're only comfortable adding it if we can test it. AFAIK, it wasn't tested before.
Could you provide some instructions on how this file can be tested?

Comment 3 Petr Viktorin (pviktori) 2021-12-15 13:27:12 UTC
On further investigation, /usr/share/systemtap/tapset/python3.stp exists in RHEL; it's provided by systemtap-client.
Is that the file you're looking for?

If not, since systemtap-client is already providing Python integration, shouldn't it provide this file as well?

Comment 4 Martin Cermak 2022-01-18 09:27:38 UTC
(In reply to Petr Viktorin from comment #3)
> On further investigation, /usr/share/systemtap/tapset/python3.stp exists in
> RHEL; it's provided by systemtap-client.
> Is that the file you're looking for?

Nope.  What I'm missing is a trivial tapset file defining the python.function.entry and python.function.return probes.  On my rhel9 test system, that file would look like this:

====== 8< ======
/* Systemtap tapset to make it easier to trace Python */

/*
   Define python.function.entry/return:
*/
probe python.function.entry = process("python").library("/usr/lib64/libpython3.9.so.1.0").mark("function__entry")
{
    filename = user_string($arg1);
    funcname = user_string($arg2);
    lineno = $arg3;
}
probe python.function.return = process("python").library("/usr/lib64/libpython3.9.so.1.0").mark("function__return")
{
    filename = user_string($arg1);
    funcname = user_string($arg2);
    lineno = $arg3;
}
====== 8< ======

It is analogy to /usr/lib64/libpython3.6m.so.1.0 packaged within python3-libs-3.6.8-18.el7.x86_64, or /usr/share/systemtap/tapset/libpython2.7-64.stp packaged within python2-libs-2.7.18-8.module+el8.6.0+12703+136ebe63.x86_64

> If not, since systemtap-client is already providing Python integration,
> shouldn't it provide this file as well?

The practical problem here is that systemtap doesn't know the library name to probe.  At the python.rpm brew build time, you can use the rpm macros to reliably generate this tapset file.  That can hardly be done on the systemtap side.  Could you, please put this missing tapset file back to python3-libs.rpm?

Comment 5 Martin Cermak 2022-01-20 17:35:21 UTC
After some testing, included that file in the systemtap tree:
https://sourceware.org/git/?p=systemtap.git;a=commit;h=39b5233271b997811632871e1b6620a89b384fe8

Comment 6 Petr Viktorin (pviktori) 2022-01-21 13:21:15 UTC
Thanks. I didn't know wildcards were possible, this way it looks better. And systemtap maintainers are probably better people to test this.
One more thing: what's the "python"? If it's the name of the executable, it might be good to add `python3` and `python3.*`.

Comment 8 Martin Cermak 2022-01-21 15:10:32 UTC
(In reply to Petr Viktorin from comment #6)
> One more thing: what's the "python"? If it's the name of the executable, it
> might be good to add `python3` and `python3.*`.

That's a symlink to python3 provided by python-unversioned-command.rpm.  Without it, the tapset wouldn't work.  Re-fixed: 
https://sourceware.org/git/?p=systemtap.git;a=commitdiff;h=3b2d9da3d014f6470c7eb9533f5e0249ca977e3e;hp=39b5233271b997811632871e1b6620a89b384fe8  

Thanks!

Comment 10 Martin Cermak 2022-01-24 11:36:58 UTC
Verified, all arches.

Comment 13 errata-xmlrpc 2022-05-17 13:27:54 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (new packages: systemtap), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:2514


Note You need to log in before you can comment on or make changes to this bug.