Bug 2028187 - Console build doesn't pass on Node.js 16 because node-sass doesn't support it
Summary: Console build doesn't pass on Node.js 16 because node-sass doesn't support it
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Dev Console
Version: 4.10
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ---
: 4.10.0
Assignee: Christoph Jerolimov
QA Contact: spathak@redhat.com
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-12-01 16:54 UTC by Christoph Jerolimov
Modified: 2022-03-10 16:31 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-03-10 16:31:35 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2022:0056 0 None None None 2022-03-10 16:31:55 UTC

Description Christoph Jerolimov 2021-12-01 16:54:30 UTC
Description of problem:
Also if the console CI/CD runs on Node.js 14, we should start supporting also the newer versions 15 and 16. Node.js 16 is the latest LTS version, preinstalled on Fedora and many other systems.

See also https://nodejs.org/en/about/releases/

Version-Release number of selected component (if applicable):
4.10, also previous versions or branches are affected

How reproducible:
Always with latest Node.js version ( 16)

Steps to Reproduce:
1. Switch Node.js version (for example via nvm use 16)
2. Clean your node_modules, reinstall dependencies
3. Build console

For example:
nvm use 16 # or system if your system is up to date
git clean -df && git clean -dfX
yarn install && time yarn build && time yarn build-once

Actual results:
Build works on Node.js 14 and 15, not on Node.js 16

Expected results:
Build should work on Node.js 14-16. Only supporting v16 is not enough because our CI server still use v14.

Additional info:
Followup on https://bugzilla.redhat.com/show_bug.cgi?id=2028141

Comment 2 Christoph Jerolimov 2021-12-06 09:35:16 UTC
This is solved with the switch from node-sass to sass (dart-sass) in https://issues.redhat.com/browse/CONSOLE-2975, https://github.com/openshift/console/pull/10149

Comment 3 Christoph Jerolimov 2021-12-06 10:13:39 UTC
Tested with node v16.11.1 (npm v8.0.0)

Comment 6 errata-xmlrpc 2022-03-10 16:31:35 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.10.3 security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:0056


Note You need to log in before you can comment on or make changes to this bug.