Bug 2028731 - The containerruntimeconfig controller has wrong assumption regarding the number of containerruntimeconfigs
Summary: The containerruntimeconfig controller has wrong assumption regarding the numb...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Node
Version: 4.10
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: 4.10.0
Assignee: Qi Wang
QA Contact: Weinan Liu
URL:
Whiteboard:
Depends On:
Blocks: 2032985
TreeView+ depends on / blocked
 
Reported: 2021-12-03 04:25 UTC by Qi Wang
Modified: 2022-03-10 16:31 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-03-10 16:31:36 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift machine-config-operator pull 2846 0 None open fixes 1 to 1 containerruntime config mapping 2021-12-03 04:25:31 UTC
Red Hat Product Errata RHSA-2022:0056 0 None None None 2022-03-10 16:31:53 UTC

Description Qi Wang 2021-12-03 04:25:32 UTC
Description of problem:

$ oc get mc
NAME                                               GENERATEDBYCONTROLLER                      IGNITIONVERSION   AGE
00-master                                          c533e61a9e4f459b882f94214713efff8b1e8604   3.2.0             60m
00-worker                                          c533e61a9e4f459b882f94214713efff8b1e8604   3.2.0             60m
01-master-container-runtime                        c533e61a9e4f459b882f94214713efff8b1e8604   3.2.0             60m
01-master-kubelet                                  c533e61a9e4f459b882f94214713efff8b1e8604   3.2.0             60m
01-worker-container-runtime                        c533e61a9e4f459b882f94214713efff8b1e8604   3.2.0             60m
01-worker-kubelet                                  c533e61a9e4f459b882f94214713efff8b1e8604   3.2.0             60m
99-master-generated-containerruntime               c533e61a9e4f459b882f94214713efff8b1e8604   3.2.0             14m
99-master-generated-containerruntime-2             c533e61a9e4f459b882f94214713efff8b1e8604   3.2.0             7m43s
99-master-generated-containerruntime-3             c533e61a9e4f459b882f94214713efff8b1e8604   3.2.0             7m17s
99-master-generated-containerruntime-7             c533e61a9e4f459b882f94214713efff8b1e8604   3.2.0             43s
99-master-generated-containerruntime-8             c533e61a9e4f459b882f94214713efff8b1e8604   3.2.0             30s
99-master-generated-containerruntime-9             c533e61a9e4f459b882f94214713efff8b1e8604   3.2.0             20s
99-master-generated-registries                     c533e61a9e4f459b882f94214713efff8b1e8604   3.2.0             60m
99-master-ssh                                                                                 3.2.0             64m
99-worker-generated-containerruntime               c533e61a9e4f459b882f94214713efff8b1e8604   3.2.0             16m
99-worker-generated-containerruntime-1             c533e61a9e4f459b882f94214713efff8b1e8604   3.2.0             11m
99-worker-generated-containerruntime-4             c533e61a9e4f459b882f94214713efff8b1e8604   3.2.0             102s
99-worker-generated-containerruntime-5             c533e61a9e4f459b882f94214713efff8b1e8604   3.2.0             82s
99-worker-generated-containerruntime-6             c533e61a9e4f459b882f94214713efff8b1e8604   3.2.0             70s
99-worker-generated-registries                     c533e61a9e4f459b882f94214713efff8b1e8604   3.2.0             60m
99-worker-ssh                                                                                 3.2.0             64m
rendered-master-15196ba60f515b1fdce819754727ff7d   c533e61a9e4f459b882f94214713efff8b1e8604   3.2.0             14m
rendered-master-83650f30ed153394209ca0b54339dd8c   c533e61a9e4f459b882f94214713efff8b1e8604   3.2.0             7m40s
rendered-master-cf39fe972d6d33c8d232e5c3d3a6b0b9   c533e61a9e4f459b882f94214713efff8b1e8604   3.2.0             60m
rendered-worker-50b2c5c16d00a57a13e27948c2ea9fa4   c533e61a9e4f459b882f94214713efff8b1e8604   3.2.0             60m
rendered-worker-b57e01b5ebc33a82ddf4e5d729a19835   c533e61a9e4f459b882f94214713efff8b1e8604   3.2.0             16m

$ oc create -f /home/qiwan/test-crds/overlay-size.yml
containerruntimeconfig.machineconfiguration.openshift.io/producebug created
$ oc describe containerruntimeconfig.machineconfiguration.openshift.io/producebug
Status:
  Conditions:
    Last Transition Time:  2021-12-03T04:09:25Z
    Message:               could not get ctrcfg key: max number of supported ctrcfgs (10) has been reached. Please delete old ctrcfgs before retrying
    Status:                False
    Type:                  Failure
  Observed Generation:     1
Events:                    <none>


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. Create some containerruntimeconfigs to master pool after creating containerruntimeconfigs to worker pool.


Actual results:
Report status: Master pool containerruntimeconfigs reached the upper limit 10, but the actual number of containeruntimeconfigs is less than 10. 
The generated machine config names with the suffix are mismatched between worker pool and master pool mc


Expected results:
The limit of 10 is for each pool.


Additional info:

Comment 2 Qi Wang 2021-12-07 16:55:04 UTC
weinliu Could you test it using the different label for master and worker pool instead of reapplying the same label?

Comment 5 Weinan Liu 2021-12-15 06:48:07 UTC
$ oc get ContainerRuntimeConfig
NAME                      AGE
custom-pidslimit          6m30s
custom-pidslimit-master   7s    <== Verified to get fixed
custom-pidslimit10        4m22s
custom-pidslimit11        4m14s
custom-pidslimit2         5m59s
custom-pidslimit3         5m52s
custom-pidslimit4         5m45s
custom-pidslimit5         5m39s
custom-pidslimit6         5m32s
custom-pidslimit7         5m25s
custom-pidslimit8         5m20s
custom-pidslimit9         5m10s

$ oc get clusterversion
NAME      VERSION                              AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.10.0-0.nightly-2021-12-14-083101   True        False         4h55m   Cluster version is 4.10.0-0.nightly-2021-12-14-083101

Comment 8 errata-xmlrpc 2022-03-10 16:31:36 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.10.3 security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:0056


Note You need to log in before you can comment on or make changes to this bug.