Bug 2028881 - Override not working for the PerformanceProfile template
Summary: Override not working for the PerformanceProfile template
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Telco Edge
Version: 4.8
Hardware: Unspecified
OS: Unspecified
medium
high
Target Milestone: ---
: 4.10.0
Assignee: Ian Miller
QA Contact: yliu1
URL:
Whiteboard:
Depends On:
Blocks: 2030845
TreeView+ depends on / blocked
 
Reported: 2021-12-03 16:35 UTC by Mario Vázquez
Modified: 2022-03-10 16:31 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Cause: User supplied fields in PolicyGenTemplate overlay are not copied to generated manifests if the field does not exist in the base source CR. Consequence: Some user content missing. Fix: Update policyGen tool to support these fields. Result: Expected content is found in generated CR.
Clone Of:
Environment:
Last Closed: 2022-03-10 16:31:36 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift-kni cnf-features-deploy pull 833 0 None open Bug 2028881: ztp: Support for user content not in the source-cr 2021-12-03 19:38:37 UTC
Red Hat Product Errata RHSA-2022:0056 0 None None None 2022-03-10 16:31:53 UTC

Description Mario Vázquez 2021-12-03 16:35:21 UTC
Description of problem:

In the PolicyGenTemplate we're defining a PerformanceProfile with the parameter "globallyDisableIrqLoadBalancing" set to false. When the template gets rendered we can see that it has no "globallyDisableIrqLoadBalancing" set and as such when it gets created, it gets configured with the default value which is "true". On top of that we can see that the apiVersion used is "apiVersion: performance.openshift.io/v1" and it should be "apiVersion: performance.openshift.io/v2".


The template being used:


    - fileName: PerformanceProfile.yaml
      policyName: "perfprofile-policy"
      metadata:
        name: performance-sno
        annotations:
          kubeletconfig.experimental: |
            {"topologyManagerScope": "pod",
             "systemReserved": {"memory": "9Gi"}
            }
      spec:
        additionalKernelArgs:
        - "idle=poll"
        - "rcupdate.rcu_normal_after_boot=0"
        - "nohz_full=2-15,18-19,22-23,26-31"
        cpu:
          isolated: "2-15,18-19,22-23,26-31"
          reserved: "0-1,16-17,20-21,24-25"
        globallyDisableIrqLoadBalancing: false
        hugepages:
          defaultHugepagesSize: 1G
          pages:
            - size: 1G
              count: 4
        numa:
          topologyPolicy: single-numa-node
        realTimeKernel:
          enabled: true
        net:
          userLevelNetworking: true




Version-Release number of selected component (if applicable):
4.8

How reproducible:
Always

Steps to Reproduce:
1. Create a performanceprofile template with the parameter set to false
2. Check that it gets loaded in the cluster with the default value of true
3.

Actual results:

PerformanceProfile object gets rendered without the globallyDisableIrqLoadBalancing parameter.


Expected results:


PerformanceProfile object gets rendered with the globallyDisableIrqLoadBalancing parameter.

Additional info:

Comment 2 yliu1 2022-01-07 16:22:00 UTC
Verified using cnf-features-deploy master branch.
Before and after override on my cluster:
[kni@provisionhost-0-0 ~]$ oc get performanceprofiles.performance.openshift.io -o yaml | grep Irq
    globallyDisableIrqLoadBalancing: true

[kni@provisionhost-0-0 ~]$ oc get performanceprofiles.performance.openshift.io -o yaml | grep Irq
    globallyDisableIrqLoadBalancing: false

Comment 5 errata-xmlrpc 2022-03-10 16:31:36 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.10.3 security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:0056


Note You need to log in before you can comment on or make changes to this bug.