Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 2029608

Summary: Typo in the puppet file for dellemc_powermax.pp
Product: Red Hat OpenStack Reporter: Luigi Toscano <ltoscano>
Component: puppet-tripleoAssignee: Alan Bishop <abishop>
Status: CLOSED ERRATA QA Contact: Luigi Toscano <ltoscano>
Severity: medium Docs Contact:
Priority: medium    
Version: 16.1 (Train)CC: cinder-bugs, dsorrent, jjoyce, jschluet, ltoscano, rheslop, slinaber, tkajinam, tshefi, tvignaud
Target Milestone: z8Keywords: OtherQA, Triaged
Target Release: 16.1 (Train on RHEL 8.2)   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: puppet-tripleo-11.5.0-1.20211006101607.el8ost Doc Type: Bug Fix
Doc Text:
This update corrects an error that prevented the proper use of the Cinder `powermax_port_groups` parameter.
 Story Points: ---
Clone Of: 2027759 Environment:
Last Closed: 2022-03-24 11:02:18 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2027759    
Bug Blocks:    

Description Luigi Toscano 2021-12-06 21:18:49 UTC 
+++ This bug was initially created as a clone of Bug #2027759 +++

Description of problem:

There is a typo in the puppet file for configuring Dell EMC Powermax as a Cinder Back end. The word "Powermax" is missing the letter "x" when specifying the key name.

File: /usr/share/openstack-puppet/modules/tripleo/manifests/profile/base/cinder/volume/dellemc_powermax.pp

The problem is in powermax_port_groups line near the end of the file:

        powermax_port_groups      => $backend_config['CinderPowermaPortGroups'],
      }

Note the $backend_config key is missing the 'x' in Powermax.  This should read:

        powermax_port_groups      => $backend_config['CinderPowermaxPortGroups'],
      }

Version-Release number of selected component (if applicable):

OSP 16.1 & 16.2

How reproducible:
100%

Steps to Reproduce:
1. Install OSP and try to configure Powermax as back end
2. cinder.conf file will be missing the port groups line.
3.

Actual results:
cinder.conf file will be missing the port groups line.

Expected results:
cinder.conf file will include the port groups line.

Additional info:
Comment 6 Tzach Shefi 2022-02-03 05:48:26 UTC 
Verified on:
puppet-tripleo-11.5.0-1.20211215173612.f716ef5.el8ost.noarch


Despite this being an OtherQA, which I don't often verify, it seems simple enough to test.

Added the below to my initial overcloud deployment 

/usr/share/openstack-tripleo-heat-templates/environments/ceph-ansible/ceph-ansible-external.yaml 

Plus some random data for my pseudo powermax storage:
(undercloud) [stack@undercloud-0 ~]$ cat dell.yaml 
parameter_defaults:
    BarbicanSimpleCryptoGlobalDefault: true
    CinderEnablePowermaxBackend: true
    CinderPowermaxBackendName: 'tripleo_dellemc_powermax'
    CinderPowermaxMultiConfig: {}
    CinderPowermaxAvailabilityZone: ''
    CinderPowermaxSanIp: '1.1.1.1'
    CinderPowermaxSanLogin: 'Admin'
    CinderPowermaxSanPassword: 'Nopass'
    CinderPowermaxArray: '11110000'
    CinderPowermaxSrp: 'srp_1'
    CinderPowermaxPortGroups: '80'     
    CinderPowermaxStorageProtocol: 'iSCSI'

Redeployed the overcloud resulting backend section on cinder conf looks good:

[tripleo_dellemc_powermax]
backend_host=hostgroup
volume_backend_name=tripleo_dellemc_powermax
volume_driver=cinder.volume.drivers.dell_emc.powermax.iscsi.PowerMaxISCSIDriver
san_ip=1.1.1.1
san_login=Admin
san_password=Nopass
powermax_array=11110000
powermax_srp=srp_1
powermax_port_groups=80   ----> Looks good to verify.
Comment 12 errata-xmlrpc 2022-03-24 11:02:18 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Red Hat OpenStack Platform 16.1.8 bug fix and enhancement advisory), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:0986