Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 2029947

Summary: gfs2: Incorrect gfs2 permission checks
Product: Red Hat Enterprise Linux 9 Reporter: Andreas Gruenbacher <agruenba>
Component: kernelAssignee: gfs2-maint
kernel sub component: GFS-GFS2 QA Contact: cluster-qe <cluster-qe>
Status: CLOSED ERRATA Docs Contact:
Severity: unspecified    
Priority: unspecified CC: adas, gfs2-maint
Version: unspecifiedKeywords: Triaged
Target Milestone: rcFlags: pm-rhel: mirror+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: kernel-5.14.0-59.el9 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-05-17 15:42:54 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Andreas Gruenbacher 2021-12-07 16:00:19 UTC
Description of problem:
xfstest generic/079 fails because of incorrect permission checks in gfs2.  More precisely, the vfs performs its permission checks with an unlocked inode glock, so nothing prevents the inode from changing on another node.  The filesystem then takes the inode glock and tries to perform the same permission checks again, it's only that the permission checks in the vfs no longer match the copy we have in the filesystem.

Version-Release number of selected component (if applicable):
All RHEL9.

How reproducible:
Reliably.

Steps to Reproduce:
1. Run xfstest generic/079.

Actual results:
Test should pass.

Expected results:
Test fails.

Additional info:
The fix is to put the vfs permission fix into a separate function and call that function from the filesystem. Upstream:

  026e2e197813 gfs2: Switch to may_setattr in gfs2_setattr
  435825eb4d97 fs: Move notify_change permission checks into may_setattr

Comment 7 Nate Straz 2022-02-07 22:51:30 UTC
Regression tests passed with kernel-5.14.0-54.mr242_220204_1900.el9.x86_64

Comment 11 Nate Straz 2022-04-06 18:53:26 UTC
Regression tests passed with kernel-5.14.0-70.2.1.el9_0.x86_64

Comment 13 errata-xmlrpc 2022-05-17 15:42:54 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (new packages: kernel), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:3907